summaryrefslogtreecommitdiff
path: root/epan/dissectors/packet-bgp.c
AgeCommit message (Collapse)AuthorFilesLines
2016-03-08BGP: Fix detection of additional pathUli Heilmeier1-1/+1
When additional path index are in use there must be more remaining data bytes. Therefore we return only 1 when the len is greater 1. Bug has been reported by Garri. Bug: 12240 Change-Id: Ia24311dcedc450e4208df875bc254c9744dec5dd Reviewed-on: https://code.wireshark.org/review/14396 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-02-23BGP-LS: Protocol-ID aware Prefix/Adj Flags dissectionFrancesco Fondelli1-70/+276
BGP-LS is just a collector of IGP link state information. Some fields are encoded "as-is" from the IGP, hence in order to dissect them properly we must be aware of their origin, e.g. IS-IS or OSPF. So, *before* dissecting LINK_STATE attributes we must get the 'Protocol-ID' field that is present in the MP_[UN]REACH_NLRI attribute. The tricky thing is that there is no strict order for path attributes on the wire, hence we have to keep track of 1) the 'Protocol-ID' from the MP_[UN]REACH_NLRI and 2) the offset/len of the LINK_STATE attribute. We store them in per-packet proto_data and once we got both we are ready for the LINK_STATE attribute dissection. Change-Id: Ibe2b7f5c9039ad63a72f3f9fb8a9c33c0be44ed0 Signed-off-by: Francesco Fondelli <francesco.fondelli@gmail.com> Reviewed-on: https://code.wireshark.org/review/13970 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-02-10BGP-LS: fix Adjacency-SID parsingFrancesco Fondelli1-1/+1
if length is set to 7 then the 20 *rightmost* bits of the 'SID/Label/Index' field represent a MPLS label. Change-Id: If196af244549b75a80de11c1d8e11507e9a6ce58 Signed-off-by: Francesco Fondelli <francesco.fondelli@gmail.com> Reviewed-on: https://code.wireshark.org/review/13848 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-02-02BGP-LS: fix 'TE Default Metric TLV' and 'IGP Metric TLV' lengthFrancesco Fondelli1-15/+58
parsing Change-Id: I55d0b435ae1b12e14a20dd9ea18ba05188b0e378 Signed-off-by: Francesco Fondelli <francesco.fondelli@gmail.com> Reviewed-on: https://code.wireshark.org/review/13666 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-02-01BGP: Link-State extensions for Segment Routing as perFrancesco Fondelli1-60/+227
draft-gredler-idr-bgp-ls-segment-routing-ext-01 Bug: 12060 Change-Id: I53c837ac5c195bdee716a48d8494633b663e751d Signed-off-by: Francesco Fondelli <francesco.fondelli@gmail.com> Reviewed-on: https://code.wireshark.org/review/13579 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-01-13Use result of register_dissectorPeter Wu1-4/+3
Assign result of `register_dissector(..., func, proto)` to FOO_handle and remove `FOO_handle = create_dissector_handle(func, proto)`. Found by looking for files named packet-FOO.c having the above create_dissector_handle pattern. Some files (with different dissect routines for the two functions) remain unchanged. Change-Id: Ifbed8202c6dbc63a1dae9acc03313980ffbbbb90 Reviewed-on: https://code.wireshark.org/review/13247 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-08Fix a lot of typos and misspellingsmoshekaplan1-4/+4
Change-Id: I8512cfa1d424f82a873a0e0e1d22c7b075fdd7f3 Reviewed-on: https://code.wireshark.org/review/13069 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-04Rename ipv4_addr and ipv6_addr to indicate their full contents.Guy Harris1-12/+12
They're not just addresses, they also include a mask length for IPv4 and a prefix length for IPv6. Rename them appropriately. Rename the old ipv4_addr_and_mask() and ipv6_addr_and_mask() to reflect that 1) they fetch data from a tvbuff and 2) *don't* fetch the mask length or prefix length, those lengths are passed as arguments to indicate how many bytes worth of address to fetch. Change-Id: I4cad5a186ad7bfcb60022a91dbe8bc8479e6471f Reviewed-on: https://code.wireshark.org/review/13035 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-18Removed local definitions of offsetof().Stig Bjørlykke1-5/+0
The offsetof() macro is an ANSI C library feature. Change-Id: I2ac91b0b4c94c6f6baf14133b076fdc5ed2e182b Reviewed-on: https://code.wireshark.org/review/12707 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-11Fix Recurring check found by PVS Studio (V571)Alexis La Goutte1-5/+3
packet-ncp2222.inc: The 'ncp_rec->func == 0x59' condition was already verified in line 7300. packet-bgp: The 'nlri_len < 21' condition was already verified in line 3879 packet-rtp.c: The 'p_conv_data' condition was already verified in line 1460 Change-Id: I65299718b26454596e3f25665d413a17a99e4ce0 Reviewed-on: https://code.wireshark.org/review/12341 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-12-09new_register_dissector -> register_dissector for dissector directory.Michael Mann1-1/+1
Change-Id: Ie39ef054a4a942687bd079f3a4d8c2cc55d5f22c Reviewed-on: https://code.wireshark.org/review/12485 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-09new_create_dissector_handle -> create_dissector_handle for dissector directory.Michael Mann1-1/+1
Some of the ASN.1 dissectors still generate a new_create_dissector_handle from the tool itself, so leave those for now. Change-Id: Ic6e5803b1444d7ac24070949f5fd557909a5641f Reviewed-on: https://code.wireshark.org/review/12484 Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-05BGP: fix some issueMatt Texier1-5/+22
Fixing ESI Label extended community Fixing PMSI label field decoding on 20 bits Fixing inclusive multicast Ethernet tag route Fixing Ethernet segment route Bug: 11650 Change-Id: Ifadcc3099f681a5c9480d1ccdd50b29ef4c0069f Reviewed-on: https://code.wireshark.org/review/12430 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-24Adding RFC5512 extended communityMatt Texier1-14/+70
BGP: add the ability to decode Opaque extented community and in particular tunnel type Change-Id: Ife53a267a2311397123a4e670924c673904bccbd Ping-Bug: 11650 Reviewed-on: https://code.wireshark.org/review/12076 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-23register_dissector -> new_register_dissectorMichael Mann1-7/+8
Change-Id: Ic368dd8e83cf39e0c934da0ae2744778e2d54ce6 Reviewed-on: https://code.wireshark.org/review/12050 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-18BGP: Add dissection of ESI NLRI (EVPN) RFC7432Matt Texier1-10/+174
Ping-Bug: 11650 Change-Id: I1e6418afe1d02da9f30c429c0220932d74344b8d Reviewed-on: https://code.wireshark.org/review/11775 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-04Don't include "file.h" if you don't need it.Guy Harris1-1/+1
It ends up dragging in libwireshark headers, which programs not linking with libwireshark shouldn't do. In particular, including <epan/address.h> causes some functions that refer to libwireshark functions to be defined if the compiler doesn't handle "static inline" the way GCC does, and you end up requiring libwireshark even though you shouldn't require it. Move plurality() to wsutil/str_util.h, so that non-libwireshark code can get it without include epan/packet.h. Fix includes as necessary. Change-Id: Ie4819719da4c2b349f61445112aa419e99b977d3 Reviewed-on: https://code.wireshark.org/review/11545 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-10-26Clean up more unnecessary use of the 'volatile' key word.Jeff Morriss1-2/+1
Change-Id: I3e72fddc6ed380780d7e2e1c8df87e580138188d Reviewed-on: https://code.wireshark.org/review/11271 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-10-22Use address functions instead of ADDRESS macros in asn1 and epanGerald Combs1-12/+12
Replace CMP_ADDRESS, COPY_ADDRESS, et al with their lower-case equivalents in the asn1 and epan directories. Change-Id: I4043b0931d4353d60cffbd829e30269eb8d08cf4 Reviewed-on: https://code.wireshark.org/review/11200 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-10-14Change proto_tree_add_ipv6() to take a struct e_in6_addr pointerJoão Valverde1-5/+3
tvb_get_ipv6() takes a struct e_in6_addr *, use that here too. Change-Id: Id8b368daa05c151a61d4bc01dc88c00da13e9c88 Reviewed-on: https://code.wireshark.org/review/10953 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Balint Reczey <balint@balintreczey.hu> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-10-07BGP: Add BGP-Extended Message CapabilityAlexis La Goutte1-2/+4
From draft-ietf-idr-bgp-extended-messages Update BGP Capability Codes to 2015-09-30 Change-Id: I2f3b44ad8ad7a9e5444cdfbfb22bf7d0538ffbfc Reviewed-on: https://code.wireshark.org/review/10826 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-09-08BGP: Update BGP Capability ListAlexis La Goutte1-2/+43
from IANA capability-codes 2015-07-23 * draft-ietf-idr-bgp-enhanced-route-refresh => RFC7313 * Add CP-ORF (RFC7543) * Add FQDN draft-walton-bgp-hostname-capability Change-Id: I9de73be9eca1ed2456d4a15150b040454eb01add Reviewed-on: https://code.wireshark.org/review/10442 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-09-04BGP: Fix typoguydavies1-1/+1
Change-Id: I2d33af7da22fee543d08624d06ca8880472f3586 Reviewed-on: https://code.wireshark.org/review/10377 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-08-30BGP: fixed incorrect NLRI decodingPyeole1-0/+6
Bug: 11308 Change-Id: I967b9596edad1e3656e139d0ca3a0e3c389d80ea Reviewed-on: https://code.wireshark.org/review/10308 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-06-08BGP: fix an infinite loop when finding an invalid length in EVPN NLRI Route ↵Pascal Quantin1-1/+1
Type 5 option Bug: 11256 Change-Id: I6fb037d8a3b8b0f22ebea6d08f69fb8afeed90f9 Reviewed-on: https://code.wireshark.org/review/8835 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-06-05BGP: MP (UN)REACH NLRI SAFI is 1 octet longAlexis La Goutte1-2/+2
Break when remove proto_tree_add_text (g1307c2255f) Change-Id: Id5512424180b4834c20fa5416499fc939c06d1ea Reviewed-on: https://code.wireshark.org/review/8774 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-06-05BGP: Add EVPN draft-rabadan-l2vpn-evpn-prefix-advertisement supportMatthieu Texier1-5/+70
Bug: 11252 Change-Id: I125e3075125451d2cbeac6cc183977e73040887f Reviewed-on: https://code.wireshark.org/review/8767 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-05-30BGP: remove proto_tree_add_text callAlexis La Goutte1-11/+24
Part7 Fix last proto_tree_add_text (use expert info) Change-Id: I9c4c053e5fc94f57608c7ee8355e6e16f8af6bd1 Reviewed-on: https://code.wireshark.org/review/8697 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-05-30BGP: remove proto_tree_add_text callAlexis La Goutte1-1/+8
Part6 Update SAFNUM_TUNNEL Change-Id: I4a3486f3fd12a624caa11e4ab424b26081b5b9ab Reviewed-on: https://code.wireshark.org/review/8696 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-05-30BGP: remove proto_tree_add_text callAlexis La Goutte1-100/+20
Part 5 Update SAFNUM_LAB_VPNUNIMULC/SAFNUM_LAB_VPNMULCAST/SAFNUM_LAB_VPNUNIMULC Simplify code but no tested on real pcap Change-Id: I02fc1bc8d4b406f34918130d1eb24d514c24385c Reviewed-on: https://code.wireshark.org/review/8695 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-05-30BGP: Remove proto_tree_add_text callAlexis La Goutte1-9/+28
Part 4 Update BGP Type TUNNEL_ENCAPS_ATTR Change-Id: Ib166cf42e4eee3513f4c2f64e18eb5de2ed4acf2 Reviewed-on: https://code.wireshark.org/review/8694 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-05-30BGP: Remove proto_tree_add_text callAlexis La Goutte1-40/+64
Part 3 Update BGP Type MP REACH NLRI, MP UNREACH NLRI and SAFI_SPECIFIC_ATTR Change-Id: I28bc1385cf75b99739946e91d52c4d654ba525d3 Reviewed-on: https://code.wireshark.org/review/8693 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-05-19BGP: Remove proto_tree_add_text callAlexis La Goutte1-83/+36
Part 2 Update VPLS-BGP and BGP-AD Change-Id: I6a311bfc69d9666be6f83e38042745162701aaac Reviewed-on: https://code.wireshark.org/review/8485 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-05-11BGP: Remove proto_tree_add_text callAlexis La Goutte1-25/+36
Part 1 Change-Id: Icbc73690370eba07e77b35d2815346f1d5a44347 Reviewed-on: https://code.wireshark.org/review/8386 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-04-18Convert proto_tree_add_boolean to ↵Michael Mann1-13/+24
proto_tree_add_bitmask_[value|value_with_flags|list] Part 1 of a few Change-Id: I413f23dfa92da5488ca8a7f62ca0738b25004635 Reviewed-on: https://code.wireshark.org/review/8117 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-04-15Replcae deprecated API tvb_length with tvb_reported_length or tvb_capturedAndersBroman1-1/+1
length. Change-Id: Id42f3409a32e202528d350f7afde7376e411fc51 Reviewed-on: https://code.wireshark.org/review/8076 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-03-05[bmp] Support for decoding of BGP Peer DistinguisherEbben Aries1-1/+2
re-utilize decode_bgp_rd() logic from packet-bgp Change-Id: I588a58e0b2f7da5d3c9b86b28abb9c5b29e0dc8f Reviewed-on: https://code.wireshark.org/review/7537 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-02-19[bmp] Adding dissector for BGP Monitoring ProtocolEbben Aries1-0/+2
* Support per draft-ietf-grow-bmp-07 Change-Id: Iadb833157e7832077429c048e28e9814da29e2c6 Reviewed-on: https://code.wireshark.org/review/7192 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-01-19BGP: EVPN - Route Type 4 - "Invalid length of IP Address" - "Expert Info" ↵Alexis La Goutte1-2/+2
shows a false error Wrong offset (14 -> 20) to get IP Address Legnth Issue Reported by Rui Bug: 10873 Change-Id: Ib7aa80ac78028a2c8d548f4030278166be9ed0cc Reviewed-on: https://code.wireshark.org/review/6657 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-01-19BGP: fix field bgp.evpn.nlri.mpls_ls is not of type FT_STRING, FT_STRINGZ, ↵Alexis La Goutte1-1/+1
or FT_STRINGZPAD Change-Id: Ida14611dee9eb01e1eab13a96c15ab3d759ed1cd Reviewed-on: https://code.wireshark.org/review/6656 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-01-08Replace some ep_alloc and ep_alloc0 with its wmem equivalent.Michael Mann1-1/+1
These cases were pretty easy to identify. Also replaced some comments that referenced ep_alloced memory, when it's now in fact wmem_alloced. Change-Id: I07d2f390a9c0b34aa2956880476755d1acf5db0a Reviewed-on: https://code.wireshark.org/review/6392 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-01-07tvb_bytes_to_ep_str -> tvb_bytes_to_strMichael Mann1-1/+1
Change-Id: I79c613cbdd8dc939dd4c29ebc477fb6eefd5bfc4 Reviewed-on: https://code.wireshark.org/review/6371 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-31BGP : Simple typo fix for BGP AttributeEbben Aries1-1/+1
Change-Id: I793eed5c7d63c82e13847c8a6c8fd6def3025b8c Reviewed-on: https://code.wireshark.org/review/6158 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com> Tested-by: Hadriel Kaplan <hadrielk@yahoo.com>
2014-12-28Replace ip6_to_str and ip6_guint8_to_str with address_to_str and tvb_ip_to_str.Michael Mann1-26/+24
Change-Id: I1d258923a7a63539ec8456d3e306bca5016a1e4b Reviewed-on: https://code.wireshark.org/review/6060 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-26Try to fix compilation broken by g3d3f973Pascal Quantin1-3/+3
Change-Id: I26833e9a4f7557b5824effaff16b38d2c4367772 Reviewed-on: https://code.wireshark.org/review/6059 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-12-26Replace ip_to_str with [ep_]address_to_str and tvb_ip_to_str.Michael Mann1-43/+40
Change-Id: I40d0c8253743183aecef252040b7dd6742ae5c71 Reviewed-on: https://code.wireshark.org/review/5934 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-22First batch of unincludes. Last attempt...Martin Mathieson1-1/+0
Change-Id: I3681462aeb98ca62ed3ec5eb226b2553317391a9 Reviewed-on: https://code.wireshark.org/review/5997 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-12-22BGP : Update BGP-LS Attribute + Display NEXT_HOPEbben Aries1-4/+9
From IANA page: http://www.iana.org/assignments/bgp-parameters/bgp-parameters.xhtml Change-Id: Ibc85dccee94aa69306c88b48d680e48fede08f2e Reviewed-on: https://code.wireshark.org/review/5965 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-21Register the ORFEntry IP address as an IPv4 address.Guy Harris1-1/+1
We're adding it with proto_tree_add_ipv4(), so that it's displayed as, and can be tested as, an IPv4 address. That means that the field for it must be of type FT_IPv4, *even though it's calculated from an 8-bit prefix value* - you can't make it an FT_UINT8. Change-Id: I7d668fb2a707cdda4ad228afcbdcaf47ee6cba1b Reviewed-on: https://code.wireshark.org/review/5960 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-5/+2
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>