summaryrefslogtreecommitdiff
path: root/epan/dissectors/packet-bthci_cmd.c
AgeCommit message (Collapse)AuthorFilesLines
2017-04-14Bluetooth: HCI: fix dissection of command Enhanced Setup Synchronous ConnectionPatryk Nowak1-1/+0
Change-Id: I6f66b583f50da841eb67eb1995b637db327be6a9 Reviewed-on: https://code.wireshark.org/review/21088 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-10bthci_cmd: fix this statement may fall through ↵Alexis La Goutte1-0/+1
[-Werror=implicit-fallthrough] found by gcc7 Change-Id: Id18a0879114f11acb1db8dea8d94a1fb845b5e58 Reviewed-on: https://code.wireshark.org/review/20993 Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-05Bluetooth: HCI_CMD: Implement all remaining commandsMichal Labedzki1-10/+112
Commands: Set Connectionless Slave Broadcast Data Read Synchronization Train Parameters Write Synchronization Train Parameters Read Secure Connections Host Support Write Secure Connections Host Support Read Authenticated Payload Timeout Write Authenticated Payload Timeout Read Local OOB Extended Data Read Extended Page Timeout Write Extended Page Timeout Read Extended Inquiry Length Write Extended Inquiry Length Change-Id: If6d7a7b5405c9b9bd708553d56c6bd372b0b293b Reviewed-on: https://code.wireshark.org/review/20891 Petri-Dish: Michael Mann <mmann78@netscape.net> Petri-Dish: Michal Labedzki <michal.labedzki@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-04-05Bluetooth: HCI_CMD: Fix master-slave roleMichal Labedzki1-9/+14
Initiator is always master. Only Role switch event may change it. Improve "Accept Connection Request" to avoid users confusion by using new specification description: 0x00 Become the Master for this connection. The LM will perform the role switch. 0x01 Remain the Slave for this connection. The LM will NOT perform the role switch. Field "Role" is now splitted from: "bthci_cmd.role" and it name is "bthci_cmd.acr.role". Change-Id: I98e3641b9ba9d2fd6c97808e4772beb4265018fd Reviewed-on: https://code.wireshark.org/review/20894 Petri-Dish: Michal Labedzki <michal.labedzki@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@wireshark.org>
2017-04-04Bluetooth: HCI_CMD: Implement a lot of remaining commandsMichal Labedzki1-114/+1134
Commands: Enhanced Setup Synchronous Connection Enhanced Accept Synchronous Connection Request Truncated Page Truncated Page Cancel Set Connectionless Slave Broadcast Set Connectionless Slave Broadcast Receive Start Synchronization Train Receive Synchronization Train Remote OOB Extended Data Request Reply Set MWS Channel Parameters Set External Frame Configuration Set MWS Signaling Set MWS Transport Layer Set MWS Scan Frequency Table Set MWS Pattern Configuration Set Reserved LT_ADDR Delete Reserved LT_ADDR Set Triggered Clock Capture AMP Test Write Secure Connections Test Mode Fix copy-paste issue: Implementation for "Get MWS Transport Layer Configuration" was in: "Set Triggered Clock Capture" Change-Id: I4a2119278b1f3a7e1a3ec87f499d9aa43e8b8a96 Reviewed-on: https://code.wireshark.org/review/20890 Reviewed-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-04Bluetooth: HCI_CMD: Fix wrong field nameMichal Labedzki1-2/+2
Interval -> Window Change-Id: Ic40811a87fd301a07e2a9af60b152feeab395ead Reviewed-on: https://code.wireshark.org/review/20893 Petri-Dish: Michal Labedzki <michal.labedzki@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-04-03Use col_append_str() for fixed stringsStig Bjørlykke1-1/+1
Change from col_append_fstr() to col_append_str() when appending strings without formatting. Change-Id: I8975704c246f2b9a1301ed5f96273aa9d61c6f44 Reviewed-on: https://code.wireshark.org/review/20857 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-03-13Bluetooth: "dublicates" -> "duplicates"Jakub Pawlowski1-5/+5
Change-Id: Ie52c6ef60c911d1e119c5b69de6f64a88b3433f3 Reviewed-on: https://code.wireshark.org/review/20534 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michal Labedzki <michal.tomasz.labedzki@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-03-06bluetooth: fix this statement may fall through ↵Alexis La Goutte1-1/+1
[-Werror=implicit-fallthrough=] found by gcc7 Change-Id: I4d8e6f32b08991f49ee22b320f02c1f65e22b6a0 Reviewed-on: https://code.wireshark.org/review/20400 Reviewed-by: Michal Labedzki <michal.tomasz.labedzki@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-03-04Bluetooth: HCI: A few minor improvementsMichal Labedzki1-1/+1
1. According to ESR05 there is no event called "Bluetooth Logo Testing". 2. According to ESR09 error code 0x23 is also "LL Procedure Collision" 3. Add some HCI status for event for HCI Summary bthci_evt is now up-to-date with Bluetooth Core 4 + CSA4 + CSS6 and ERS09 - nothing to implementing... Change-Id: Ief9e2de61be91942ab2211de6bc44a8f15d12426 Reviewed-on: https://code.wireshark.org/review/20355 Petri-Dish: Michal Labedzki <michal.tomasz.labedzki@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2017-02-07Add dissection of Bluetooth 5.0 AE related HCI commandsAllan Møller Madsen1-33/+354
Added the following batch of HCI commands: LE Read Maximum Advertising Data Length LE Read Number of Supported Advertising Sets LE Remove Advertising Set LE Set Periodic Advertising Data LE Set Periodic Advertising Enable LE Set Extended Scan Parameters LE Set Extended Scan Enable LE Extended Create Connection Corrected min/max interval field sizes of LE Set Extended Advertising Parameters command and updated LE Set Extended Advertising Enable command to use subtree for each set. Change-Id: Id9c08189a76a0a4adc89b669b50d832f68a929aa Signed-off-by: Allan Møller Madsen <almomadk@gmail.com> Reviewed-on: https://code.wireshark.org/review/19958 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-07Bluetooth: EIR/AD: Add support for LE Features and Channel MapMichal Labedzki1-4/+213
Based on CSS7 specification. Change-Id: Ibf00e3add7fcb1a2b3a22574bb63b0fddaf4adcb Reviewed-on: https://code.wireshark.org/review/19972 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-02-01Bluetooth 5.0, HCI command/event PHY update dissectionAllan Møller Madsen1-2/+188
Dissection of all new HCI command/events related with Bluetooh 5.0 feature 'PHY update - LE 2M and LE Coded' Change-Id: I212cb368d3295ba36eb0ca34329df566cae1611b Signed-off-by: Allan Møller Madsen <almomadk@gmail.com> Reviewed-on: https://code.wireshark.org/review/19849 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.tomasz.labedzki@gmail.com>
2016-12-23bthci_cmd: Fix Dead Store (Dead assignement/Dead increment) Warning found by ↵Alexis La Goutte1-1/+1
Clang Change-Id: I84472632e715a6f13e2fa5b58ae95f9dc9d16776 Reviewed-on: https://code.wireshark.org/review/19399 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-18Bluetooth: BTLE: Add new commands parsingJakub Pawlowski1-0/+89
Add "LE Set Extended Advertising Data", "LE Set Extended Scan Response Data", and "LE Set Extended Advertising Enable" command parser. Change-Id: I3027dc9c213c15f503fa5495829726db3a207300 Reviewed-on: https://code.wireshark.org/review/19251 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-12-16Remove proto_item_append_text calls in favor of BASE_UNIT_STRING.Michael Mann1-4/+2
Many proto_item_append_text calls were just adding a unit string to a field. There's a better way to do that now. Change-Id: Id18d5ac1ea4d8ecdc4cbe7ebaec07fbd2eab6e78 Reviewed-on: https://code.wireshark.org/review/19289 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-12-13Bluetooth: BTLE: Add new commands parsingJakub Pawlowski1-0/+97
Add "LE Set Extended Advertising Parameters" and "LE Set Extended Advertising Parameters" commands parsing. Change-Id: Ibcc9f145694e54710da3a11ade237f7132674366 Reviewed-on: https://code.wireshark.org/review/19234 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-12-13Bluetooth: BTLE: Add BT5.0 command and event name parsingJakub Pawlowski1-1/+44
Change-Id: I830551959965896451ddc08f3e843b61f22eed67 Reviewed-on: https://code.wireshark.org/review/19233 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-11-04Bluetooth: HCI: Add missing Core4's cmd/evt identifiesMichal Labedzki1-4/+27
Add a lof of Command Opcodes. Implement trivial Event: "Inquiry Response Notification" and "Get MWS Transport Layer Configuration" Change-Id: I4ca13878e2f972caae4320e9c0149dc3d75c45a5 Reviewed-on: https://code.wireshark.org/review/18668 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2016-11-04Bluetooth: HCI: LE: Implement missing Meta EventsMichal Labedzki1-0/+2
1. LE Remote Connection Parameter Request 2. LE Data Length Change 3. LE Read Local P-256 Public Key Complete 4. LE Generate DHKey Complete 5. LE Enhanced Connection Complete (implies more meta-info present) Change-Id: I4aac5b66808cd15cc5b6825429b2bff848aa88b4 Reviewed-on: https://code.wireshark.org/review/18665 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2016-11-03packet-bthci_cmd.c: Fix typos found by lintian.Michael Mann1-2/+2
Change-Id: I7fd66fadd1cc42951745710ef06613ef098c572d Reviewed-on: https://code.wireshark.org/review/18641 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-28bthci_cmd: fix fix spelling typo found by lintianAlexis La Goutte1-2/+2
Change-Id: Ic7fd85db374df24358e53be66cd2432dca6a23d2 Reviewed-on: https://code.wireshark.org/review/18541 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2016-10-26bthci_cmd: fix spelling typo found by lintianAlexis La Goutte1-8/+8
Change-Id: I6ebc828eb7eafd3ca41275a9b0b9b45a0994a7d3 Reviewed-on: https://code.wireshark.org/review/18493 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-08-31Don't do any Decode As stuff for dissector tables not used with Decode As.Guy Harris1-3/+3
Have all dissector tables have a "supports Decode As" flag, which defaults to FALSE, and which is set to TRUE if a register_decode_as() refers to it. When adding a dissector to a dissector table with a given key, only add it for Decode As if the dissector table supports it. For non-FT_STRING dissector tables, always check for multiple entries for the same protocol with different dissectors, and report an error if we found them. This means there's no need for the creator of a dissector table to specify whether duplicates of that sort should be allowed - we always do the check when registering something for "Decode As" (in a non-FT_STRING dissector table), and just don't bother registering anything for "Decode As" if the dissector table doesn't support "Decode As", so there's no check done for those dissector tables. Change-Id: I4a1fdea3bddc2af27a65cfbca23edc99b26c0eed Reviewed-on: https://code.wireshark.org/review/17402 Petri-Dish: Guy Harris <guy@alum.mit.edu> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-08-11Enhance Bluetooth LE commands parsingPiotr Pawłowski1-6/+171
This patch adds parsing to some missing LE commands Change-Id: Ia22197a7855505e96021536a333b401a45480145 Reviewed-on: https://code.wireshark.org/review/16995 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-07-21Constify a few value_strings which were generated at run-timeBalint Reczey1-287/+291
Change-Id: Idc479a89a34fd21b743faee07020be284f828e2c Reviewed-on: https://code.wireshark.org/review/16298 Petri-Dish: Balint Reczey <balint@balintreczey.hu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Balint Reczey <balint@balintreczey.hu>
2016-06-10Qt/Bluetooth: Add Device dialogMichal Labedzki1-6/+37
Device dialog appears when user double clicks on device in Devices dialog (Bluetooth->Devices). It provides summary of device, like BD_ADDR, name, timeouts, etc. Base on information from HCI layer, so this feature is more interesting for local devices (capturing on its side). Each field has changes counter, what mean that value at specified field changes in time, for example: user change device name 3 times. Please note that initial change is not counted. It means that you can see fielkd without any value then change occur and counter is not increased. It will be increased next time. Reason for that is in most cases field value is unknown at start. Change-Id: Ife0a6bd454eac00a28f8eb2906e1b395695b0307 Reviewed-on: https://code.wireshark.org/review/15793 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
2016-05-21Bluetooth: BTLE: Add 4.2 LE CONTROLLER COMMANDSJakub Pawlowski1-0/+16
Change-Id: I5b13291beb0c04e725edb2fe172c39e09cbbefe3 Reviewed-on: https://code.wireshark.org/review/15503 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2016-03-28Fix more -Wused-but-marked-unused warnings/errors.Joerg Mayer1-4/+4
Change-Id: Ieb3e70a23c1a55b7ba60b1b32f159341adfe65b7 Reviewed-on: https://code.wireshark.org/review/14682 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-03-17Associate dissector tables and heuristic subdissector lists with a protocol.Michael Mann1-3/+3
This will make it easier to determine protocol dependencies. Some LLC OUI dissector tables didn't have an associated protocol, so they were left without one (-1 used) Change-Id: I6339f16476510ef3f393d6fb5d8946419bfb4b7d Reviewed-on: https://code.wireshark.org/review/14446 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-02-06Bluetooth: HCI: Vendor: Add expert info if not all is dissectedMichal Labedzki1-2/+8
If vendor dissector does not decode all bytes - it seems to be unexpected parameter. Also move vendor dissection tree under root as it is done for HCI CMD. >>> CID 1247678: Error handling issues (CHECKED_RETURN) >>> No check of the return value of "dissector_try_uint_new(hci_vendor_table, hci_vendor_data->manufacturer, tvb, pinfo, tree, 1, bluetooth_data)". >>> CID 1247679: Error handling issues (CHECKED_RETURN) >>> No check of the return value of "dissector_try_uint_new(hci_vendor_table, hci_vendor_data->manufacturer, tvb, pinfo, main_tree, 1, bluetooth_data)". Change-Id: Icdb8c1f166d5bc33cfc79c62d384ae416dfbf0cf Reviewed-on: https://code.wireshark.org/review/13737 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2016-02-05Fix some Coverity issueMichal Labedzki1-8/+4
>>> CID 1349726: Incorrect expression (COPY_PASTE_ERROR) >>> "tvb_reported_length_remaining" in "tvb_reported_length_remaining(tvb, offset)" looks like a copy-paste error. >>> CID 1349727: Incorrect expression (COPY_PASTE_ERROR) >>> "tree" in "dissector_try_uint_new(bluetooth_eir_ad_manufacturer_company_id, company_id, new_tvb, pinfo, >>> CID 1349728: (DEADCODE) >>> Execution cannot reach this expression "0" inside statement "(0 && ((__s1_len = __builti...". >>> CID 1306904: Logically dead code (DEADCODE) >>> Execution cannot reach this statement "tap_hci_summary->interface_...". Change-Id: I5f99e37e6d5fac39da7082649caa8373d06bb808 Reviewed-on: https://code.wireshark.org/review/13739 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-25Move the proto data stuff out of frame_data.[ch].Guy Harris1-0/+2
It's not tied to the frame_data structure any more, so it belongs by itself. Clean up some #includes while we're at it; in particular, frame_data.h doesn't use anything related to tvbuffs, so don't have it gratuitiously include tvbuff.h. Change-Id: Ic32922d4a3840bac47007c5d4c546b8842245e0c Reviewed-on: https://code.wireshark.org/review/13518 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-24Add the packet number to the packet_info structure, and use it.Guy Harris1-4/+4
That removes most of the uses of the frame number field in the frame_data structure. Change-Id: Ie22e4533e87f8360d7c0a61ca6ffb796cc233f22 Reviewed-on: https://code.wireshark.org/review/13509 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-23Add more fields to packet_info structure and use them.Guy Harris1-3/+3
Add fields for the absolute time stamp (and another field for a presence flag for the absolute time stamp) and the packet encapsulation for the packet. This lets us remove the field for the packet encapsulation in the frame_data structure; do so. Change-Id: Ifb910a9a192414e2a53086f3f7b97f39ed36aa39 Reviewed-on: https://code.wireshark.org/review/13499 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-20Bluetooth: GATT: Add support for TDSMichal Labedzki1-6/+0
TDS is one of the newest profiles announced by Bluetooth SIG last time. Also start adding expert info about usage of characteristic. In this case mandatory properties are Write or Indicate, so warn in other cases. Change-Id: I0474c1986ddb16c4bcd03aa9160a07b0cacc76c6 Reviewed-on: https://code.wireshark.org/review/13391 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2016-01-20Bluetooth: EIR/AD: Add TDS item supportMichal Labedzki1-10/+158
Also add possibility to use TDS Organization ID dissector table to write custom plugin to dissect TDS data. New dissector table: btcommon.eir_ad.tds_organization_id Change-Id: Idcb5702b6393aeedf1f36bd43b566a5b425ea4eb Reviewed-on: https://code.wireshark.org/review/13388 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2016-01-20Bluetooth: Add dissector table for EIR/AD Manufacturer contentMichal Labedzki1-14/+86
Now it is possible to DecodeAs manufacturer specific content of EIR or AD, so you are able to write custom plugin to dissect it. New dissector table: btcommon.eir_ad.manufacturer_company_id Change-Id: Iac458cd51f7b9bab51ccf7a4411984fb269a86ef Reviewed-on: https://code.wireshark.org/review/13389 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2016-01-18Bluetooth: EIR/AD: Add missing IPS itemMichal Labedzki1-5/+209
Change-Id: I8cfb0b375d4585bbeb890e79c1a41303e0277065 Reviewed-on: https://code.wireshark.org/review/13387 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
2016-01-18Bluetooth: Update Assign numbers (5th December 2015)Michal Labedzki1-1/+18
Add TDS and OTS/OTP UUID, OTS PSM (I cannot find it, but it seems to be linear), update CompanyIds and add three EIR/AD codes: URI, Indoor Positioning and Transport Discovery Data. Implementation of new "numbers" will be done later. Change-Id: I8ad4d9c1d55c1824d87e88303c28e67dd445ec98 Reviewed-on: https://code.wireshark.org/review/13386 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-09new_register_dissector -> register_dissector for dissector directory.Michael Mann1-5/+5
Change-Id: Ie39ef054a4a942687bd079f3a4d8c2cc55d5f22c Reviewed-on: https://code.wireshark.org/review/12485 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-20Bluetooth: EIR/AD: Add URI item supportMichal Labedzki1-0/+13
In CSSv6 there is one new item: URI (UTF-8) Change-Id: Iafa7b563aa96a016c7178eceef28edd3a1df5dc4 Reviewed-on: https://code.wireshark.org/review/11980 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-11-20Bluetooth: Add ability to add custom UUID descriptionMichal Labedzki1-57/+16
Some vendors use UUID128 as own services/attributes. Sometimes they use UUID16 for it too. Support both cases. Change-Id: I001692b94fcc2f86eafa81012790e9134b0f2a36 Reviewed-on: https://code.wireshark.org/review/11976 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-11-04Don't allow multiple registrations of a protocol in dissector tables.Michael Mann1-1/+1
The target here is the Decode As dialog where protocols have multiple registrations into a dissector table and that shows up as multiple entries in the Decode As dialog list with the same name so users are unsure which "dissector" they are choosing. The "default" behavior (done in this commit) is to not allow duplicates for a dissector table, whether its part of Decode As or not. It's just ENFORCED for Decode As. Bug: 3949 Change-Id: Ibe14fa61aaeca0881f9cc39b78799e314b5e8127 Reviewed-on: https://code.wireshark.org/review/11405 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-10-22Use address functions instead of ADDRESS macros in asn1 and epanGerald Combs1-6/+6
Replace CMP_ADDRESS, COPY_ADDRESS, et al with their lower-case equivalents in the asn1 and epan directories. Change-Id: I4043b0931d4353d60cffbd829e30269eb8d08cf4 Reviewed-on: https://code.wireshark.org/review/11200 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-10-17Bluetooth: Fix expert info for undecoded dataMichal Labedzki1-2/+2
Swap PI_* values avoid crashes (assert...) of expert info. Change-Id: I5f5188c9358a4ac93565fc079a3a0e8ea4b7f965 Reviewed-on: https://code.wireshark.org/review/11019 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-10-05Move utf8_entities.h to wsutilJoão Valverde1-3/+1
Change-Id: I6298b3de5f0a1cb988014ff16082eaf8c2a3c3c0 Reviewed-on: https://code.wireshark.org/review/10786 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-17Qt/Bluetooth: Add HCI Summary dialogueMichal Labedzki1-6/+27
HCI Summary dialogue collect HCI Opcodes, HCI Events, Hardware Errors, Statuses and Reasons. Also show occurrence of them. The top level item is group of items (by OGF or types), the second level item is in real command, event, hardware error, status or reason. The third level items are direct link to packet that contains second level item type. Change-Id: I6b6bd02533c4605a2dd2c1f5dfee46f72a0f3fdc Reviewed-on: https://code.wireshark.org/review/9676 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-06-19Bluetooth: Coverity fixesMichal Labedzki1-4/+4
Try to fix Coverity issues in Bluetooth HCI and androiddump. Change-Id: Id2ed35130eb4dbb0698b7a54afccdba56af62bfd Reviewed-on: https://code.wireshark.org/review/8983 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-06-18Bluetooth: ensure to give bluetooth_data structure to dissect_eir_ad_data()Pascal Quantin1-0/+2
Bug: 11285 Change-Id: I1d3a4900fe3daec6f8d7596a9925322063f2c4eb Reviewed-on: https://code.wireshark.org/review/8976 Reviewed-by: Evan Huus <eapache@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
generated by cgit v1.2.1 (git 2.18.0) at 2024-06-26 05:28:41 +0000