summaryrefslogtreecommitdiff
path: root/epan/dissectors/packet-fp_hint.c
AgeCommit message (Collapse)AuthorFilesLines
2017-06-19RLC: Renamed U-RNTI to UE IDDarien Spencer1-1/+1
The 'U-RNTI' field in RLC Info struct is both used in the code and shown in the UI as a generic unique 'UE ID' (not specificly U-RNTI, although sometimes it is) This commit renames the field to fit it's usage. Change-Id: Ib42b8ed5192fe60c9a164d6d225634be53708c66 Reviewed-on: https://code.wireshark.org/review/22225 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2017-06-19[UMTS RLC] Rename proto variableDarien Spencer1-3/+3
To match the recently renamed file name. Change-Id: Id784b955ec96a52a5f380d415094dce81e1774d5 Reviewed-on: https://code.wireshark.org/review/22222 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2017-06-17[UMTS RLC] Renaming dissector files to fit FP/MACDarien Spencer1-1/+1
Currently the UMTS FP & MAC dissector's are named packet-umts_X. This commit renames the UMTS RLC's files to show their relation. Change-Id: I9e37be95f7c7d08278075a49b8abc2b480a13d64 Reviewed-on: https://code.wireshark.org/review/22188 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-04-25fp (hint): fix 'pinfo' was marked unused but was used ↵Alexis La Goutte1-1/+1
[-Werror,-Wused-but-marked-unused] Change-Id: I68a8a79ab27a6469512d4a3f26695a37ad307b11 Reviewed-on: https://code.wireshark.org/review/15092 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-20Manually add protocol dependencies derived from find_dissector.Michael Mann1-2/+2
Started by grepping call_dissector_with_data, call_dissector_only and call_dissector and traced the handles passed into them to a find_dissector within the dissector. Then replaced find_dissector with find_dissector_add_dependency and added the protocol id from the dissector. "data" dissector was not considered to be a dependency. Change-Id: I15d0d77301306587ef8e7af5876e74231816890d Reviewed-on: https://code.wireshark.org/review/14509 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-25Move the proto data stuff out of frame_data.[ch].Guy Harris1-0/+1
It's not tied to the frame_data structure any more, so it belongs by itself. Clean up some #includes while we're at it; in particular, frame_data.h doesn't use anything related to tvbuffs, so don't have it gratuitiously include tvbuff.h. Change-Id: Ic32922d4a3840bac47007c5d4c546b8842245e0c Reviewed-on: https://code.wireshark.org/review/13518 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-14Have various ATM dissectors use the data arguments for pseudo-headers.Guy Harris1-9/+16
Don't use the pseudo-header pointed to by pinfo->pseudo_header; have the argument either point to a struct atm_phdr or to a pwatm_private_data_t. Don't *overwrite* the pseudo-header pointed to by pinfo->pseudo_header if you need to construct an ATM pseudo-header for a dissector; have your own struct atm_phdr structure, fill it in, and pass a pointer to *that* to the sub-dissector. Cleans things up a bit. Change-Id: I4464924def4de41c625002b2d273592bd529e46e Reviewed-on: https://code.wireshark.org/review/13270 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-09new_register_dissector -> register_dissector for dissector directory.Michael Mann1-1/+1
Change-Id: Ie39ef054a4a942687bd079f3a4d8c2cc55d5f22c Reviewed-on: https://code.wireshark.org/review/12485 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-13register_dissector -> new_register_dissectorMichael Mann1-7/+8
Picking off "easy" dissectors that only have one or two exit points at most. Change-Id: I3d5e576b796556ef070bb36d8b55da0b175dcba8 Reviewed-on: https://code.wireshark.org/review/11805 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-12-23Deleting unneccessary #includes from dissectors.Martin Mathieson1-1/+0
Second batch (packet-eth.c -> packet-icmpv6.d). Will look at cleaning up and committing script afterwards. Change-Id: I14295758b81a59115d8c88899f166cc3d5d17594 Reviewed-on: https://code.wireshark.org/review/6013 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-12-21Cleanup use of #includes in non-generated epan/dissector/*.cBill Meier1-3/+0
Specifically: - Set packet.h to be the first wireshark #include after config.h and "system" #includes. packet.h added as an #include in some cases when missing. - Remove some #includes included (directly/indirectly) in packet.h. E.g., glib.h. (Done only for those files including packet.h). - As needed, move "system" #includes to be after config.h and before wireshark #includes. - Rework various #include file specifications for consistency. - Misc. Change-Id: Ifaa1a14b50b69fbad38ea4838a49dfe595c54c95 Reviewed-on: https://code.wireshark.org/review/5923 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-11-07Fix all remaining filter name errors found with checkfiltername.plMichael Mann1-1/+1
This should make it possible to add checkfiltername.pl to the pre-commit script. Change-Id: Icdee7e4ea3381fa1467bb4b5caf0f60c255adec0 Reviewed-on: https://code.wireshark.org/review/5166 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-08-15(Minor) add editor-modelines; Adjust whitespace as needed.Bill Meier1-438/+452
Change-Id: Ife2ec66c7985149d3e31e96e9eade3903d235cc4 Reviewed-on: https://code.wireshark.org/review/3617 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-08-08Eliminate proto_tree_add_text from some dissectors.Michael Mann1-4/+19
Change-Id: I6f1710a093fc548c718defa9b40ab68877ede977 Reviewed-on: https://code.wireshark.org/review/3470 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-15Fix [-Wmissing-prototypes]Jakub Zawadzki1-0/+3
svn path=/trunk/; revision=54135
2013-11-29Avoid including <wiretap/wtap.h> in dissectors.Jakub Zawadzki1-0/+2
svn path=/trunk/; revision=53655
2013-11-23Create the ability to have packet scoped "proto" data. Bug 9470 ↵Michael Mann1-6/+6
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9470) I'm not sold on the name or module the proto_data functions live in, but I believe the function arguments are solid and gives us the most flexibility for the future. And search/replace of a function name is easy enough to do. The big driving force for getting this in sooner rather than later is the saved memory on ethernet packets (and IP packets soon), that used to have file_scope() proto data when all it needed was packet_scope() data (technically packet_info->pool scoped), strictly for Decode As. All dissectors that use p_add_proto_data() only for Decode As functionality have been converted to using packet_scope(). All other dissectors were converted to using file_scope() which was the original scope for "proto" data. svn path=/trunk/; revision=53520
2013-09-15Convert a few more dissectors to wmem APIPascal Quantin1-3/+4
svn path=/trunk/; revision=52052
2013-06-14Remove check_col() and the occasional tree.Michael Mann1-2/+1
svn path=/trunk/; revision=49920
2013-05-12Add the posibillity to use a key for per-packet-data.Anders Broman1-6/+6
svn path=/trunk/; revision=49259
2013-03-19From beroset:Anders Broman1-6/+6
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 svn path=/trunk/; revision=48412
2013-02-19How can I get a new tvbuff that starts at an offset within a givenGuy Harris1-1/+1
tvbuff and runs to the end of the tvbuff? Let me count the ways.... Replace a bunch of different ways of doing that (some incorrect, in that they're not properly handling tvbuffs where the captured and reported lengths are different) with tvb_new_subset_remaining(). svn path=/trunk/; revision=47751
2012-11-10Fix a few Clang dead assignment / increment warningsPascal Quantin1-5/+5
svn path=/trunk/; revision=45990
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-2/+0
svn path=/trunk/; revision=45017
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-05-07packet-umts_fp.h now requires epan/conversation.h.Guy Harris1-0/+1
svn path=/trunk/; revision=42471
2011-10-24Fix encoding arg for various fcn calls:Bill Meier1-4/+4
- proto_tree_add_bits_item - proto_tree_add_bits_ret_val - proto_tree_add_bitmask - tvb_get_bits - tvb_get_bits16 - tvb_get_bits24 - tvb_get_bits32 - tvb_get_bits64 svn path=/trunk/; revision=39539
2011-10-21For proto_tree_add_item(..., proto_xxx, ...)use ENC_NA as the encoding arg.Bill Meier1-1/+1
Also: remove trailing whitespace for a number of files. svn path=/trunk/; revision=39503
2011-10-06Convert 'encoding' parameter of certain proto_tree_add_item() calls in ↵Bill Meier1-1/+1
non-autogenerated epan/dissectors: Specifically: Replace FALSE|0 and TRUE|1 by ENC_BIG_ENDIAN|ENC_LITTLE_ENDIAN as the encoding parameter for proto_tree_add_item() calls which directly reference an item in hf[] which has a type of: FT_UINT8 FT_UINT16 FT_UINT24 FT_UINT32 FT_UINT64 FT_INT8 FT_INT16 FT_INT24 FT_INT32 FT_INT64 FT_FLOAT FT_DOUBLE svn path=/trunk/; revision=39288
2011-10-04Use ENC_NA as encoding for proto_tree_add_item() calls which directly ↵Bill Meier1-3/+3
reference an hf item (in hf[] with types: FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_OID Note: Encoding field set to ENC_NA only if the field was previously TRUE|FALSE|ENC_LITTLE_ENDIAN|ENC_BIG_ENDIAN svn path=/trunk/; revision=39260
2011-06-06From Pascal Quantin:Anders Broman1-0/+1
Add the following enhancements to the UMTS RLC dissector (as specified in 3GPP 25.322 v9.2.0): - UDP framing protocol to allow dissection of RLC PDUs over UDP (like what is done for LTE MAC/RLC/PDCP protocols) - 15 bits Length Indicator support (both with variable and fixed LI size) - Poll type SUFI - enhanced dissection of LIST, Relative List and Bitmap SUFI - dissection of Reset and Reset Ack Control PDU - an option to decode RLC headers only - an option to skip SDU reassembly svn path=/trunk/; revision=37576
2011-04-19From Michael Mann via bug 2794:Stig Bjørlykke1-1/+1
Fixed display filters with obvious typos. svn path=/trunk/; revision=36713
2011-03-23Remove some unncessary assignments to proto_item pointers.Martin Mathieson1-6/+4
Coverity 904 & 905. svn path=/trunk/; revision=36287
2010-12-15From Tobias Witek:Martin Mathieson1-2/+2
Bug 5494 - FP-Hint: Display correct DCH-ID value In FP-Hint, DCH-IDs are stored as a 5-bit value. While a 5-bit value can hold values from 0..31, DCH-IDs in the NBAP, RNSAP and RRC protocols have values from 1..32. This patch adds 1 to the DCH-ID in FP-Hint in order to display the correct DCH-ID value in the protcol tree. svn path=/trunk/; revision=35190
2010-10-08From Tobias Witek (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5283)Martin Mathieson1-6/+13
epan/dissectors/packet-umts_fp.c * Added mac subdissector (MAC) call to HSDSCH TYPE2 frames epan/dissectors/packet-umts_mac.c * Added support for HSDSCH TYPE2 frames by means of not nibble-shifting (4 bits) the SDU if MAC-ehs is used epan/dissectors/packet-rlc.c * Added support for "Use special value of the HE field" (3gpp 25.332-7a0 9.2.2.7) commonly used for Release 7 HSDPA. REMARK: although the specification mandates that the special value is only allowed when activated by higher layers (RRC), it is interpreted unconditionally. We assume this is OK, because a different use in future specifications is very unlikely. epan/dissectors/packet-fp_hint.c * Added decoding of MAC-ehs indicator for HSDSCH frames * Bumped fpi->release from 6 to 7 to enable proper HSDSCH TYPE2 frame decoding in the UTMS MAC parser. In general, this appears not to affect decoding of (conformant) FP frames of pevious releases. svn path=/trunk/; revision=34433
2010-02-01C-ize a C++ comment.Gerald Combs1-1/+1
svn path=/trunk/; revision=31763
2010-02-01From Tobias Witek:Anders Broman1-17/+15
Replace ERF dissector with ATM dissector for protocols 'FP Hint' and 'META' https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4384 svn path=/trunk/; revision=31761
2010-01-18Fix a number of gcc _Wshadow warningsBill Meier1-4/+2
svn path=/trunk/; revision=31557
2009-10-09hf[]: Use NULL for "blurb" instead of dup or empty text string;Bill Meier1-19/+17
#include <stdio.h> & <stdlib.h> not needed. svn path=/trunk/; revision=30430
2009-10-09From Tobias Witek:Anders Broman1-0/+586
New protocols: UMTS RLC (ETSI TS 125 322), UMTS MAC (ETSI TS 125 321). This does not currently compile cleanly but checking it in to be worked on. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3495 svn path=/trunk/; revision=30414
generated by cgit v1.2.1 (git 2.18.0) at 2024-06-22 20:03:35 +0000