summaryrefslogtreecommitdiff
path: root/epan/dissectors/packet-rtps.c
AgeCommit message (Collapse)AuthorFilesLines
2016-10-11RTPS: Fixed octet to next header dissection when submessage is unknownJuanjo Martin1-1/+1
Change-Id: If18d4797a8ace9f93546cac0d2d6f09bf7086cc3 Reviewed-on: https://code.wireshark.org/review/18145 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-09-22RTPS: Added DTLS locator dissectionJuanjo Martin1-0/+9
Change-Id: I168d728a56479bd3eeac4baa2d7708dbc3d09bed Reviewed-on: https://code.wireshark.org/review/17814 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-08-31RTPS: Fixed data holder dissection to match the standardJuanjo Martin1-84/+30
The OMG standard has changed in this new version. I have fixed the implementation. Change-Id: Ie9054ed52c66580c76096af86e0fb8e34a44e9d1 Reviewed-on: https://code.wireshark.org/review/17348 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-08-31Don't do any Decode As stuff for dissector tables not used with Decode As.Guy Harris1-1/+1
Have all dissector tables have a "supports Decode As" flag, which defaults to FALSE, and which is set to TRUE if a register_decode_as() refers to it. When adding a dissector to a dissector table with a given key, only add it for Decode As if the dissector table supports it. For non-FT_STRING dissector tables, always check for multiple entries for the same protocol with different dissectors, and report an error if we found them. This means there's no need for the creator of a dissector table to specify whether duplicates of that sort should be allowed - we always do the check when registering something for "Decode As" (in a non-FT_STRING dissector table), and just don't bother registering anything for "Decode As" if the dissector table doesn't support "Decode As", so there's no check done for those dissector tables. Change-Id: I4a1fdea3bddc2af27a65cfbca23edc99b26c0eed Reviewed-on: https://code.wireshark.org/review/17402 Petri-Dish: Guy Harris <guy@alum.mit.edu> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-08-30RTPS: Allowing duplicates in the rtps.type_name tableJuanjo Martin1-1/+1
Change-Id: Ie7a35b0bb3275a0895fad646bf9a81406eadf37c Reviewed-on: https://code.wireshark.org/review/17393 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-08-26RTPS: Added missing parametersJuanjo Martin1-0/+70
Added the dissection of three parameters. Change-Id: I07e7b655ad7fd3462625c2fb565e41593c62f897 Reviewed-on: https://code.wireshark.org/review/17346 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-08-19RTPS: Added locator information to the parameter tree.Juanjo Martin1-4/+25
This makes the user avoid to click twice in order to see the info. Change-Id: Ib983c78634b1309f12ab29d673abc1195088f55c Reviewed-on: https://code.wireshark.org/review/17146 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-08-16RTPS: Added improvement for SHMEM locatorJuanjo Martin1-0/+1
Change-Id: I2d7abf3606aad939901e70f94054a49b1b15a20d Reviewed-on: https://code.wireshark.org/review/17089 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-07-21Add proto_tree_add_checksum.Michael Mann1-2/+2
This is an attempt to standardize display/handling of checksum fields for all dissectors. The main target is for dissectors that do validation, but dissectors that just report the checksum were also included just to make them easier to find in the future. Bug: 10620 Bug: 12058 Ping-Bug: 8859 Change-Id: Ia8abd86e42eaf8ed50de6b173409e914b17993bf Reviewed-on: https://code.wireshark.org/review/16380 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-06-27tvb_get_string_enc + proto_tree_add_item = proto_tree_add_item_ret_stringMichael Mann1-20/+5
Also some other tricks to remove unnecessary tvb_get_string_enc calls. Change-Id: I2f40d9175b6c0bb0b1364b4089bfaa287edf0914 Reviewed-on: https://code.wireshark.org/review/16158 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-06-05RTPS: Fixed the scenario where discovery contains PID_EXTENDEDJuanjo Martin1-15/+28
Before there was a wrong dissection of parameters that wasn't predictable because of the wrong offset. This could lead to anything. Now, it shows an expert warning indicating that the RTPS packet doesn't contain all the bytes specified by the parameter but it shows properly the parameterId and the length. In order to parse properly the whole PID_EXTENDED parameter we'd need to handle fragments. That is not the purpose of this commit. Change-Id: I0f3f0f1d309d43a530047f510169fb07983a9fb6 Reviewed-on: https://code.wireshark.org/review/15698 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-05-31RTPS: Updated name of CRC fieldJuanjo Martin1-1/+1
The name specified "no header". This is false. It contains the header. Change-Id: I921b7c23d64f43551830e840066231031432dc7c Reviewed-on: https://code.wireshark.org/review/15646 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-05-31RTPS: Added support for new featuresJuanjo Martin1-165/+1048
Added partial support for Secure DDS as well as TopicQuery and IP Mobility (RTI features). Fixed also a few bugs: wrong octet sequence offset, fixing "switch" statement that was falling through and shouldn't, fixing endpoint filters and correct dissection of inline_qos. Change-Id: I9d1c048eaaf3914420bdd6be37fb2040a6a47874 Reviewed-on: https://code.wireshark.org/review/15496 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-05-30RTPS: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
Change-Id: I28e2098c72faedcb112db605e004010f0dcd1215 Reviewed-on: https://code.wireshark.org/review/15614 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Juan Jose Martin Carrascosa <juanjo@rti.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-05-27RTPS: Added support to parse the PID_TYPE_OBJECTJuanjo Martin1-2/+639
Bug:12415 Change-Id: I457bda34b089f95525192ed4cdce0d4fe8883fd7 Reviewed-on: https://code.wireshark.org/review/15305 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-05-02RTPS: Added PT PID parameters and infrastructure to dissectJuanjo Martin1-0/+142
Before, the dissector didn't have any code path to dissect the PT discovery parameters. The code path necessary as well as the parameter definitions have been added. Change-Id: I17665a56d033ffbfd16d47fe2e7374111aff9530 Reviewed-on: https://code.wireshark.org/review/14804 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-04-17RTPS: Added an analysis field to the ACKNACK dissectionJuanjo Martin1-37/+57
A lot of people fail when interpreting ACKNACKs. I added a new field that interprets the numeric values and shows a brief sentence with the analysis. Bug: 12312 Change-Id: I89a33f04c52ebd5ca486d2e23bddb7a6646945e7 Reviewed-on: https://code.wireshark.org/review/14724 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-04-08RTPS: Added vendor-specific submessage RTI_CRCJuanjo Martin1-7/+82
Added the submessage and prepared the code paths so it is easy to add more vendor-specific submessages (from any vendor) Change-Id: I47aa35d64839cd04eb35f7f8fdd94ef1324570fb Reviewed-on: https://code.wireshark.org/review/14864 Reviewed-by: Anders Broman <a.broman58@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-03-30RTPS: Fixed ACKNACK mask processingJuanjo Martin1-1/+1
Change-Id: I81a83638c2318ba0d806263dbf692cd19b30ce9b Reviewed-on: https://code.wireshark.org/review/14707 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-03-30RTPS: Now PID_ENTITY_NAME and PID_ROLE_NAME use different filtersJuanjo Martin1-2/+10
Change-Id: I852aa09bff6a37ef03b5f55bdf8933ed181da2d0 Reviewed-on: https://code.wireshark.org/review/14705 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-03-20RTPS: Added new filters rtps.guidPrefix.src and rtps.guidPrefix.dstJuanjo Martin1-37/+45
As well as in the rest of network protocols, in RTPS we have senders and receivers of data. The atomic unit is not the host address (IP) or the host address and port (UDP) but the guidPrefix. The guidPrefix represents a single DomainParticipant, that very likely will be an application. I have added filters to be able to differentiate from source of information and destination of information. Before, the only filter available was rtps.guidPrefix Change-Id: I810d8b043796119c6e381bdbcb6061e0525ea272 Reviewed-on: https://code.wireshark.org/review/14466 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-17Associate dissector tables and heuristic subdissector lists with a protocol.Michael Mann1-1/+1
This will make it easier to determine protocol dependencies. Some LLC OUI dissector tables didn't have an associated protocol, so they were left without one (-1 used) Change-Id: I6339f16476510ef3f393d6fb5d8946419bfb4b7d Reviewed-on: https://code.wireshark.org/review/14446 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-03RTPS: Updated code path to handle multiple vendorsJuanjo Martin1-37/+91
Before, the parameter ids were handled incorrectly. A vendor specific parameter definition was used for all the vendors. This is wrong for ids starting at 0x8000. This commits aims to fix that problem and make easier the addition of new parameters or vendors. Change-Id: I0d40aa8cbfa44d5bb2928075001fe39e6f14abc2 Reviewed-on: https://code.wireshark.org/review/14007 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-16RTPS: Added new locator kinds and upgraded to latest set of idsJuanjo Martin1-10/+63
The standard says that UDPv6 is the index 2. However, the dissector contained the old implementation of RTI DDS (which had SHMEM = 2 and UDPv6 = 5). I have updated the dissector to be compliant with the standard and indirectly be compliant with the new version of RTI DDS which now implements the standard in this aspect. Change-Id: Iaade0e457fda35362c04a7658d62242cf8868127 Reviewed-on: https://code.wireshark.org/review/13922 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-11RTPS: Adding position in the batch to the rtps_dissector_dataJuanjo Martin1-1/+4
Adding this information is useful for custom dissectors so they can add it to the display. When a lot of samples are sent in RTPS in the same batch, it is very helpful to have the index in the display. Change-Id: I0f158eeb9d5e9b4fcf67ef6e72dcfa655b9cc427 Reviewed-on: https://code.wireshark.org/review/13875 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-02-04RTPS: Improve Status Info dissection.Juanjo Martin1-46/+89
Change-Id: Ia645e9a1bb61d9e4bf6a36ccbe83c54e7bfa0dd9 Reviewed-on: https://code.wireshark.org/review/12782 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-02-04RTPS: Added custom type dissection support for RTPS batchesJuanjo Martin1-14/+34
In RTPS, regular samples are serialized with the format <encapsulation, serialized data> and thus, the dissection of the encapsulation was suggested to be done in the custom dissector. However, batches are serializing the encapsulation only once as <encapsulation, sample 1, sample 2>. This makes us need to dissect the encapsulation in the RTPS dissector and providing as (void*) data to the custom dissector. This way we support the regular samples dissection as well as the batches dissection. I have defined rtps_dissector_data in packet-rtps.h and I suggest we include that header file when we want to write a custom dissector. Bug: 12029 Change-Id: I74ed4c31484f9a99ad6c44c6c34cc52be2adb7c8 Reviewed-on: https://code.wireshark.org/review/13413 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-14RTPS: Call dissector for user data using Type NameJuanjo Martin1-25/+54
With this dissector, anyone can write a plugin to dissect their data type and RTPS will call it if the dissector is registered using the Type Name (what is the common thing to do). Also, added a fix in dissect_APP_ACK so now the APP_ACK messages are properly dissected. It had a couple of wrong offsets and was calling dissect_serialized_data instead of directly adding the serialized data (dissecting an encapsulation that is not there). Bug: 11917 Change-Id: Ie1c6880d60e3537a1cbae4840cc6ff6e1a62ca0e Reviewed-on: https://code.wireshark.org/review/12824 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-01-07RTPS: Fixed DATA_BATCH dissection.Juanjo Martin1-5/+6
The DATA_BATCH dissection contained wrong proto_tree arguments in a few calls. Also, changed the size of a tree from -1 to the actual size. Change-Id: I5f34869a6d231a0bd74c815499b627fe329b6eb0 Reviewed-on: https://code.wireshark.org/review/13059 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-28Eliminate more unnecessary casting away of constness.Guy Harris1-3/+3
Change-Id: I3d2d83d60f798703ea3fa16ba2d6e95a00f88469 Reviewed-on: https://code.wireshark.org/review/12885 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-22RTITCP: Added new dissectorJuanjo Martin1-0/+8
This dissector was mostly code-reviewed in a previous change: https://code.wireshark.org/review/#/c/11305 But it had an issue with a pointer using a sequence number (8 Bytes). This change is meant to correct that, as well as a small formatting error I found in the text shown. Change-Id: Ib7e27eb2734c46e970b99161bd04438b5675bde4 Reviewed-on: https://code.wireshark.org/review/12660 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-18RTPS: Added dissection of PID_BUILTIN_ENDPOINT_SETJuanjo Martin1-15/+93
Change-Id: I5ea72998de9bbc3db02a33b53c0bb5a89e597b6d Reviewed-on: https://code.wireshark.org/review/12427 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-17RTPS: Make guidPrefix filterable directly.Juanjo Martin1-40/+49
This patch is to improve the usability of the filtering wrt the guidPrefix. Change-Id: I45367c642a405a6a57811743ef2a0f85d96792ce Reviewed-on: https://code.wireshark.org/review/12700 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-10Revert "Added RTI TCP dissector"Anders Broman1-8/+0
This reverts commit 1788e2c33a631056ae02e6cd8f75bd48696faf35. Change-Id: Ie86aa71f92e02935663b46ca00f38e0b8d8ae411 Reviewed-on: https://code.wireshark.org/review/12494 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-10Added RTI TCP dissectorJuanjo Martin1-0/+8
This dissector shows the information related to the RTI TCP Control messages used to manage the TCP connections, but also dissects the RTPS data that is sent on top of RTI TCP. This only happens with RTI's DDS implementation. Bug: 11640 Change-Id: I89fcb620256aeed7cae5829b70d92c6868d94929 Reviewed-on: https://code.wireshark.org/review/11305 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-05RTPS: Minor improvementsJuanjo Martin1-49/+53
1) Fixed the guidPrefix deserialization (before it was showing counter and it should be instanceId). 2) The PID_PARTICIPANT_GUID was a total mess. Now it looks perfect. 3) Fixed some bounds in the proto_tree creations so instead of selecting the rest of the tvb, now they select what they have to. Did all of this keeping the dissection for version 1 untouched. Change-Id: I93df2a29e292655ceb3f8c1395f31d8e38106dee Reviewed-on: https://code.wireshark.org/review/12406 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-25RTPS: feature to add a preference that enables the dissectionJuanjo Martin1-3/+7
of the RTPS special announcements that RTI sends. They just start by RTPX and are sent to the domain 0 always. Bug: 11765 Change-Id: I00b47f1aa1702bb35aeb8c4686c7012fecc94baa Reviewed-on: https://code.wireshark.org/review/12105 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-23RTPS: fix no previous prototype for 'compare/hash_by_guid' ↵Alexis La Goutte1-2/+2
[-Wmissing-prototypes] Change-Id: I31b36f1be6bf2476d801e891ac1799ce910a0105 Reviewed-on: https://code.wireshark.org/review/12066 Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-11-21RTPS: Added Topic Information feature. This feature shows the TopicJuanjo Martin1-29/+172
Name and the Type Name of the sample by consulting a hash table that relates GUIDs and this information. This information is very useful to any analysis performed to RTPS data. It can be disabled using a checkbox so it doesn't impact performance when capturing (default = disabled). Bug: 11729 Change-Id: Ic9fa3a777dfed3cb46166b8e7c9783a12c161e7d Reviewed-on: https://code.wireshark.org/review/11602 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-11-02RTPS: added new encoding to proto.c and used it in the rtps dissectorJuanjo Martin1-2/+3
RTPS uses NTP encoding with a BASETIME equal to 0. Also, changed "magic" by "Magic" Change-Id: I2512176f2018396edaa6b2a1478facd26118cb13 Reviewed-on: https://code.wireshark.org/review/11184 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-10-25Update URLs for DDS specifications.Guy Harris1-1/+4
Change-Id: I740f6612e5c53bf41427ecef3fa576f622b8997c Reviewed-on: https://code.wireshark.org/review/11267 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-10-20Bugfix missing NULL elements for proto_tree_add_bitmask array values.Michael Mann1-0/+23
Change-Id: Idbe7ee2750233eea3cb7c2bbef2bbb2c629a0183 Reviewed-on: https://code.wireshark.org/review/11160 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-08-31Eliminate proto_tree_add_text from packet-rtps.cMichael Mann1-406/+666
Change-Id: I353b4fcb3091e731a4b2a68e1932a5abc60c6038 Reviewed-on: https://code.wireshark.org/review/10323 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-07-17Remove all preferences related to enabling/disabling heuristic dissectors.Michael Mann1-2/+2
The preferences are still supported for backwards compatibility, but the heuristic_protos file has final say on the "preference" to enable/disable a heuristic dissector. Also add parameter to heur_dissector_add() for the "default" enable/disable of a heuristic dissector. With this parameter, a few more (presumably weak) heuristic dissectors have been "registered" but of course default to being disabled. Change-Id: I51bebb2146ef3fbb8418d4f5c7f2cb2b58003a22 Reviewed-on: https://code.wireshark.org/review/9610 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-07-12Add "user presentable" and "unique string ids" to heuristic table entries.Michael Mann1-2/+2
This allows better presentation of heuristic dissectors to the end user. Change-Id: I2ff3985ab914e83c2989880cc0c7b9904045b3f6 Reviewed-on: https://code.wireshark.org/review/9602 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-04-30Fix some cases where we're shifting a signed 1 left.Guy Harris1-4/+4
Shift 1U instead, to make sure it's unsigned; the result of, for example, the result of shifting a signed value left is undefined if the value times 2^{shift count} doesn't fit in the *signed* type of the shifted value. That means, in particular, that the result of shifting 1 left by {number of bits in an int - 1} is undefined. (In *practice*, it'll probably be -2^32, with the bit you want set, but that's not guaranteed, and GCC 5.1 seems not to like it.) Change-Id: I0d27565c382a04ceda9eec65f45a430ceb74cf53 Reviewed-on: https://code.wireshark.org/review/8255 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-03-05rtps: added magicDario Lombardo1-0/+14
Change-Id: I52861b6893abf36b304ea58a12c7987e0f7bc5ba Reviewed-on: https://code.wireshark.org/review/7512 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-01-30rtps: CleanupBill Meier1-188/+199
- Remove dead initializers; - Localize some variables; - Whitespace. Change-Id: I876dfd88b2c3fe6a8056090f508c868f4a3cf653 Reviewed-on: https://code.wireshark.org/review/6860 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-01-27rtps: Remove various 'if(tree)'Bill Meier1-93/+0
col_...() and expert_...() should not be called under 'if(tree)' Change-Id: I2f1a8345ff18c0174bcd81b37179aa2d5ee74aca Reviewed-on: https://code.wireshark.org/review/6825 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-01-24RTPS: Memset entire bufferEvan Huus1-1/+1
Apparently some compilers do sufficient inlining optimization to notice that there's at least one caller of rtps_util_add_typecode which passes an indent_level of 0. Such compilers are *also* picky enough to complain about memset being called with a length of 0, leading to a warning which we turn into a compile error. I thought about putting in an "if indent_level > 0" but I figure memsetting the entire buffer (length >= 1) is simpler and more efficient in the common case. Change-Id: Ica21ba988eb0c1251e7b4ef2e110336d5ee32837 Reviewed-on: https://code.wireshark.org/review/6766 Reviewed-by: Evan Huus <eapache@gmail.com>
generated by cgit v1.2.1 (git 2.18.0) at 2024-07-11 04:12:10 +0000