summaryrefslogtreecommitdiff
path: root/epan/dissectors/packet-smb.c
AgeCommit message (Collapse)AuthorFilesLines
2005-07-28some more memification of tvb_get_string() no obvious memleaks fixed this ↵Ronnie Sahlberg1-2/+1
time :-( svn path=/trunk/; revision=15131
2005-07-19minor fix to add required alignment for AueryPathInfo level 0x107Ronnie Sahlberg1-1/+8
it decodes "better" but might still be broken since none of the packets I have match any of the "standards" svn path=/trunk/; revision=14952
2005-06-26Get rid of the private "my_match_strval()" routine in many dissectors;Guy Harris1-1/+1
add a "match_strval_idx()" routine that does the same thing, and have "match_strval()" call it. Make those routines, and "val_to_str()", return a "const" pointer. Update dissectors as necessary to squelch compiler warnings produced by that. Use "val_to_str()" rather than using "match_strval()" and then, if the result is null, substituting a specific string. Clean up some other "match_strval()"/"val_to_str()" usages. Add a null pointer check in the NDPS dissector's "attribute_value()" routine, as it's not clear that "global_attribute_name" won't be null at that point. Make some global variables in the AFS4INT dissector local. Make some routines not used outside the module they're in static. Make some tables "static const". Clean up white space. Fix Gerald's address in some files. svn path=/trunk/; revision=14786
2005-06-26packet-smb.c(14406) : warning C4090: 'return' : different 'const' qualifiersUlf Lamping1-2/+2
svn path=/trunk/; revision=14780
2005-06-02add a generated toplevel line between the TCP protocol and the desegmented ↵Ulf Lamping1-2/+6
content, to better understand what's going on while desegmenting. We'll have to add similar mechanisms for other protocols as well... svn path=/trunk/; revision=14527
2005-06-02bugfix (fuzz_tested): t2i can be zero, test at all places before using itUlf Lamping1-8/+8
svn path=/trunk/; revision=14526
2005-05-30don't go into an (almost) endless loop, if si->info_count is -1, which is ↵Ulf Lamping1-0/+6
the default value. Seems to be a general bug worth to thought about, but I don't know the SMB internals and this bugfix should work anyway. Found this by a privately fuzzed capture file (sorry, can't give it away) svn path=/trunk/; revision=14501
2005-05-30fix #215: the field hf_smb_print_spool_file_name used the wrong type, use ↵Ulf Lamping1-1/+1
FT_STRINGZ to add a string svn path=/trunk/; revision=14482
2005-05-14Throw an exception if AndXOffset is less than the current offset. Fixes bugGerald Combs1-0/+45
163. I'm not sure if this fix is entirely correct, but it doesn't appear to have affected any SMB captures here adversely. svn path=/trunk/; revision=14365
2005-05-04Don't try to feed a null pointer to strncmp(). Fixes bug 158.Gerald Combs1-0/+2
Shouldn't the number of fuzz bugs decrease asymptotically at some point? svn path=/trunk/; revision=14306
2005-04-20In all functions that require smb_info data, throw an exception if weGerald Combs1-9/+140
can't fetch it. Fix a few more null pointer dereferences. Fixes bug 79. svn path=/trunk/; revision=14149
2005-04-16Add an extra_info_type field to smb_extra_info_t so that we can makeGerald Combs1-15/+22
sure we're not referencing a fid when we think we're referencing an smb_nt_transact_info_t pointer. (A fuzzed capture I have triggers this behavior). svn path=/trunk/; revision=14107
2005-04-14Add a bunch of tvb_ensure_bytes_exist() calls. Some of these may not beGerald Combs1-4/+26
neccessary -- someone more knowledgeable about the SMB dissector may want to check this. Throw a ReportedBoundsError instead of exiting. svn path=/trunk/; revision=14077
2005-03-29Add a tvb_ensure_bytes_exist().Gerald Combs1-0/+1
svn path=/trunk/; revision=13968
2005-03-06Handle XNS IDP socket numbers.Guy Harris1-0/+2
Handle SMB-over-SPP. svn path=/trunk/; revision=13635
2005-02-09Move the following files from /trunk to /trunk/epan:Lars Roland1-1/+1
asn1.[ch] follow.[ch] ptvcursor.[ch] reassemble.[ch] xmlstub.[ch] fix #include statements accordingly. svn path=/trunk/; revision=13366
2005-02-02From Jon Ringle:Anders Broman1-2/+2
1) Added a setup_frame parameter to conversation_t 2) Used the conversation_t next to maintain a list of conversations with the same src/dest tuple but different setup_frame number. 3) Changed the signature of find_conversation() and conversation_new() to pass in the frame number. 4) Adjusted packet-sdp to select RTP conversation if both m=audio and m=image are present, and T.38 conversation if only m=image is present. I expect that RTP/T.38 dissecting to be better, but I don't have a way to generate T.38 packets. svn path=/trunk/; revision=13243
2004-12-25a lot of warnings removed, most of them about pointer to int casts without ↵Ulf Lamping1-24/+24
using the appropriate GLib macros svn path=/trunk/; revision=12832
2004-12-22Clean up one more instance of 8-byte timestamps in SMB. Have to work onRichard Sharpe1-45/+15
the 4-byte ones soon. svn path=/trunk/; revision=12818
2004-12-22Add a dissection for the GET_NETWORK_FILE_OPEN_INFO and make some stuff thatRichard Sharpe1-39/+84
we do in several places into a subroutine. We need to do it also with the 4-byte time stamps that are dissected all over the place. I had thought that that last unknown in the returned structure might be a count of the number of clients that have the file open, but a simple test suggests that that is not the case. svn path=/trunk/; revision=12812
2004-12-19mark some fields as GENERATED fieldsRonnie Sahlberg1-6/+13
svn path=/trunk/; revision=12771
2004-12-19the mid values in smb are too unreliable for request/response matching since ↵Ronnie Sahlberg1-0/+13
they wrap so quickly. This has the effect that if you have a capture file with a hole in it, sa say when snoop or similar stops capturing packets for a while while writing the data to disk you often end up with a packet just after the hole that is a response packet and which ethereal mistakenly matches with a request/response from before the hole. now, when the first response is seen to a request remove the entry from the unmatched table so that no other response can match the same request. svn path=/trunk/; revision=12770
2004-11-05Move smb.trans2.cmd and smb.nt.function near the top of the hf[] array,Guy Harris1-8/+8
so they show up near the top of the list of fields in the dialog box for adding a field to a filter - those are probably quite likely to be used in filter expressions where you don't happen to remember the name of the field, and those should show up at the top so you don't have to scroll through the entire list of fields to find them. (I suspect most other fields either will rarely be filtered on at all, or would be filtered only mainly with the "Match" or "Prepare" filter items, where you don't need to know the name or even the text of the field.) svn path=/trunk/; revision=12489
2004-10-18From Laurent Constantin: fix a (presumed) cut-and-pasteo.Guy Harris1-1/+1
svn path=/trunk/; revision=12342
2004-09-30Handle continuation replies to transactions better - try to match themGuy Harris1-18/+28
up with the original request, without matching unrelated replies with that request. svn path=/trunk/; revision=12145
2004-09-29Move the tap infrastructure to the epan directory.Guy Harris1-1/+1
svn path=/trunk/; revision=12128
2004-09-27Move prefs.c and prefs.h into the epan subdirectory.Guy Harris1-1/+1
svn path=/trunk/; revision=12115
2004-08-24Fix the InfoQueryEASize infolevel for SetPathInfo and QueryPathInfo SMB'sRonnie Sahlberg1-4/+9
svn path=/trunk/; revision=11821
2004-08-22Add "tvb_get_ntoh64()" and "tvb_get_letoh64()" routines to fetch 64-bitGuy Harris1-51/+16
integers. Make FT_INT64 and FT_UINT64 add numerical values, rather than byte-array values, to the protocol tree, and add routines to add specified 64-bit integer values to the protocol tree. Use those routines in the RSVP dissector. svn path=/trunk/; revision=11796
2004-08-16cast define of TIME_T_MIN and TIME_T_MAX to (time_t), as MSVC seems to have ↵Ulf Lamping1-3/+3
problems with this definition and throws a warning "convert negative constant to unsigned integer" svn path=/trunk/; revision=11753
2004-08-16From Ronnie Sahlberg: update the fs attributes to be more complete andGuy Harris1-15/+120
correctly dissected. svn path=/trunk/; revision=11752
2004-08-12Note that the CIFS spec claims that the service name string in TreeGuy Harris1-0/+5
Connect AndX is always ASCII; we don't assume it is - the spec may very well be wrong. svn path=/trunk/; revision=11726
2004-08-03Move a bunch of stuff that's more Windows-related than SMB-related toGuy Harris1-2295/+39
"packet-windows-common.[ch]". svn path=/trunk/; revision=11592
2004-08-02Move the NTLMv2 blob stuff back into packet-ntlmssp.c - it's moreGuy Harris1-2/+1
NTLMSSP-related than SMB-related, and documents about NTLMSSP talk about it, so it's a little more convenient to keep all that stuff together - and export it through a packet-ntlmssp.h header. svn path=/trunk/; revision=11585
2004-07-23Use "format_text()" on strings to be put into the Info column and theGuy Harris1-48/+71
display representation of items in the protocol tree, so we don't get hosed by non-printable characters. svn path=/trunk/; revision=11489
2004-07-18Move dissectors to epan/dissectors directory.Gilbert Ramirez1-0/+19418
Also move ncp222.py, x11-fields, process-x11-fields.pl, make-reg-dotc, and make-reg-dotc.py. Adjust #include lines in files that include packet-*.h files. svn path=/trunk/; revision=11410
generated by cgit v1.2.1 (git 2.18.0) at 2024-07-04 04:23:09 +0000