summaryrefslogtreecommitdiff
path: root/epan/dissectors/packet-smpp.c
AgeCommit message (Collapse)AuthorFilesLines
2009-08-09Don't guard col_set_str (COL_PROTOCOL) with col_checkKovarththanan Rajaratnam1-2/+1
svn path=/trunk/; revision=29340
2009-07-08From Kovarththanan Rajaratnam:Anders Broman1-4/+1
No letter-shortcuts in Telephony menu. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3678 svn path=/trunk/; revision=29028
2009-06-18From Kovarththanan Rajaratnam via bug 3548:Stig Bjørlykke1-24/+21
(1) Trailing/leading spaces are removed from 'name's/'blurb's (2) Duplicate 'blurb's are replaced with NULL (3) Empty ("") 'blurb's are replaced with NULL (4) BASE_NONE, NULL, 0x0 are used for 'display', 'strings' and 'bitmask' fields for FT_NONE, FT_BYTES, FT_IPv4, FT_IPv6, FT_ABSOLUTE_TIME, FT_RELATIVE_TIME, FT_PROTOCOL, FT_STRING and FT_STRINGZ field types (5) Only allow non-zero value for 'display' if 'bitmask' is non-zero svn path=/trunk/; revision=28770
2009-06-05Have tap listeners specify whether the "packet" routine requiresGuy Harris1-1/+1
a protocol tree; the column values. This includes stats-tree listeners. Have the routines to build the packet list, and to retap packets, honor those requirements. This means that cf_retap_packets() no longer needs an argument to specify whether to construct the column values or not, so get rid of that argument. This also means that there's no need for a tap to have a fake filter to ensure that the protocol tree will be built, so don't set up a fake "frame" filter. While we're at it, clean up some cases where "no filter" was represented as a null string rather than a null pointer. Have a routine to return an indication of the number of tap listeners with filters; use that rather than the global num_tap_filters. Clean up some indentation and some gboolean vs. gint items. svn path=/trunk/; revision=28645
2009-04-22smpp: Fix potential crash(es): Mark hf[] entries with a range_string[] with ↵Bill Meier1-4/+4
BASE_RANGE_STRING in 'display' field; svn path=/trunk/; revision=28124
2009-04-02Fix a typo.Gerald Combs1-1/+1
svn path=/trunk/; revision=27929
2009-04-02The format argument of val_to_str() formats a guint32, not a char *. FixesGerald Combs1-1/+1
bug 3383. svn path=/trunk/; revision=27928
2009-04-01From Abhik Sarkar: SMPP TLV tag value_strings.Bill Meier1-2187/+2255
"I have chosen _not_ to use the value_string array in the header field for the tag because the information appears in too many places - once in the sub-tree and again once in the field which displays the value. Displaying the tag name again in the tag field would make the same information appear three times in four lines." See Bug #3369 [https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3369] From me: Use consistent indentation throughout packet-smpp.c svn path=/trunk/; revision=27922
2009-03-29More size_t casts.Anders Broman1-2/+2
svn path=/trunk/; revision=27887
2009-03-18Removed C++ style comments.Stig Bjørlykke1-2/+2
svn path=/trunk/; revision=27791
2009-03-18improve dissection of optional parameters. In particular, make the tag and ↵Richard van der Hoff1-26/+68
length fields explicit. svn path=/trunk/; revision=27780
2009-02-10Remove an ugly hack:Ulf Lamping1-2/+3
There was an ugly hack while creating the menu, that tried to detect the stat_group a stats_tree belongs to by looking at the name string. That makes it unnecessarily hard to understand how the menu is really created. Fix: Add a new function stats_tree_register_with_group() that takes the stat_group as a parameter. Use this function where a stats_tree doesn't fit into the default "unsorted" group. svn path=/trunk/; revision=27407
2009-01-07From Robert Groenenberg:Jaap Keuter1-2/+0
The SMPP optional parameter 'network_error_code' is decoded incorrectly. This field is present in SMPP (v3.4 and higher) deliver_sm messages containing a delivery notification. This TLV contains 3 bytes of data, which is decoded in two steps, each adjusting the offset in the message. After that the offset is increased *again*, causing the next TLVs to not recognised. Removing the indicated increase in offset fixes the problem. svn path=/trunk/; revision=27177
2008-12-17Fix some typos and spelling (mostly in text strings)Bill Meier1-1/+1
svn path=/trunk/; revision=27037
2008-12-17Fix typos and spelling (mostly in text strings) Bill Meier1-1/+1
svn path=/trunk/; revision=27028
2008-09-30Minor proto_reg_handoff cleanup: use find_dissector when appropriate.Bill Meier1-1/+1
svn path=/trunk/; revision=26308
2008-07-22From Abhik Sarkar via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2707Jeff Morriss1-11/+567
The SMPP dissector currently supports only version 3.4. The latest version of the protocol is version 5.0 and it has been around for a while. However, the usage of this version of the protocol is only now picking up. This patch adds basic support for SMPP 5.0. By basic I mean: - New Operations and Responses. - New TLVs. - New Error codes. - Any changes to earlier values. svn path=/trunk/; revision=25787
2008-07-11Change the stats tree API to use signed chars instead of guint8s for all itsJeff Morriss1-2/+3
strings; this should fix a number of signed/unsigned char warnings. Reindent a bunch, too. svn path=/trunk/; revision=25716
2008-04-13Fix for bug 1603:Jaap Keuter1-11/+19
SMPP validity period as relative time interpretation corrected. svn path=/trunk/; revision=25001
2008-03-17From Abhik Sarkar:Jaap Keuter1-6/+12
The attached patch changes the handling of the parameters in question to octet string instead of string svn path=/trunk/; revision=24662
2008-01-10Fix http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2111 : After ↵Jeff Morriss1-19/+21
verifying that there's enough TVB for the smallest possible message, also verify that the length parameter in the message is at least that big. svn path=/trunk/; revision=24063
2007-12-21From Abhik Sarkar:Jaap Keuter1-4/+74
This patch adds initial support for statistics to the SMPP dissector using the Stats Tree API. svn path=/trunk/; revision=23931
2007-09-19Make this dissector finable by name.Martin Mathieson1-1/+4
svn path=/trunk/; revision=22908
2007-08-21When saving off a temporary copy of an address, use SET_ADDRESS instead of ↵Jeff Morriss1-4/+4
COPY_ADDRESS so as to avoid a memory leak (or adding g_free() calls to fix said memory leak). svn path=/trunk/; revision=22568
2007-06-05Fix for bug 1512:Jaap Keuter1-3/+10
Present user with the invalid time string. svn path=/trunk/; revision=22052
2007-06-05Fix for bug 1642:Jaap Keuter1-0/+7
Added hf_smpp_sms_signal to hf_array. svn path=/trunk/; revision=22051
2006-10-31change the signature for the get_pdu_len() function pointer passed to ↵Ronnie Sahlberg1-2/+2
tcp_dissect_pdus() to also include a packet_info pointer. there are many reasons why some protocols actually need to be able to access the pinfo structure while determining the pdu size svn path=/trunk/; revision=19751
2006-05-21change a whole bunch of ethereal into wiresharkRonnie Sahlberg1-4/+4
svn path=/trunk/; revision=18196
2006-03-27From Jacques, OlivierAnders Broman1-1/+1
Here is a patch for gsm_map dissector that adds USSD string decoding (mainly used in processUnstructuredSS-Request, UnstructuredSS-Request, UnstructuredSS-Notify). For now, it assumes that it will be GSM 7 bits. It re-use packet-gsm_sms.c "gsm_sms_char_7bit_unpack" and "gsm_sms_char_ascii_decode" functions, as well as packet-smpp.c "smpp_handle_dcs" function. svn path=/trunk/; revision=17739
2006-01-06Bill Meier: More spelling fixesJörg Mayer1-2/+2
svn path=/trunk/; revision=16965
2006-01-05Bill Meier:Jörg Mayer1-4/+4
Spelling fixes. svn path=/trunk/; revision=16956
2005-11-01Use g_print() instead of fprintf() to write messages to the debug console.Olivier Biot1-3/+2
svn path=/trunk/; revision=16373
2005-09-28fix #480: Change defaults for all reassembling settings to ONUlf Lamping1-1/+1
I've changed all settings I could find to TRUE. It might be reasonable to change some protocol settings back to FALSE, if reassembling fails very often. svn path=/trunk/; revision=16048
2005-08-19more sprintf removals,Ronnie Sahlberg1-4/+7
replace some char arrays on the stack to ep_alloc()ed memory svn path=/trunk/; revision=15446
2005-08-11some more tcv_get_stringz() to tvb_get_ephemeral_stringz() conversionsRonnie Sahlberg1-7/+3
svn path=/trunk/; revision=15288
2005-07-01fixed various issues (two serious ones) found by "private" fuzz-testingUlf Lamping1-1/+15
svn path=/trunk/; revision=14830
2005-06-26Get rid of the private "my_match_strval()" routine in many dissectors;Guy Harris1-2/+2
add a "match_strval_idx()" routine that does the same thing, and have "match_strval()" call it. Make those routines, and "val_to_str()", return a "const" pointer. Update dissectors as necessary to squelch compiler warnings produced by that. Use "val_to_str()" rather than using "match_strval()" and then, if the result is null, substituting a specific string. Clean up some other "match_strval()"/"val_to_str()" usages. Add a null pointer check in the NDPS dissector's "attribute_value()" routine, as it's not clear that "global_attribute_name" won't be null at that point. Make some global variables in the AFS4INT dissector local. Make some routines not used outside the module they're in static. Make some tables "static const". Clean up white space. Fix Gerald's address in some files. svn path=/trunk/; revision=14786
2005-06-16Fix Win32 compilation, broken by yesterday's checkin.Gerald Combs1-2/+3
svn path=/trunk/; revision=14664
2005-06-15Catch an infinite loop in smpp_handle_dlist(). Fixes bug 246.Gerald Combs1-0/+2
svn path=/trunk/; revision=14639
2005-06-10just to get things straight: a dissector should *never* do any g_assert() calls!Ulf Lamping1-1/+1
in a simple approach, I've replaced all g_assert() and g_assert_not_reached() calls by their exception throwing counterparts DISSECTOR_ASSERT() and DISSECTOR_ASSERT_NOT_REACHED() this will replace application crash by showing a dissector bug, which is the desired behaviour there were some g_assert calls in the protocol registering functions, which might not be acting as expected now, but to be able to simply search for g_assert in the future I've replaced that calls too one g_assert remained, the one when someone throws an unknown exception "into" packet_frame.c, but IMHO this one should remain. svn path=/trunk/; revision=14608
2005-01-07From Chris Maynard: free mallocated strings when we're done with them. Guy Harris1-20/+20
(There's still the risk of a leak if we throw an exception before we free the string.) Clean up indentation. svn path=/trunk/; revision=12973
2004-09-27Move prefs.c and prefs.h into the epan subdirectory.Guy Harris1-1/+1
svn path=/trunk/; revision=12115
2004-08-21Prevent the word "desegmentation" at the GUI, but use reassembling at that ↵Ulf Lamping1-2/+3
places, as we also use "defragmentation" and "reassembling". Use reassembling as the general term for such actions. I (hopefully) didn't changed any protocol fields or preference file names, but only the GUI labels appearing in the protocol display and the protocol preferences. Also added a note to the protocol preferences (where appropriate), that you have to enable "Allow subdissectors to reassemble TCP streams" at the corresponding protocol settings for TCP reassembling to take effect. If you encounter any mistakes I've made here, please let me know... svn path=/trunk/; revision=11784
2004-07-18Move dissectors to epan/dissectors directory.Gilbert Ramirez1-0/+2765
Also move ncp222.py, x11-fields, process-x11-fields.pl, make-reg-dotc, and make-reg-dotc.py. Adjust #include lines in files that include packet-*.h files. svn path=/trunk/; revision=11410
generated by cgit v1.2.1 (git 2.18.0) at 2024-07-02 16:00:08 +0000