summaryrefslogtreecommitdiff
path: root/epan/dissectors
AgeCommit message (Collapse)AuthorFilesLines
2016-03-28Fix more -Wused-but-marked-unused warnings/errors.Joerg Mayer26-138/+138
Change-Id: Ieb3e70a23c1a55b7ba60b1b32f159341adfe65b7 Reviewed-on: https://code.wireshark.org/review/14682 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-03-28Fix warnings/errors of type -Wused-but-marked-unusedJoerg Mayer1-2/+2
Change-Id: I34c2d9953272822da0745d1b24c64d8466e43b37 Reviewed-on: https://code.wireshark.org/review/14668 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-03-28Fix some warnings/errors of typeJoerg Mayer25-179/+143
git/epan/dissectors/packet-a21.c:478:25: error: 'item' was marked unused but was used [-Werror,-Wused-but-marked-unused] proto_item_append_text(item, "%s", val_to_str_const(event_id, a21_event_vals, "Unknown")); ^ Added manual change id because file-jpeg.c forced the use of commit -n Change-Id: Iffff53d6253758c8454d9583f0a11f317c8390cb Fix warnings/errors of type: git/epan/dissectors/packet-ax25-kiss.c:205:52: error: 'pseudo_header' was marked unused but was used [-Werror,-Wused-but-marked-unused] return capture_ax25( pd, l_offset, len, cpinfo, pseudo_header ); Fix checkhf warnings: Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_address_netswitch Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_address_subswitch Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_poll_reply_trailer Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_rdm_universe Unused entry: epan/dissectors/packet-artnet.c, hf_artnet_tod_data_universe Change-Id: Id1fa12afb97a8e9cd4ed0ea25351c3b2639c930e Reviewed-on: https://code.wireshark.org/review/14667 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-03-28Fix some warnings/errors of typeJoerg Mayer3-3/+3
git/epan/dissectors/packet-a21.c:478:25: error: 'item' was marked unused but was used [-Werror,-Wused-but-marked-unused] proto_item_append_text(item, "%s", val_to_str_const(event_id, a21_event_vals, "Unknown")); ^ Added manual change id because file-jpeg.c forced the use of commit -n Change-Id: Iffff53d6253758c8454d9583f0a11f317c8390cb Reviewed-on: https://code.wireshark.org/review/14666 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-03-28NAS EPS: add a missing breakPascal Quantin1-0/+1
Change-Id: I71a32b831cdb8d7d07e48cabe2c6cd7204968c28 Reviewed-on: https://code.wireshark.org/review/14665 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-03-27NAS EPS: upgrade dissector to v13.5.0Pascal Quantin1-13/+334
Change-Id: I04319c1ca0a6c166904a584f31088460ea35eb89 Reviewed-on: https://code.wireshark.org/review/14655 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-03-27Add dissector table for negotiated WebSocket protocolGregor Jasny3-3/+20
This adds the possibility to filter on the negotiated WebSocket protocol from the upgrade response as well as on a specific TCP port Bug: 12298 Change-Id: I8e0b785cec0b8c71ec558b74ac07c81194268b38 Signed-off-by: Gregor Jasny <gjasny@googlemail.com> Reviewed-on: https://code.wireshark.org/review/14645 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-26Make sure conversation exists (CID-280536)Jaap Keuter1-0/+2
The code sets up a conversation, then proceeds getting it and using it. It must be there, so assert that it is before dereferencing it. Change-Id: I5384b9b773a5f4e86f649612ee4f4929a503c523 Reviewed-on: https://code.wireshark.org/review/14641 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-26Improves MPTCP analysisMatthieu Coudron2-61/+465
Adds options that control depth of MPTCP analysis, notably: - if mptcp_relative_seq is enabled, can display relative MPTCP sequence numbers - if mapping analysis is allowed, can tell in which packets the DSS mappings covering this data was sent - if intersubflow checks are enabled, it can check for retransmissions over other subflows Change-Id: I82b934513c9f16affb60c066a1fbcca234ffc999 Reviewed-on: https://code.wireshark.org/review/12316 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-26bootp: Add support for iSNS (RFC4174) dissectionVictor Dodon1-1/+371
Change-Id: I2d1807e631991d4115ca33d351e85c36272c209b Reviewed-on: https://code.wireshark.org/review/14523 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-26ASTERIX: Add CAT025 dissectionAndrew Hoag1-1/+245
The CAT025 type of ASTERIX messages is "CNS/ATM Ground System Status Report". Change-Id: Icf39d595cef8663357a487b799bf32e738236757 Reviewed-on: https://code.wireshark.org/review/14590 Tested-by: João Valverde <j@v6e.pt> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-26PTP: Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
Change-Id: I277c0e6f0f257dfb84bfb778c221c519204907d4 Reviewed-on: https://code.wireshark.org/review/14643 Reviewed-by: Uli Heilmeier <openid@heilmeier.eu> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-26MySQL: Fix query string in info columnDaniël van Eeden1-1/+1
Change-Id: I2d0aae95c41f527c4a1e0327bf6c3950204458e1 Reviewed-on: https://code.wireshark.org/review/14637 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-26Make sure there's enough data in the header for a FMTP packet.Michael Mann1-2/+7
Bug: 12285 Change-Id: I103dff37b34f922ac5c3071c49b7dfe55b059717 Reviewed-on: https://code.wireshark.org/review/14634 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-03-26IEEE802.11: properly decode bss transition response packetsSven Schnelle1-2/+69
Old code didn't decode response specific fields, so all packets where shown as invalid. Bug: 12294 Change-Id: Id3bca825925ef3c20da1bb98dfb50961989fd585 Reviewed-on: https://code.wireshark.org/review/14529 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-26gvsp: allow for header-only GVSP payload packetMoeller, Thies1-28/+46
if a packet is not successful ( after resend ) the data section has to be skipped GEV 2.0 spec [CR-203st]/[CR-204st] Bug: 12281 Change-Id: I9465000fb3e25f1e00f419cc7ccae29bd32a56b1 Reviewed-on: https://code.wireshark.org/review/14555 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-26Add json.member.keyJakub Zawadzki1-7/+5
Bug: 12287 Change-Id: I9aecf83ef6f166fc30c275d1e50e0268b1b59ad5 Reviewed-on: https://code.wireshark.org/review/14618 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-25QUIC: Add new tag found with version Q30Alexis La Goutte1-0/+13
* CSCT: Signed cert timestamp (RFC6962) of leaf cert Change-Id: I487090830ea8fa1d7597fbd7eef9e801f5e1fb65 Reviewed-on: https://code.wireshark.org/review/14626 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-25packet-nfs: enable nfs4.lock_owner4Benjamin Coddington1-4/+2
Change-Id: I32e718a8ef94b514fd2907651e2f9bd92d8119ef Signed-off-by: Benjamin Coddington <bcodding@redhat.com> Reviewed-on: https://code.wireshark.org/review/14627 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-25openSAFETY: Change verbosity on expert notesRoland Knall1-9/+16
Expert Infos can be a little overwhelming in large traces. This preference will allow any user to enable the PI_NOTE declared expert infos to be shown only when they are really necessary. Fix a bug with SCM UDID validity detection as well Change-Id: I2d197684157f1ea748bfbcc6fa2dfdb348722223 Reviewed-on: https://code.wireshark.org/review/14625 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-03-25Add MQTT over SSL port.Jakub Zawadzki1-1/+5
Change-Id: If44d33e739bc02425aea437e34ea8531b4223691 Reviewed-on: https://code.wireshark.org/review/14617 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-03-25Add new UPI values for GFPEdward Smith1-2/+5
Change-Id: I8cfad1cdbb3843fa65931d8a22beba1b6bdf57c8 Reviewed-on: https://code.wireshark.org/review/14620 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-25Remove .gitignore file in pidl folderJoão Valverde1-1/+0
Otherwise it will end up in the source distribution tarball. Change-Id: Ieeafd5dbaebe3930c3769bfcbce538da5d36b7d3 Reviewed-on: https://code.wireshark.org/review/14624 Reviewed-by: João Valverde <j@v6e.pt>
2016-03-24PTP: Add mm TLV according to SMPTE ST 2059-2Uli Heilmeier1-0/+267
Add organization extension management message TLV according to SMPTE (Society of Motion Picture and Television Engineers) ST 2059-2 to Precision Time Protocol (PTP). Bug: 12264 Change-Id: I487ef2bacbccdb61c813d923830242f9526fd2cf Reviewed-on: https://code.wireshark.org/review/14559 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-03-24Add basic PIDL MakefileJoão Valverde49-3757/+166
Change-Id: I8f4c8e312df73b70f3cacd0df768375b46197ae6 Reviewed-on: https://code.wireshark.org/review/14507 Petri-Dish: João Valverde <j@v6e.pt> Reviewed-by: João Valverde <j@v6e.pt> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-03-24GTPv2: Fix length of Presence Reporting Area Identifier fieldUli Heilmeier1-5/+5
Specs (http://www.etsi.org/deliver/etsi_ts/129200_129299/129274/13.04.00_60/ts_129274v130400p.pdf , page 281 ) lists 3 Bytes for field Presence Reporting Area Identifier. Bug: 12284 Change-Id: I404c5133fa0975b5c9a245b8e4b952c7eb4d2818 Reviewed-on: https://code.wireshark.org/review/14608 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-03-24MySQL: Decoding of the header of compressed packetsDaniël van Eeden1-1/+68
If client and server have the flag set then compression starts after the greeting,login,ok. This comments makes it possible to decode packets which use the compressed protocol but don't have an compressed payload. Ping-Bug: 10342 Change-Id: I710f655c86feb9770556d1ffa69edd728e0374c3 Reviewed-on: https://code.wireshark.org/review/14603 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-24Add support in order to dissect the GTPv2 IE "Presence Reporting Area ↵Lucas Simopoulos1-1/+27
Information" Change-Id: Ibe25fd95a5020b1663c096b5e35a04587821d71e Reviewed-on: https://code.wireshark.org/review/14604 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-03-24Remove constant variable (CID-280372)Jaap Keuter1-12/+1
This copied and stripped code has this variable which does not change. Remove this constant variable and the conditional statements related. Change-Id: I0741ef0ef8b8d1cbd52fc521bc6a91ad06c8b597 Reviewed-on: https://code.wireshark.org/review/14594 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-24Detect spurious retransmissions when the full segment is retransmittedMichael Cistera1-3/+3
The TCP dissector failed to recognize spurious retransmissions when the last ack exactly equaled the retransmitted packet's sequence number plus the len. This is standard TCP behavior so this feature was broken in most cases. Bug: 12282 Change-Id: I90196cc79e786f92fd0d7be32816aad1d69d5718 Reviewed-on: https://code.wireshark.org/review/14592 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2016-03-233GPP NAS: upgrade dissector to v13.5.0Pascal Quantin1-6/+6
Change-Id: I454a6a07efe599924edcfd2a5adeeabaf902995b Reviewed-on: https://code.wireshark.org/review/14605 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-03-23Update MySQL protocol URLDaniël van Eeden1-2/+1
Change-Id: Ia50e06f8e9387ccb5e413f9a77fa811f092cb34a Reviewed-on: https://code.wireshark.org/review/14602 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-03-23Fix typo.Guy Harris1-1/+1
Change-Id: Ia7a94a855a2a7fe184232fea73874a607c4141b2 Reviewed-on: https://code.wireshark.org/review/14598 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-03-23Mikrotik has a protocol that they name Ethernet over IP (EoIP) which hasJoerg Mayer3-31/+34
nothing to do with IP protocol 97 called EoIP. Instead it is a GRE encapsulation with Ethertype 0x6400. It sets the GRE version to 1 but doesn't use a sequence number (in violation of RFC2637). Welcome to the real world. Change-Id: I3d916f8fc134ef14bcaf0b946a10f7170a9f6a75 Reviewed-on: https://code.wireshark.org/review/14596 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-03-23MySQL: Fix typo on CAPS_UNUSED #defineAlexis La Goutte1-1/+1
Change-Id: I4b4a5e6ca0b10068075767e6eec95c97d32034a1 Reviewed-on: https://code.wireshark.org/review/14561 Reviewed-by: Daniël van Eeden <wireshark@myname.nl> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-23Remove some dead code in copied code (CID-280297)Jaap Keuter1-28/+1
The copied function retained features from its parent, which cannot be reached. Might as well remove them and replace with proper assert. Change-Id: I63838d6011420d6c4473b127da52e7f304376172 Reviewed-on: https://code.wireshark.org/review/14531 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-23Fix whitespace.Guy Harris1-4/+4
Change-Id: I9ec492c90e22813f6336130a875b9bca7179af6a Reviewed-on: https://code.wireshark.org/review/14580 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-03-23Expand the LAT dissection.Guy Harris1-146/+1718
Base it on the DEC specification, not on whatever the Linux DECNET people managed to reverse-engineer. Change-Id: I60586f52e35f9f61e4aed93f315bfaceebe68cce Reviewed-on: https://code.wireshark.org/review/14579 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-03-22ISO 7816: fix filters for Fi and Di fieldsPascal Quantin1-2/+2
They use proto_tree_add_uint_format() function to build an interpreted value, so they should not apply the byte bitmask Change-Id: I29f70f567d41a8a44a34f3f0bc477fbc04b11b29 Reviewed-on: https://code.wireshark.org/review/14553 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-03-21Bugfix "typo" from I9b04837f93Michael Mann4-48/+70
Change-Id: Iafc67ced1af0fbb27545acb0e1569b8b8ccd9451 Reviewed-on: https://code.wireshark.org/review/14544 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-03-20ENIP: Add request/response arrows for related packetsD. Ulis1-2/+2
Change-Id: I0fbaa0569be3aafa85156cea6b7f5220c2d5e118 Reviewed-on: https://code.wireshark.org/review/14542 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-20URL for the document in question.Guy Harris1-0/+1
Change-Id: Id92c484099bdcd71c0ff194abeefda4bab8dcd6e Reviewed-on: https://code.wireshark.org/review/14543 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-03-20Add missing auth switch values to value_stringDaniël van Eeden1-0/+2
Change-Id: Ie602d76dfd2366294f2599f6c4d8634d37c6531c Reviewed-on: https://code.wireshark.org/review/14535 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-20Add CLIENT_DEPRECATE_EOF flagDaniël van Eeden1-0/+8
This is used in MySQL 5.7 https://dev.mysql.com/doc/internals/en/capability-flags.html#flag-CLIENT_DEPRECATE_EOF Change-Id: I8e00c966628233181e7145d8ed80d51f2acd9517 Reviewed-on: https://code.wireshark.org/review/14536 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-20Fix response ok packet with no session tracking info but flag setDaniël van Eeden1-22/+24
Change-Id: I901ebc2128c92ef758b6b400cc8d86488a2115cb Reviewed-on: https://code.wireshark.org/review/14537 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-20Create call_data_dissector() to call data dissector.Michael Mann275-1539/+589
This saves many dissectors the need to find the data dissector and store a handle to it. There were also some that were finding it, but not using it. For others this was the only reason for their handoff function, so it could be eliminated. Change-Id: I5d3f951ee1daa3d30c060d21bd12bbc881a8027b Reviewed-on: https://code.wireshark.org/review/14530 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-20Fix incorrect table being used to store Session TicketsAdam Schwalm2-2/+2
A regression was introduced at f4580ac9edc8b5351 where an additional hash table was introduced to store TLS Session Tickets separately from Session IDs. However, the New Session Ticket dissector was still storing the the Session Ticket in the ID table, causing lookups to fail. Change-Id: Iff49202f50afb8cb6ef62c774f6155682b8e48a6 Reviewed-on: https://code.wireshark.org/review/14499 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-20RTPS: Added new filters rtps.guidPrefix.src and rtps.guidPrefix.dstJuanjo Martin1-37/+45
As well as in the rest of network protocols, in RTPS we have senders and receivers of data. The atomic unit is not the host address (IP) or the host address and port (UDP) but the guidPrefix. The guidPrefix represents a single DomainParticipant, that very likely will be an application. I have added filters to be able to differentiate from source of information and destination of information. Before, the only filter available was rtps.guidPrefix Change-Id: I810d8b043796119c6e381bdbcb6061e0525ea272 Reviewed-on: https://code.wireshark.org/review/14466 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-03-20PKTC must be stricter with its Kerberos application choices.Michael Mann1-2/+19
The PKTC dissector calls the Kerberos dissector assuming certain application values. Because different application values can have different "private" data, corruption can occur. Ensure the Kerberos application values match the preceding comments by checking the ber identifier before calling the Kerberos dissector. Bug: 12206 Change-Id: I9b04837f93a56681cae3816278315cf01da17544 Reviewed-on: https://code.wireshark.org/review/14520 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-03-20Manually add protocol dependencies derived from find_dissector.Michael Mann353-817/+843
Started by grepping call_dissector_with_data, call_dissector_only and call_dissector and traced the handles passed into them to a find_dissector within the dissector. Then replaced find_dissector with find_dissector_add_dependency and added the protocol id from the dissector. "data" dissector was not considered to be a dependency. Change-Id: I15d0d77301306587ef8e7af5876e74231816890d Reviewed-on: https://code.wireshark.org/review/14509 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.1 (git 2.18.0) at 2024-07-13 13:59:40 +0000