summaryrefslogtreecommitdiff
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2016-12-02Prefs: Use g_utf8_strlen instead of strlen.Gerald Combs1-1/+1
Change-Id: I99e2906b3c31f4aebcda44f4433f0fdd457ced3b Reviewed-on: https://code.wireshark.org/review/19008 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-12-01ssh: add DSA host key dissectionРоман Донченко1-0/+29
Change-Id: Ib1e2b4e57832e94b94d34102c0079f820b18f350 Reviewed-on: https://code.wireshark.org/review/19000 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-12-01Check preference titles and descriptions.Gerald Combs14-32/+63
When registering preferences, make sure our titles and descriptions are valid UTF-8. Make sure our titles are short and only contain printable characters. Fix problematic titles and descriptions. Change-Id: I20d3f93438f2b3c30266f934297feb79897f2ee5 Reviewed-on: https://code.wireshark.org/review/18998 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-30ssl,dtls: add expert info for overly large record lengthsPeter Wu3-3/+19
All TLS and DTLS RFCs (and SSLv3) limit the record length to 2^14, so add expert info if this is exceeded. Spotted in the wild via https://ask.wireshark.org/questions/57641/tls12-record-length-gt-16k-valid Tested with a synthetic pcap having length 2^14+1 using Python: from scapy.all import IP, TCP, UDP, wrpcap len_plus_frag = b'\x40\x01' + 0x4001 * b'\0' wrpcap('bad-record-length.pcap', [ IP()/TCP(sport=2000, dport=443)/(b'\x17\x03\x03' + len_plus_frag), IP()/UDP(sport=2000, dport=853)/(b'\x17\xfe\xfd' + 8*b'\0' + len_plus_frag) ]) Change-Id: I5eac48775333d8d222e013a24a6d06da79892b77 Reviewed-on: https://code.wireshark.org/review/18959 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-11-30sip: register with Websocket dissector (RFC 7118)Peter Wu1-0/+1
The subprotocol is also listed in the IANA registry at https://www.iana.org/assignments/websocket/websocket.xhtml#subprotocol-name Tested with the pcap from the linked bug. Bug: 11420 Change-Id: I4ba8e6c55889f72f5aca37c4ae759e2cd20a22b7 Reviewed-on: https://code.wireshark.org/review/18989 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-11-293GPP NAS: shorten some value_string to avoid truncation during displayPascal Quantin1-5/+5
Change-Id: I50f9bbec5405c17a59c5eaac9833929737b8c145 Reviewed-on: https://code.wireshark.org/review/18984 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-11-29Handle FT_CHAR, and report unsupported types as such.Guy Harris1-4/+12
FT_CHAR is straightforward to support. Split the list of "invalid" types into a list of "unsupported" types and a short list of "invalid" types, containing FT_PCRE (which isn't a valid type for a field) and "everything else". Add FT_IEEE_11073_SFLOAT and FT_IEEE_11073_FLOAT to the "unsupported" list. Flag the whole unsupported list as just "not handled yet". Change-Id: I62d2d7eead53377e4e601594a035b4395fdbeead Reviewed-on: https://code.wireshark.org/review/18979 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-11-283GPP NAS: add an expert info when APN encoding exceeds 100 bytesPascal Quantin1-11/+13
As stated in 3GPP 23.003: "the APN has, after encoding as defined in the paragraph below, a maximum length of 100 octets" Change-Id: Iae23117f44ea5b668f6cb23dbd0e726e4e56ce41 Reviewed-on: https://code.wireshark.org/review/18972 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-11-27[Automatic update for 2016-11-27]Gerald Combs2-9/+249
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I3dae07ff98d80f02d1aaf7408e81faf6614d7058 Reviewed-on: https://code.wireshark.org/review/18964 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-11-26GlusterFS: Insert missing FORGET command.Michael Mann2-0/+2
Apparently, it was forgotten ;) Bug: 12614 Change-Id: Id1a2d98e3ea2b381c5fa60faeb342256d4c7d9f8 Reviewed-on: https://code.wireshark.org/review/18955 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-11-26We only need the tvbuff length for EAP messages.Guy Harris1-6/+7
Change-Id: I22a5990e12a151c209288b9e879ae1f88c866904 Reviewed-on: https://code.wireshark.org/review/18956 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-11-25packet-dcm.c: Cleanup memory usage with stringsMichael Mann1-82/+58
wmem_file_scope() was used too many times when wmem_packet_scope() will do. Also, use the wmem string functions to only allocate enough space to handle a string instead of using MAX_BUF_LEN. Change-Id: I3031d3aef34b7105264b17dc83e3b1f4cfb4b3d4 Reviewed-on: https://code.wireshark.org/review/18910 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-25ieee80211: Add Meru (Fortinet) Vendor Specific TLVAlexis La Goutte3-0/+72
Change-Id: Iaa554ac94d248c67c635ac180ea2d1c1e3775b6a Reviewed-on: https://code.wireshark.org/review/18915 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-24dissectors: add PRINTER_INFO_5 decoding for DCE/RPC spoolss dissector.Günther Deschner1-0/+52
Guenther Change-Id: I9eb8be636ebdf81092b7abd8d4749410cc5dcc06 Signed-off-by: Guenther Deschner <gd@samba.org> Reviewed-on: https://code.wireshark.org/review/18932 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-11-24Note that we can't use a child setup routine in g_spawn routines.Guy Harris1-1/+1
They don't work on Windows, and we support Windows, so.... Change-Id: Icdbdfcfd930ae13aba6d8fb018d7e2af55b76fa1 Reviewed-on: https://code.wireshark.org/review/18943 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-11-24Return from snort_start early if dissector not enabled.Martin Mathieson1-8/+6
Change-Id: Idf63210ce33d92ac8619fe3295bd3e6c0bb304a9 Reviewed-on: https://code.wireshark.org/review/18941 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2016-11-23Add missing header file for distcheckMartin Mathieson1-0/+1
Change-Id: I230c8886585f30fae101ac40a1cd5018a2a62e8b Reviewed-on: https://code.wireshark.org/review/18940 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2016-11-23Initial commit of Snort post-dissector.Martin Mathieson5-0/+2685
This dissector allows Snort to process all of the packets passed to Wireshark, and for the alerts to be shown in the protocol tree. It is also possible to set the source of alerts to be packet comments. Change-Id: I6e0a50d3418001cbac2d185639adda2553a40de8 Reviewed-on: https://code.wireshark.org/review/18848 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2016-11-22Add prefs_get_uint_value and prefs_get_range_valueMichael Mann19-65/+55
This allows dissectors to not need to know about the internal preference structure. Change-Id: I1ae67248cd0b0132aefc225ea0a9befaf9afdde2 Reviewed-on: https://code.wireshark.org/review/18864 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-22Improve name resolution preference tooltips.Jaap Keuter3-24/+25
Change the tooltips texts to make them better describe the preference. Bug: 13130 Bug: 13131 Change-Id: Ie753e3703a702bdafed91cf0f41b306347088526 Reviewed-on: https://code.wireshark.org/review/18878 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-22extract common logic of proto_item_set_len/proto_item_set_endDmitry Lazurkin1-18/+17
Change-Id: I55f9303624471d09b446c10939e5c22bf8e21511 Reviewed-on: https://code.wireshark.org/review/18894 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-22ieee802154: support 6top protocol (6P) draft-03Yasuyuki Tanaka2-131/+356
- support draft-ietf-6tisch-6top-protocol-03 - rename variables and constants to reflect the protocol hierarchy - show 6P specific information in the "Protocol" and "Info" column - cleanup Bug: 13136 Change-Id: I83ca8a55d59225e0cce64f3463100b3750a58b8f Reviewed-on: https://code.wireshark.org/review/18824 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-22lua: Allow FT_ETHER protofields to be inserted in TreeItems.Franklin "Snaipe" Mathieu1-0/+10
Change-Id: If1daef88dce166ec92f00a8c6e71bcb220d25e0c Signed-off-by: Franklin "Snaipe" Mathieu <snaipe@diacritic.io> Reviewed-on: https://code.wireshark.org/review/18917 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-22PW-ATM: fix code will never be executed [-Wunreachable-code]Alexis La Goutte1-1/+1
Change-Id: If838db823dd1c7614fcfdfc2774952bf70da3c6e Reviewed-on: https://code.wireshark.org/review/18919 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-22ieee80211: Add 20/40 BSS Coexistence IE Parameters (72)Alexis La Goutte1-0/+81
Bug: 13148 Change-Id: I60bb679b8b8221f5229146ca1120d00ce9e2ec66 Reviewed-on: https://code.wireshark.org/review/18911 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
2016-11-22RLC: always initialize LI length, even when it is malformedPascal Quantin1-2/+4
Bug: 13162 Change-Id: Ie0938611b4c90fd54e7ccda0ee5f3d791078be06 Reviewed-on: https://code.wireshark.org/review/18918 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-11-21bgp: remove dead code (CID 1158699).Dario Lombardo1-2/+0
Change-Id: Ib7f766819bb81858fa0c3a0b49fe39de7123bf6d Reviewed-on: https://code.wireshark.org/review/18908 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-21Kafka: show API versions in root, and don't show bogus size for GZIP messages.Martin Mathieson1-5/+21
Change-Id: Ib8182537a791ed24bcc417594713dd6c206ce0ce Reviewed-on: https://code.wireshark.org/review/18885 Reviewed-by: Dmitry Lazurkin <dilaz03@gmail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2016-11-21packet-dcm.c: Assorted cleanupMichael Mann1-212/+88
1. Use tvb_get_guintXX with encoding parameter rather than have an "is_little_endian" flag 2. Replace proto_tree_add_xxx_format with proto_tree_add_xxx_format_value or proto_tree_add_item 3. Create some value_strings in favor of functions. Change-Id: If4b8e8992662bda768b39ba5f1932272760eef65 Reviewed-on: https://code.wireshark.org/review/18909 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-21NAS EPS: fill info column when receiving a ciphered messagePascal Quantin1-0/+1
Change-Id: I2aaad1e7682025f38d78198c7fef7c759629d762 Reviewed-on: https://code.wireshark.org/review/18912 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-11-21bthci_evt: Fix conflict for hf fieldsAlexis La Goutte1-2/+2
'bthci_evt.pending_response_delta' exists multiple times with NOT compatible types: FT_BOOLEAN and FT_DOUBLE Change-Id: I7665ea0c007ef089c6986c102f2358d08d4628df Reviewed-on: https://code.wireshark.org/review/18889 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2016-11-21Fix -1 lengths in proto_tree_add_item_ret_string_and_length().Etienne Dechamps1-1/+1
Currently, when passing a -1 length to proto_tree_add_item_ret_string_and_length() or proto_tree_add_item_ret_string(), the -1 length will be passed directly to the field info. The calculated length should be used instead. Bug: 13159 Change-Id: I980d18fb9bde3c452e64a8735e62d4830ce53b64 Reviewed-on: https://code.wireshark.org/review/18904 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-11-20QBSS Load IE: Correct 'Available Admission Capabilities' to 'Available ↵Nick Lowe1-1/+1
Admission Capacity' Change-Id: Ic4e6fe7978382854b4f36eebc8372eb3cd8e7551 Signed-off-by: Nick Lowe <nick.lowe@gmail.com> Reviewed-on: https://code.wireshark.org/review/18895 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-20Make something to which we assign a string pointer const.Guy Harris1-1/+1
Change-Id: I4b292f252f0e4290fc8adc1e76aa589108fc597e Reviewed-on: https://code.wireshark.org/review/18905 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-11-20PDCP LTE: add NB-IoT channelsPascal Quantin2-11/+58
Change-Id: I3dfb54bc4614ea033ba89ab1fc8be83ad5025473 Reviewed-on: https://code.wireshark.org/review/18900 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-11-20PDCP LTE: cache LTE RRC dissectors handlesPascal Quantin1-10/+24
Change-Id: I35ac69aaf5ce6c3fe14c5af2182e4e53f2aded9b Reviewed-on: https://code.wireshark.org/review/18899 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-11-20uds: Fix conflict for hf fieldsAlexis La Goutte1-1/+1
'uds.tp.suppress_reply' exists multiple times with NOT compatible types: FT_BOOLEAN and FT_UINT8 Change-Id: I8f6035c79c7b6481dd2915cfcfc99963fef7fc23 Reviewed-on: https://code.wireshark.org/review/18884 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-20hsms: Fix conflict for hf fieldsAlexis La Goutte1-13/+13
'hsms.data.item.value' exists multiple times with NOT compatible types: FT_BOOLEAN and FT_BYTES 'hsms.data.item.value' exists multiple times with NOT compatible types: FT_STRING and FT_BOOLEAN 'hsms.data.item.value' exists multiple times with NOT compatible types: FT_INT64 and FT_STRING 'hsms.data.item.value' exists multiple times with NOT compatible types: FT_INT8 and FT_INT64 'hsms.data.item.value' exists multiple times with NOT compatible types: FT_DOUBLE and FT_INT32 'hsms.data.item.value' exists multiple times with NOT compatible types: FT_UINT64 and FT_FLOAT 'hsms.data.item.value' exists multiple times with NOT compatible types: FT_UINT8 and FT_UINT64 Change-Id: I83697e72ebfa4e164178141d789c4ca2d9d09db0 Reviewed-on: https://code.wireshark.org/review/18887 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Benjamin Parzella <bparzella@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-20uftp4: fix last argument of proto_tree_add_itemAlexis La Goutte1-8/+8
It can be not FALSE Change-Id: I938011296b40013a1dad813c3196e899b1b90347 Reviewed-on: https://code.wireshark.org/review/18883 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-20uftp4: Fix conflict for hf fieldsAlexis La Goutte1-5/+5
'uftp4.announce.publicmcast' exists multiple times with NOT compatible types: FT_IPv6 and FT_IPv4 'uftp4.announce.privatemcast' exists multiple times with NOT compatible types: FT_IPv6 and FT_IPv4 'uftp4.fileinfo.tstamp' exists multiple times with NOT compatible types: FT_ABSOLUTE_TIME and FT_UINT32 Change-Id: I94b235e9ba8ebe8a036620f9537eb674f418f1e5 Reviewed-on: https://code.wireshark.org/review/18882 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-20[Automatic update for 2016-11-20]Gerald Combs3-14/+334
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I037cbaa9226ddf6630ae95865da7f67920592295 Reviewed-on: https://code.wireshark.org/review/18896 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-11-20radiotap: Fix conflict for hf fieldsAlexis La Goutte1-1/+1
'radiotap.present.flags' exists multiple times with NOT compatible types: FT_BOOLEAN and FT_UINT32 Change-Id: Ib53eb43c2103b24bd02bd41fd20030b7e7ae321b Reviewed-on: https://code.wireshark.org/review/18886 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-20VXLAN: Fix conflict for hf fieldsAlexis La Goutte1-1/+1
'vxlan.flags_reserved' exists multiple times with NOT compatible types: FT_UINT8 and FT_BOOLEAN Change-Id: I98d296393796defc5741c41a496432eb8f927be2 Reviewed-on: https://code.wireshark.org/review/18881 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-20DICOM: Fix handling of AT tag elementsUli Heilmeier1-7/+14
A Attribute Identifier List can have more than one AT element. Therefore we have to loop through the elements list. Bug: 13077 Change-Id: I3adaa5ba50a1ad01e7c5bacd05118c65afcf4442 Reviewed-on: https://code.wireshark.org/review/18825 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-20kafka: fix mac build breakage by adding int castMartin Mathieson1-1/+1
Change-Id: Ic57d49f7408f041b60b719a3da4971c499122930 Reviewed-on: https://code.wireshark.org/review/18888 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2016-11-20proto_item_set_end() should set the FT_BYTES value length as well.Guy Harris1-1/+11
Change-Id: I33459aabf059e1dc746e7e5f9d5ca28095e056f4 Reviewed-on: https://code.wireshark.org/review/18880 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-11-20tcp: fix "calculated checksum" tree item for bad checksumsAlex Badea1-1/+1
The Calculated Checksum tree item prints the checksum from the tvb, instead of the computed one (the "should be 0x...." tree item above it _does_ print the computed one). As such, in a packet with bad checksum, the Calculated Checksum is incorrect. Fix the value. This seems to have been introduced in ad6fc87d ("Add proto_tree_add_checksum.") Change-Id: Ia20d5addc40956713a944102e79d25317b969a0e Reviewed-on: https://code.wireshark.org/review/18859 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-19Reassemble: fix premature freeJohn A. Thacker1-13/+17
Fix a memory error found by the buildbot and valgrind in my recent patch Bug: 13100 Change-Id: Ieb21aa25e048f90ce7192546b0ad3d4718ff07df Reviewed-on: https://code.wireshark.org/review/18877 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-19kafka: Update supported api keys to latest specDmitry Lazurkin1-132/+360
Details: - update supported api keys - add api key ApiVersions - change api key names according to documentation - add pcapng files for supported api keys - add new documentation link - add declaration of lz4 message codec Change-Id: I943dc31144890dcd3dd333981a86754668c2bec4 Reviewed-on: https://code.wireshark.org/review/18861 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2016-11-18[GSM A RR] Fix dissection of c1_delta.AndersBroman1-6/+22
Change-Id: I500b3e0abd4368511842ff795b91d1ebbbf46bbc Reviewed-on: https://code.wireshark.org/review/18869 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.1 (git 2.18.0) at 2024-07-04 20:11:19 +0000