summaryrefslogtreecommitdiff
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2011-04-22Use _U_ for unused function parameters instead of assigning a variableStephen Fisher3-21/+7
to itself. Found by clang compiler. svn path=/trunk/; revision=36813
2011-04-22If we're using GNUC, use attribute warn_unused_result to verify that theJeff Morriss1-2/+7
return value of proto_item_add_subtree() is used. (The WARN_IF_UNUSED macro doesn't belong here... But where should it go?) svn path=/trunk/; revision=36812
2011-04-22Don't create subtrees that are not used (and don't create subtrees which mightJeff Morriss1-15/+5
have--if the original code was different--contained only one sub-item). Remove some no-longer-used ett variables. svn path=/trunk/; revision=36810
2011-04-22Don't assume that a proto_item is equivalent to a proto_tree.Jeff Morriss1-3/+4
Use the return value from proto_item_add_subtree(). svn path=/trunk/; revision=36809
2011-04-22Don't create a subtree that is not used.Jeff Morriss1-4/+2
svn path=/trunk/; revision=36808
2011-04-22Use the return value of proto_item_add_subtree()Jeff Morriss1-2/+3
svn path=/trunk/; revision=36807
2011-04-22Don't assume that a proto_item is equivalent to a proto_tree.Jeff Morriss1-27/+26
Use the return value from proto_item_add_subtree(). svn path=/trunk/; revision=36806
2011-04-22Don't create a subtree that is not used.Jeff Morriss1-4/+3
svn path=/trunk/; revision=36805
2011-04-22Use the return value of proto_item_add_subtree()Jeff Morriss1-6/+9
svn path=/trunk/; revision=36804
2011-04-22Enhance BT-UTP dissector:Alexis La Goutte1-59/+76
* Add type (syn, data, reset...) in column info * Split dissect_utp_header(...) function to * dissect_utp_header_v0(...) * dissect_utp_header_v1(...) * dissect_utp_extensions(...) svn path=/trunk/; revision=36803
2011-04-22Cleanup emem_verify_pointer()Jakub Zawadzki1-15/+11
svn path=/trunk/; revision=36800
2011-04-22Add some casts to squelch complaints about alignment; our little slabGuy Harris1-2/+2
allocator should return properly-aligned items. svn path=/trunk/; revision=36799
2011-04-22Remove invalid svn:executable propertyJakub Zawadzki1-0/+0
svn path=/trunk/; revision=36798
2011-04-22We deal with pointer alignment ourselves, so we ensure the casts areGuy Harris1-3/+3
safe. Tell the compiler so. svn path=/trunk/; revision=36796
2011-04-22Either the buf argument to emem_scrub_memory() is properly aligned or itGuy Harris1-3/+3
isn't. If it is, we don't need to worry about alignment, so the XXX comment doesn't belong there; if it isn't, then we should do what the comment says. For now, assume the comment before the XXX comment is correct, and just cast away the alignment warning. svn path=/trunk/; revision=36795
2011-04-22ep_alloc() returns a properly-aligned value for all uses; that's why itGuy Harris1-2/+2
returns void * rather than guint8 *. Don't pointer-convert that information away; otherwise, compilers might whine about safe pointer casts. svn path=/trunk/; revision=36794
2011-04-22Stuff that comes back from ep_alloc() is properly aligned for all uses;Guy Harris1-2/+2
that's why it returns "void *", not "guint8 *". Don't pointer-convert that information away; otherwise, compilers might whine at you about unsafe casts. svn path=/trunk/; revision=36793
2011-04-22Cast away bogus warnings. (I begin to see why C++ has templates here,Guy Harris1-2/+2
complicated though they might be for both users and implementors....) svn path=/trunk/; revision=36792
2011-04-22"guint8 *" means "pointer to array of bytes that may or may not beGuy Harris1-6/+10
properly aligned"; "void *", at least when it's the return value of ep_malloc(), means "pointer to properly-aligned chunk of memory". Use "void *" in get_sdp_data_element() and its callers in that case, to squelch compiler warnings. svn path=/trunk/; revision=36790
2011-04-21Remove unneeded #include <errno>,<math>,<ctype> & "isprint";Bill Meier1-32/+27
Do minoir whitespace & indentation cleanup. svn path=/trunk/; revision=36786
2011-04-21Add #include <ctype.h> before #include "isprint.h";Bill Meier1-187/+188
Remove an unneeded line of code; Do some indentation & whitespace cleanup. svn path=/trunk/; revision=36785
2011-04-21Avoid passing a NULL string pointer to format routines: some libc's (e.g.,Jeff Morriss1-7/+7
Solaris') will seg-fault on that. svn path=/trunk/; revision=36784
2011-04-21#include <errno.h> & #include <math.h> not req'd;Bill Meier1-2/+0
svn path=/trunk/; revision=36783
2011-04-21Remove unneeded #include <ctype.h> and "isprint.h";Bill Meier1-36/+33
Do minor whitespace cleanup. svn path=/trunk/; revision=36782
2011-04-21Remove some unneeded #includes;Bill Meier1-2523/+2519
Correct some typos; Use consistent indentation & do some whitespace cleanup. svn path=/trunk/; revision=36781
2011-04-21Remove some uneeded #includes;Bill Meier1-70/+64
Minor indentation & whitespace cleanup. svn path=/trunk/; revision=36780
2011-04-21From Stefan Metzmacher and Gregor Beck via ↵Jeff Morriss1-5/+34
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5850 : The smallest LDAP PDU is 7 bytes, not 4. svn path=/trunk/; revision=36777
2011-04-21Avoid passing a NULL string pointer to format routines: some libc's (e.g.,Jeff Morriss1-946/+940
Solaris') will core on that. Also clean up indentation and white space. svn path=/trunk/; revision=36775
2011-04-21Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
svn path=/trunk/; revision=36773
2011-04-21Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=36771
2011-04-21Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-2/+2
svn path=/trunk/; revision=36770
2011-04-21Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte2-14/+20
svn path=/trunk/; revision=36769
2011-04-21OupsAlexis La Goutte1-1/+1
Wrong fix in Rev36755 (Miss +2) svn path=/trunk/; revision=36768
2011-04-21Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
svn path=/trunk/; revision=36766
2011-04-21Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
svn path=/trunk/; revision=36765
2011-04-21Fix Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+1
svn path=/trunk/; revision=36764
2011-04-21Remove is_continuation_line variable (Unused for 3 years with add SMTP ↵Alexis La Goutte1-12/+0
Command Pipelining (RFC2920) Rev24989) Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang svn path=/trunk/; revision=36763
2011-04-21Fix Dead Store (Dead nested assignment) Warning found by Clang Alexis La Goutte1-2/+1
svn path=/trunk/; revision=36762
2011-04-21Fix Dead Store (Dead nested assignment) Warning found by Clang Alexis La Goutte1-5/+5
svn path=/trunk/; revision=36761
2011-04-21Fix Dead Store (Dead nested assignment) Warning found by Clang Alexis La Goutte1-1/+1
svn path=/trunk/; revision=36760
2011-04-21Fix Dead Store (Dead nested assignment) Warning found by Clang Alexis La Goutte1-2/+1
svn path=/trunk/; revision=36759
2011-04-21Fix Dead Store (Dead nested assignment) Warning found by Clang Alexis La Goutte1-1/+1
svn path=/trunk/; revision=36758
2011-04-21Fix Dead Store (Dead nested assignment) Warning found by Clang Alexis La Goutte1-1/+1
svn path=/trunk/; revision=36757
2011-04-21Fix Dead Store (Dead nested assignment) Warning found by Clang Alexis La Goutte1-1/+1
svn path=/trunk/; revision=36755
2011-04-21Fix Dead Store (Dead nested assignment) Warning found by Clang Alexis La Goutte1-2/+1
svn path=/trunk/; revision=36753
2011-04-21Fix Dead Store (Dead nested assignment) Warning found by Clang Alexis La Goutte1-1/+1
svn path=/trunk/; revision=36752
2011-04-21Include config.h only from .c files.Stig Bjørlykke13-4/+47
This avoids a warning building epan.c which includes both config.h and wslua.h (duplicate defines from config.h) svn path=/trunk/; revision=36751
2011-04-21Fix ep_check_canary_integrity to use proper variable.Jakub Zawadzki1-2/+2
Previously it would sigsegv (accessing (void *) -1), instead of displaying error. svn path=/trunk/; revision=36745
2011-04-20Simplify the test in a loop.Martin Mathieson1-5/+1
This was in response to a VS Code Analysis warning. Not sure if it was confused by lack of parenthesis, or if it detected that we had an && where both sides would always have the same value, but it was confusing. svn path=/trunk/; revision=36743
2011-04-20Add code to dissect "original uTP header format"Bill Meier1-45/+188
as described in the LibuTP utp.cpp source code; Add a kludgy heuristic to differentiate between original and "V1" header formats. TBD: validity of the heuristic; is there a better way ? svn path=/trunk/; revision=36742