Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2011-04-22 | Use _U_ for unused function parameters instead of assigning a variable | Stephen Fisher | 3 | -21/+7 | |
to itself. Found by clang compiler. svn path=/trunk/; revision=36813 | |||||
2011-04-22 | If we're using GNUC, use attribute warn_unused_result to verify that the | Jeff Morriss | 1 | -2/+7 | |
return value of proto_item_add_subtree() is used. (The WARN_IF_UNUSED macro doesn't belong here... But where should it go?) svn path=/trunk/; revision=36812 | |||||
2011-04-22 | Don't create subtrees that are not used (and don't create subtrees which might | Jeff Morriss | 1 | -15/+5 | |
have--if the original code was different--contained only one sub-item). Remove some no-longer-used ett variables. svn path=/trunk/; revision=36810 | |||||
2011-04-22 | Don't assume that a proto_item is equivalent to a proto_tree. | Jeff Morriss | 1 | -3/+4 | |
Use the return value from proto_item_add_subtree(). svn path=/trunk/; revision=36809 | |||||
2011-04-22 | Don't create a subtree that is not used. | Jeff Morriss | 1 | -4/+2 | |
svn path=/trunk/; revision=36808 | |||||
2011-04-22 | Use the return value of proto_item_add_subtree() | Jeff Morriss | 1 | -2/+3 | |
svn path=/trunk/; revision=36807 | |||||
2011-04-22 | Don't assume that a proto_item is equivalent to a proto_tree. | Jeff Morriss | 1 | -27/+26 | |
Use the return value from proto_item_add_subtree(). svn path=/trunk/; revision=36806 | |||||
2011-04-22 | Don't create a subtree that is not used. | Jeff Morriss | 1 | -4/+3 | |
svn path=/trunk/; revision=36805 | |||||
2011-04-22 | Use the return value of proto_item_add_subtree() | Jeff Morriss | 1 | -6/+9 | |
svn path=/trunk/; revision=36804 | |||||
2011-04-22 | Enhance BT-UTP dissector: | Alexis La Goutte | 1 | -59/+76 | |
* Add type (syn, data, reset...) in column info * Split dissect_utp_header(...) function to * dissect_utp_header_v0(...) * dissect_utp_header_v1(...) * dissect_utp_extensions(...) svn path=/trunk/; revision=36803 | |||||
2011-04-22 | Cleanup emem_verify_pointer() | Jakub Zawadzki | 1 | -15/+11 | |
svn path=/trunk/; revision=36800 | |||||
2011-04-22 | Add some casts to squelch complaints about alignment; our little slab | Guy Harris | 1 | -2/+2 | |
allocator should return properly-aligned items. svn path=/trunk/; revision=36799 | |||||
2011-04-22 | Remove invalid svn:executable property | Jakub Zawadzki | 1 | -0/+0 | |
svn path=/trunk/; revision=36798 | |||||
2011-04-22 | We deal with pointer alignment ourselves, so we ensure the casts are | Guy Harris | 1 | -3/+3 | |
safe. Tell the compiler so. svn path=/trunk/; revision=36796 | |||||
2011-04-22 | Either the buf argument to emem_scrub_memory() is properly aligned or it | Guy Harris | 1 | -3/+3 | |
isn't. If it is, we don't need to worry about alignment, so the XXX comment doesn't belong there; if it isn't, then we should do what the comment says. For now, assume the comment before the XXX comment is correct, and just cast away the alignment warning. svn path=/trunk/; revision=36795 | |||||
2011-04-22 | ep_alloc() returns a properly-aligned value for all uses; that's why it | Guy Harris | 1 | -2/+2 | |
returns void * rather than guint8 *. Don't pointer-convert that information away; otherwise, compilers might whine about safe pointer casts. svn path=/trunk/; revision=36794 | |||||
2011-04-22 | Stuff that comes back from ep_alloc() is properly aligned for all uses; | Guy Harris | 1 | -2/+2 | |
that's why it returns "void *", not "guint8 *". Don't pointer-convert that information away; otherwise, compilers might whine at you about unsafe casts. svn path=/trunk/; revision=36793 | |||||
2011-04-22 | Cast away bogus warnings. (I begin to see why C++ has templates here, | Guy Harris | 1 | -2/+2 | |
complicated though they might be for both users and implementors....) svn path=/trunk/; revision=36792 | |||||
2011-04-22 | "guint8 *" means "pointer to array of bytes that may or may not be | Guy Harris | 1 | -6/+10 | |
properly aligned"; "void *", at least when it's the return value of ep_malloc(), means "pointer to properly-aligned chunk of memory". Use "void *" in get_sdp_data_element() and its callers in that case, to squelch compiler warnings. svn path=/trunk/; revision=36790 | |||||
2011-04-21 | Remove unneeded #include <errno>,<math>,<ctype> & "isprint"; | Bill Meier | 1 | -32/+27 | |
Do minoir whitespace & indentation cleanup. svn path=/trunk/; revision=36786 | |||||
2011-04-21 | Add #include <ctype.h> before #include "isprint.h"; | Bill Meier | 1 | -187/+188 | |
Remove an unneeded line of code; Do some indentation & whitespace cleanup. svn path=/trunk/; revision=36785 | |||||
2011-04-21 | Avoid passing a NULL string pointer to format routines: some libc's (e.g., | Jeff Morriss | 1 | -7/+7 | |
Solaris') will seg-fault on that. svn path=/trunk/; revision=36784 | |||||
2011-04-21 | #include <errno.h> & #include <math.h> not req'd; | Bill Meier | 1 | -2/+0 | |
svn path=/trunk/; revision=36783 | |||||
2011-04-21 | Remove unneeded #include <ctype.h> and "isprint.h"; | Bill Meier | 1 | -36/+33 | |
Do minor whitespace cleanup. svn path=/trunk/; revision=36782 | |||||
2011-04-21 | Remove some unneeded #includes; | Bill Meier | 1 | -2523/+2519 | |
Correct some typos; Use consistent indentation & do some whitespace cleanup. svn path=/trunk/; revision=36781 | |||||
2011-04-21 | Remove some uneeded #includes; | Bill Meier | 1 | -70/+64 | |
Minor indentation & whitespace cleanup. svn path=/trunk/; revision=36780 | |||||
2011-04-21 | From Stefan Metzmacher and Gregor Beck via ↵ | Jeff Morriss | 1 | -5/+34 | |
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5850 : The smallest LDAP PDU is 7 bytes, not 4. svn path=/trunk/; revision=36777 | |||||
2011-04-21 | Avoid passing a NULL string pointer to format routines: some libc's (e.g., | Jeff Morriss | 1 | -946/+940 | |
Solaris') will core on that. Also clean up indentation and white space. svn path=/trunk/; revision=36775 | |||||
2011-04-21 | Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang | Alexis La Goutte | 1 | -1/+0 | |
svn path=/trunk/; revision=36773 | |||||
2011-04-21 | Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang | Alexis La Goutte | 1 | -1/+1 | |
svn path=/trunk/; revision=36771 | |||||
2011-04-21 | Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang | Alexis La Goutte | 1 | -2/+2 | |
svn path=/trunk/; revision=36770 | |||||
2011-04-21 | Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang | Alexis La Goutte | 2 | -14/+20 | |
svn path=/trunk/; revision=36769 | |||||
2011-04-21 | Oups | Alexis La Goutte | 1 | -1/+1 | |
Wrong fix in Rev36755 (Miss +2) svn path=/trunk/; revision=36768 | |||||
2011-04-21 | Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang | Alexis La Goutte | 1 | -1/+0 | |
svn path=/trunk/; revision=36766 | |||||
2011-04-21 | Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang | Alexis La Goutte | 1 | -1/+0 | |
svn path=/trunk/; revision=36765 | |||||
2011-04-21 | Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang | Alexis La Goutte | 1 | -1/+1 | |
svn path=/trunk/; revision=36764 | |||||
2011-04-21 | Remove is_continuation_line variable (Unused for 3 years with add SMTP ↵ | Alexis La Goutte | 1 | -12/+0 | |
Command Pipelining (RFC2920) Rev24989) Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang svn path=/trunk/; revision=36763 | |||||
2011-04-21 | Fix Dead Store (Dead nested assignment) Warning found by Clang | Alexis La Goutte | 1 | -2/+1 | |
svn path=/trunk/; revision=36762 | |||||
2011-04-21 | Fix Dead Store (Dead nested assignment) Warning found by Clang | Alexis La Goutte | 1 | -5/+5 | |
svn path=/trunk/; revision=36761 | |||||
2011-04-21 | Fix Dead Store (Dead nested assignment) Warning found by Clang | Alexis La Goutte | 1 | -1/+1 | |
svn path=/trunk/; revision=36760 | |||||
2011-04-21 | Fix Dead Store (Dead nested assignment) Warning found by Clang | Alexis La Goutte | 1 | -2/+1 | |
svn path=/trunk/; revision=36759 | |||||
2011-04-21 | Fix Dead Store (Dead nested assignment) Warning found by Clang | Alexis La Goutte | 1 | -1/+1 | |
svn path=/trunk/; revision=36758 | |||||
2011-04-21 | Fix Dead Store (Dead nested assignment) Warning found by Clang | Alexis La Goutte | 1 | -1/+1 | |
svn path=/trunk/; revision=36757 | |||||
2011-04-21 | Fix Dead Store (Dead nested assignment) Warning found by Clang | Alexis La Goutte | 1 | -1/+1 | |
svn path=/trunk/; revision=36755 | |||||
2011-04-21 | Fix Dead Store (Dead nested assignment) Warning found by Clang | Alexis La Goutte | 1 | -2/+1 | |
svn path=/trunk/; revision=36753 | |||||
2011-04-21 | Fix Dead Store (Dead nested assignment) Warning found by Clang | Alexis La Goutte | 1 | -1/+1 | |
svn path=/trunk/; revision=36752 | |||||
2011-04-21 | Include config.h only from .c files. | Stig Bjørlykke | 13 | -4/+47 | |
This avoids a warning building epan.c which includes both config.h and wslua.h (duplicate defines from config.h) svn path=/trunk/; revision=36751 | |||||
2011-04-21 | Fix ep_check_canary_integrity to use proper variable. | Jakub Zawadzki | 1 | -2/+2 | |
Previously it would sigsegv (accessing (void *) -1), instead of displaying error. svn path=/trunk/; revision=36745 | |||||
2011-04-20 | Simplify the test in a loop. | Martin Mathieson | 1 | -5/+1 | |
This was in response to a VS Code Analysis warning. Not sure if it was confused by lack of parenthesis, or if it detected that we had an && where both sides would always have the same value, but it was confusing. svn path=/trunk/; revision=36743 | |||||
2011-04-20 | Add code to dissect "original uTP header format" | Bill Meier | 1 | -45/+188 | |
as described in the LibuTP utp.cpp source code; Add a kludgy heuristic to differentiate between original and "V1" header formats. TBD: validity of the heuristic; is there a better way ? svn path=/trunk/; revision=36742 |