summaryrefslogtreecommitdiff
path: root/epan
AgeCommit message (Collapse)AuthorFilesLines
2013-05-03Add some casts to hush the buildbots, and fix what I assume was a copy-pastoEvan Huus1-5/+5
to ensure that the return value of strlen is actually used as the length of the string. svn path=/trunk/; revision=49142
2013-05-03Remove unnecessary global variablesMichael Mann2-12/+0
svn path=/trunk/; revision=49141
2013-05-03Finish improving NTLM and PLAIN authentication. Bug 8600 ↵Michael Mann1-27/+46
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8600) From Uli Heilmeier svn path=/trunk/; revision=49140
2013-05-02Dissect SSID List element.Michael Mann1-1/+39
From Jouni Malinen, bug 8613 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8613) svn path=/trunk/; revision=49137
2013-05-02Remove useless global variablesMichael Mann1-5/+0
svn path=/trunk/; revision=49136
2013-05-02Remove global variable g_pinfo.Michael Mann1-382/+378
svn path=/trunk/; revision=49135
2013-05-02From Sandeep Dahiya:Anders Broman1-0/+3
Extend the value_string that show the platform from where the packet was captured. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8624 svn path=/trunk/; revision=49133
2013-05-02Add a subtree for P2P Client Info Descriptor. Part of bug 8613 ↵Michael Mann1-22/+30
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8613) From Jouni Malinen svn path=/trunk/; revision=49132
2013-05-02IEEE802.11 improvements:Michael Mann1-10/+724
1. ANQP Venue Name is a UTF-8 string 2. Dissect Hotspot 2.0 indication and ANQP elements 3. Dissect TFS Request/Response 4. Dissect WNM-Notification Request frames svn path=/trunk/; revision=49131
2013-05-02Fix P2P Group Info validation code for Device Name length field. Bug 8613 ↵Michael Mann1-1/+1
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8613) From Jouni Malinen svn path=/trunk/; revision=49130
2013-05-02Add BSS Max Idle Period, WNM-Sleep Mode.Michael Mann1-7/+256
Fix and enhance TCLAS dissection. From Jouni Malinen, bug 8613 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8613) svn path=/trunk/; revision=49129
2013-05-01Protect a "divide by zero" operation. Bug 7359 ↵Michael Mann1-14/+22
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7359). This seems to have been generated through a corrupted UAT file switching between 1.8 and 1.10, but it's a good check to have regardless. svn path=/trunk/; revision=49128
2013-05-01Fix warning.Guy Harris1-1/+1
svn path=/trunk/; revision=49118
2013-05-01Remove some global variables in favor of private_data member of asn1_ctx_t. ↵Michael Mann3-31/+21
Bug 7060 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7060). This should (mostly) passify the bug, but it appears like this could be done with a lot more ASN.1 dissectors. svn path=/trunk/; revision=49117
2013-05-01Whitespace fixes: Indented lines should not start withJörg Mayer1-159/+159
spaces followed by tabs. svn path=/trunk/; revision=49115
2013-05-01Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8622 :Jeff Morriss1-2/+2
hsrp2.md5_auth_data is added to the tree with a length of 16 so declare it as FT_BYTES instead of FT_UINT32 (using the latter causes an assertion in trunk-1.8 and an expert info in trunk and trunk-1.10). svn path=/trunk/; revision=49114
2013-05-01Diederik de Groot <dkgroot@talon.nl>Jörg Mayer1-139/+222
via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8616 Further enhancements to packet-skinny.c, change cast. filters to skinny. filters. While I'm not sure whether that this is really correct, we don't have any sample capture to verify whether the old solution really worked. At least that way checkfiltername.pl doesn't complain any more ;-) Me: Tiny whitespace fixes. svn path=/trunk/; revision=49113
2013-05-01Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8618 :Jeff Morriss1-1/+1
Allow port 0 in RSA Key List. (This has been broken since r36875.) svn path=/trunk/; revision=49111
2013-05-01Make C12.22 work over UDP.Anders Broman1-7/+10
svn path=/trunk/; revision=49104
2013-04-30Follow-up to r49055 as noted onEvan Huus1-1/+4
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7359 The BER integer dissection routines take an hf_id, but that can be -1. Only fetch the type (to check signedness) if hf_id >= 0, as otherwise this causes a dissector bug. Default to signed if given no hf_id - I don't know whether this should be unsigned or not, but the old behaviour was that everything was signed so it's not a regression at least. svn path=/trunk/; revision=49101
2013-04-30Diederik de Groot <dkgroot@talon.nl>Jörg Mayer1-60/+369
via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8616 Update Skinny Dissection Code (CM7.1 + / SPCP Message) Me: - Remove some trailing whitespace - Numerically sort deviceTypes and replace older values with new ones - Reenable the return FALSE statement in the heuristics - it works for me. svn path=/trunk/; revision=49099
2013-04-30In part from Raúl Pérez Clavero via ↵Evan Huus3-0/+50
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8275 Implement wmem_slist_append(). svn path=/trunk/; revision=49094
2013-04-30Convert 'Old GFID' and 'New GFID' to FT_GUID type. Michael Mann1-2/+2
From Niels de Vos, Bug 8612 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8612) svn path=/trunk/; revision=49093
2013-04-30A few more doxygen fix-ups.Evan Huus3-2/+3
svn path=/trunk/; revision=49092
2013-04-30Move the contents of wsar_html/core to wsar_html. Create tag files forGerald Combs2-10/+26
core, epan, and ui, and link them to each other to varying degrees. This seems to be the best way to organize our documentation. The alternative is to switch to a single doxygen.cfg and manually add files to different groups or sections. Add a wireshark.dox file which contains markup for the main page. Add .dox and .txt to svnadd. Clean up our tag files. Force wsar_html to rebuild each time. svn path=/trunk/; revision=49091
2013-04-27Silence a false-positive warning from older GCCs:Evan Huus1-1/+1
'acetype4' may be used uninitialized in this function svn path=/trunk/; revision=49076
2013-04-27From Cal Turney via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8605Evan Huus1-327/+390
Numerous improvements to NFS ACL/ACE dissection. For a complete list see comment #11 of the bug. From me: - fix an infinite loop caught by fuzzing - fix an out-of-bounds memory access caught by valgrind - add missing {0,NULL} terminator to value_string array svn path=/trunk/; revision=49074
2013-04-27remove unnecessary if (tree) checksMartin Kaiser1-111/+84
I hope this prevents bugs like the one fixed in r48917 svn path=/trunk/; revision=49073
2013-04-26Wmem string-buffer improvements:Evan Huus3-5/+71
- better tests - fix a bug caught by the better tests - implement append_c and append_unichar, with tests Wmem string-buffers now have feature parity with their emem equivalents, so remove them from the TODO list. svn path=/trunk/; revision=49060
2013-04-26From me: only sign-extend BER integers if the field is actually signedEvan Huus2-5/+6
From Guy: override two fields in the GOOSE ASN.1 dissector to be unsigned Together these fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8250 svn path=/trunk/; revision=49055
2013-04-26Fix a whole bunch of doxygen warnings, mostly typos or renamed parameters.Evan Huus6-9/+8
svn path=/trunk/; revision=49053
2013-04-26Buildbot (via Twisted) sets a restrictive umask. Unset it before we runGerald Combs1-1/+1
Doxygen. svn path=/trunk/; revision=49052
2013-04-26Add some Doxygen checks.Gerald Combs1-0/+2
svn path=/trunk/; revision=49051
2013-04-26Update the main, epan, and ui Doxygen configuration files. Change theGerald Combs2-4/+13
output directory to wsar_html (Wireshark API Reference HTML) to match the Docbook naming convention. In each doxygen.cfg.in move the doxygen_global.cfg to the top of the file so that our local definitions don't get clobbered. Add makefile targets for wsar_html and wsar-zip. svn path=/trunk/; revision=49043
2013-04-25Annotate wmem functions for better compiler warnings and optimization.Evan Huus4-11/+24
svn path=/trunk/; revision=49041
2013-04-25Flag as malformed expert info if we see padding subheaders at start andMartin Mathieson1-0/+8
end of subheader list. svn path=/trunk/; revision=49035
2013-04-25From Mathias GuettlerMartin Kaiser1-1/+1
correct value for "ATN Systems Management No Preference" https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8562 svn path=/trunk/; revision=49034
2013-04-25Enhance dissection of feedbackPascal Quantin1-6/+16
svn path=/trunk/; revision=49032
2013-04-25Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8611Evan Huus1-0/+11
svn path=/trunk/; revision=49030
2013-04-25Try to please the OSX buildbotsPascal Quantin1-3/+3
svn path=/trunk/; revision=49024
2013-04-24Convert a few proto_tree_add_text to proto_tree_add_items. The dissector ↵Michael Mann1-23/+98
was originally under the 50% mark that checkAPIs.pl like, but subsequent patches pushed it over the limit, so I thought I'd knock it back down. svn path=/trunk/; revision=49023
2013-04-24convert some proto_tree_add_texts into expert_add_info_format. Didn't quite ↵Michael Mann1-15/+15
make checkAPIs.pl happy, but given the nature of the dissector (mostly raw text), I'm not sure it can hit the 50% ratio. svn path=/trunk/; revision=49022
2013-04-24Add a few IP filterable fields to make checkAPIs.pl happy. It appears that ↵Michael Mann1-51/+78
"enumerated filter fields" are necessary, but that allows them to shirk the check* tools to possibly find unused hfs. svn path=/trunk/; revision=49021
2013-04-24Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8610 :Pascal Quantin1-18/+29
Ensure that tap is called after full dissection, even in case of exception svn path=/trunk/; revision=49019
2013-04-24Fix format string typo causingEvan Huus1-1/+1
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8607 svn path=/trunk/; revision=49015
2013-04-24dumpabi: This would create the directories in the sourcedir insteadJörg Mayer1-5/+7
of the binary dir. Fixed that. NOTE: It fails with and without this patch for out of tree builds: jmayer@egg:~/work/wireshark/svn/build/qt-gtk3> make dumpabi [ 1%] Built target wsutil [ 1%] Generating libwsutil.abi.tar.gz ERROR: can't find modules cp: cannot stat `abi_dumps/libwsutil/libwsutil_*': No such file or directory make[3]: *** [wsutil/libwsutil.abi.tar.gz] Error 1 make[2]: *** [wsutil/CMakeFiles/dumpabi-libwsutil.dir/all] Error 2 make[1]: *** [CMakeFiles/dumpabi.dir/rule] Error 2 make: *** [dumpabi] Error 2 jmayer@egg:~/work/wireshark/svn/build/qt-gtk3> svn path=/trunk/; revision=49014
2013-04-24Add truncate function to wmem strbuf.Evan Huus3-1/+24
svn path=/trunk/; revision=49010
2013-04-24Now that the test suite is done and most of the common functions areEvan Huus5-35/+33
implemented, start replacing emem with wmem in dissectors. Also remove emem.h include from a few files that didn't actually need it. More to come once in hopefully large batches once I figure out the appropriate regexes. svn path=/trunk/; revision=49009
2013-04-23Revert commitsJörg Mayer1-3/+3
------------------------------------------------------------------------ r47064 | cmaynard | 2013-01-14 16:39:38 +0100 (Mo, 14 Jan 2013) | 2 lines packet-ncp2222.c -> dissectors/packet-ncp2222.c ------------------------------------------------------------------------ r47078 | gerald | 2013-01-14 21:05:24 +0100 (Mo, 14 Jan 2013) | 2 lines Put packet-ncp2222.c in epan/dissectors. This matches Makefile.am's behavior. ------------------------------------------------------------------------ The first commit tried to make cmake behavior mimic autofoo behavior while it should be the other way round: out of tree builds fail with packet-ncp2222.c generation with autofoo. The second commit just fixed the first one. svn path=/trunk/; revision=49008
2013-04-23Add a quick check for a first printable character to avoid a more expensiveMartin Mathieson1-0/+11
check of the whole first line. This gets called a lot as a heuristic dissector. svn path=/trunk/; revision=49006