summaryrefslogtreecommitdiff
path: root/gtk
AgeCommit message (Collapse)AuthorFilesLines
2006-03-07Fix Coverity run 12 CID 61: In main_cf_cb_live_capture_update_started(),Gerald Combs1-0/+1
make sure capture_opts isn't NULL before we try to use it. svn path=/trunk/; revision=17504
2006-03-07Solving various uninitialized variable warnings.Jaap Keuter1-8/+14
coverity reports 132, 133 and 134 svn path=/trunk/; revision=17501
2006-03-07Use g_assert to save us from dereferencing a NULL pointer. g_warning is not ↵Lars Roland1-4/+4
strong enough. This should fix a defect discovered by coverity. svn path=/trunk/; revision=17493
2006-03-05wrong name.Luis Ontanon1-1/+1
svn path=/trunk/; revision=17464
2006-03-05+ retap_packets()Luis Ontanon1-5/+52
+ complete gtk TextWindow + fix elua_dumper + fix elua_proto svn path=/trunk/; revision=17462
2006-03-04From Florent Drouin:Anders Broman1-1/+1
Just a little correction. In the last patch for gtk/gsm_map_stat.c applied, the variable "j" was changed to "i" . svn path=/trunk/; revision=17459
2006-03-02From Greg Morris:Anders Broman5-7/+104
- Change to display NCP connection for each conversation - New NCP Endpoints. Please apply expert_comp_table - Use local variable space instead of pointer. The previous implementation utilized pointers and the values would change the table data. svn path=/trunk/; revision=17446
2006-03-02In order to reduce the height of the Preference dialog moving several items ↵Jaap Keuter2-137/+266
from the User Interface page to the Layout page. svn path=/trunk/; revision=17444
2006-03-01The sequence and ack numbers in a TCP are guint32's, which means theyGuy Harris1-35/+35
should be printed with "%u", not "%lu" (especially on LP64 platforms). Fix up indentation. svn path=/trunk/; revision=17432
2006-02-27From: Florent Drouin:Anders Broman1-7/+13
Add a test to avoid divide by zero during stat. display. Use new variable j, instead of i, already used in the loop. svn path=/trunk/; revision=17416
2006-02-25From Martin MathiesonAnders Broman1-0/+1
- add SIP response code 412 ("Conditional Request Failed") to stats taps. svn path=/trunk/; revision=17409
2006-02-24add the dumpcap manpage to the menuUlf Lamping3-0/+5
svn path=/trunk/; revision=17402
2006-02-24Fix bug 769. Print seq# and ack# as _unsigned_ int in the comment.Jaap Keuter1-1/+1
svn path=/trunk/; revision=17400
2006-02-23when including menu.h we also need to include stdio.h to get FILERonnie Sahlberg1-0/+1
svn path=/trunk/; revision=17391
2006-02-23Fix bug 741. Menu/Toolbar follow auto scroll checkbox in capture options.Jaap Keuter1-0/+2
svn path=/trunk/; revision=17389
2006-02-23From Alejandro Vaquero:Anders Broman2-24/+26
a patch for the VoipCalls to fix a couple of issues: - a problem with the RTP Events (RFC2833) not been handle correctly - Display the RTP stream in time order when the setup frame is after the RTP stream. - fix a init issue that caused the H245 packet to not been displayed correctly. svn path=/trunk/; revision=17383
2006-02-22From Irene Ruengler:Michael Tüxen1-19/+29
Fix bug regarding the lower left edge and the handling of points outside the displayed region. svn path=/trunk/; revision=17373
2006-02-22Remove svn:executable property from source filesJaap Keuter2-0/+0
svn path=/trunk/; revision=17370
2006-02-21I commented out this a while ago as they caused a crash in GTK2.8/cairo on ↵Luis Ontanon1-12/+0
my box. I checked it in by mistake with a lot of more files, even worst I did not pay attention to an e-mail on the list regarding the damage caused. Luckily Alejandro Vaquero contacted me directly. svn path=/trunk/; revision=17363
2006-02-19For the "there's already a file with that name" dialog, use a wordingGuy Harris1-2/+3
more like the one used by gedit. (Note that the file in question might not be a capture file, although it probably is.) svn path=/trunk/; revision=17355
2006-02-18squelch some compiler warningsUlf Lamping1-3/+3
svn path=/trunk/; revision=17343
2006-02-17More duplicate code removal.Gerald Combs1-9/+2
svn path=/trunk/; revision=17339
2006-02-17Include some header files so that we can get rid of duplicate code andGerald Combs1-23/+12
call various GTK+ routines. svn path=/trunk/; revision=17338
2006-02-17Paolo Abeni:Jörg Mayer2-7/+17
pinfo->net_src and pinfo->net_dst where used to set up conversation, but this fields are null on eap stream. use pinfo->src and pinfo->dst instead. The patch also enable strict checking in the 'follow ssl stream' dialog. svn path=/trunk/; revision=17333
2006-02-17remove dependencies to pcap.h, so getting an idea what needs to be done by ↵Ulf Lamping9-20/+6
dumpcap in addition to the things already done now various dumpcap related code cleanup: mainly #include's and capture engine related stuff svn path=/trunk/; revision=17327
2006-02-16Freeze and thaw the packet list after a merge so that the packet list showsGerald Combs1-0/+2
the correct information. svn path=/trunk/; revision=17320
2006-02-16Move common control initialization to gtk/main.c where it belongs.Gerald Combs2-104/+94
Remove a MessageBox() call used for debugging. Fixup whitespace. svn path=/trunk/; revision=17319
2006-02-15Update a comment.Guy Harris1-3/+9
svn path=/trunk/; revision=17313
2006-02-15Have those functions that end up just calling a win32_ routine if we'reGuy Harris1-34/+29
using GTK+ 2.x on Windows just have the call, nothing else (no extra variables). svn path=/trunk/; revision=17308
2006-02-14Paolo Abeni:Jörg Mayer2-14/+29
- enable the 'follow SSL stream' menu item only when a ssl packet is selected. - when 'following' an ssl stream, show ssl decrypted data only for current conversation. - fix a typo in ssl preference description. svn path=/trunk/; revision=17301
2006-02-13add missing #include "tempfile.h"Ulf Lamping1-0/+1
svn path=/trunk/; revision=17294
2006-02-13Don't se_leak expert_info records.Luis Ontanon1-3/+5
se_alloc them where and if needed, not every time expert_set_info_vformat is called. svn path=/trunk/; revision=17293
2006-02-13add missing #include "tempfile.h"Ulf Lamping1-0/+1
svn path=/trunk/; revision=17289
2006-02-13Add a placeholder for integrating with the display filter dialog.Gerald Combs1-0/+3
svn path=/trunk/; revision=17286
2006-02-13Copy over the file open/save code from the Win32 native branch.Gerald Combs7-62/+1725
The Windows-native routines were integrated by inserting #if GTK_MAJOR_VERSION >= 2 && _WIN32 win32_native_routine(GDK_WINDOW_HWND(top_level->window)); return; #endif at the beginning of each GTK+ file routine. There's probably a prettier way to do this. Some of the sizes need to be tweaked in win32-file-dlg.rc, but everything seems to work. Fix up whitespace. svn path=/trunk/; revision=17285
2006-02-13Add tempfile.h to the list of headeer files. That was the problem, notGuy Harris1-1/+1
the pathname in the #include. svn path=/trunk/; revision=17280
2006-02-12Look for "tempfile.h" in the top-level directory.Guy Harris1-1/+1
svn path=/trunk/; revision=17279
2006-02-12Move create_tempfile() to tempfile.c out of util.c. This means dumpcapGuy Harris1-1/+1
no longer needs util.c, so it no longer includes routines that use host_ip_af(), so it no longer needs to define its own host_ip_af(). That also means dumpcap.c no longer needs to include <sys/socket.h>. svn path=/trunk/; revision=17278
2006-02-12Send LOG_DOMAIN_CAPTURE_CHILD messages to our log handler, so they don'tGuy Harris1-1/+4
go to the standard output (as is the case for some such messages, including the "child is sending an error message to the parent" message, which shows up if we fail to exec dumpcap). *Anything* other than an official capture-child message written to the standard output by the capture child confuses the heck out of the parent, and can cause it to think the child closed the pipe (resulting, in the case described in the previous parenthetical note, in no dialog box being displayed for dumpcap not being executed). svn path=/trunk/; revision=17274
2006-02-12Well, it doesn't help to apply patches and then forget to actuallyJörg Mayer1-11/+0
commit them. Patch by Paolo Abeni: remove some commented out code. svn path=/trunk/; revision=17271
2006-02-12Add a routine to attempt to get the absolute pathname of the executableGuy Harris2-7/+7
file, strip off the last component to get the pathname of the directory containing the executable file, and save it for future use. On Windows, you can get that from the OS, but, on UN*X, you have to look at argv[0] and derive the absolute path from that (argv[0] is not guaranteed to be an absolute path, or even a path at all). (In addition, if you're running from the build directory, you might have to strip off a ".libs/" added to argv[0] as an artifact of the libtoolizing script.) Use that in the About dialog, and use it to construct the path of dumpcap. Don't put quotes into the path of dumpcap; you don't have to quote strings with spaces in them when handing them to execvp and, in fact, you *mustn't* quote them, as the quotes will be treated as part of the pathname. svn path=/trunk/; revision=17267
2006-02-12Add userdata arguments to a bunch of stat initialization routines toGuy Harris16-139/+140
squelch compiler warnings. Tag one existing such argument as unused to squelch another warning. Fix up some indentation. svn path=/trunk/; revision=17261
2006-02-11various capture child related minor cleanupsUlf Lamping1-20/+5
svn path=/trunk/; revision=17258
2006-02-11font_init don't need to know if running as a capture_child, this will simply ↵Ulf Lamping3-19/+3
no longer happen. svn path=/trunk/; revision=17257
2006-02-11the point of no return ...Ulf Lamping1-73/+5
using dumpcap as the capture child for Ethereal. dumpcap is a plain console application now, even for Win32 (so no WinMain, create_console and special piping stuff reguired). The undocumented command line option -Z will switch dumpcap into "child mode", using binary instead of plain text output messages to communicate with a parent Ethereal. Ethereal's main.c no longer needs to distinguish between child mode or not, so some simplifying here. capture_sync.c has to call dumpcap in a "hidden window" mode using CreateProcess instead of spawnvp, otherwise an uggly console window would appear. The handles created by _pipe doesn't seem to be inheritable for this function, using CreatePipe instead. The file capture_loop.c is only needed by dumpcap, removed from Ethereal link objects. Some debugging aid added and other minor cleanup done. svn path=/trunk/; revision=17256
2006-02-11minor bugfix: restore the Ethereal icon (after capturing) at the right placesUlf Lamping1-13/+26
svn path=/trunk/; revision=17255
2006-02-11 add an userdata argument to register_stat_cmd_arg() and its callback to use ↵Luis Ontanon42-139/+168
the callback for multiple registrations. svn path=/trunk/; revision=17252
2006-02-11In "Save As", support only file types we can write to; that simplifiesGuy Harris5-139/+108
the logic, making it easier to get it right (fewer interactions between components of the dialog - the file type doesn't affect whether we can save some but not all packets). It also means we don't offer a file type for saving, only to take it away if you choose anything other than saving all packets. If the capture file is a temporary file from a capture done in the current Ethereal session, it's libpcap format, which we can write to, so you would be able to save it. If it's a saved file we read in, saving the file in its entirety in its own format is just copying the file, and it's not clear supporting that adds enough useful functionality to justify the extra complication. Fix "range_update_dynamics()" to update all the rows of the range button/count table properly (make the button active iff there's a non-zero count in the currently-selected column, make a count active iff the column is selected), to select the "Captured" column if the count of displayed packets goes to zero, and to select the "Save all packets" row if the count of packets in the currently-selected row and column goes to zero. (XXX - we should perhaps do that with the "user-defined range" counts as well, which would involve updating the counts on every change to the range field.) svn path=/trunk/; revision=17251
2006-02-11Display g_error messages in the console window unconditionally, if ↵Lars Roland1-2/+4
preferences aren't loaded yet. This way we ensure that errors are displayed during protocol registration. Use g_error instead of g_warning, if not allowed characters are used in display filter names for protocols. Extend the error message in this case. svn path=/trunk/; revision=17248
2006-02-10remove all calls to exit() from the capture_opts.c and replace them by ↵Ulf Lamping1-3/+7
status return values (0,1 or 2). This way makes it much easier to debug, e.g. to set a common breakpoint if a command line parameter fails. svn path=/trunk/; revision=17240