summaryrefslogtreecommitdiff
path: root/ui/gtk/bytes_view.c
AgeCommit message (Collapse)AuthorFilesLines
2016-07-24Pacify GTK checkAPIs.pl warnings.Michael Mann1-1/+1
Add "Wireshark" macros to old-gtk-compat.h for GTK APIs that have been deprecated. The macros are setup by version number to limit their proliferation (not that I suspect much development will really be done there since GTK is deprecated). Just want to make buildbots happy for the time being. Change-Id: I095f850065166a0bc2e2456fb2e886ab64fdd97d Reviewed-on: https://code.wireshark.org/review/16635 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Balint Reczey <balint@balintreczey.hu> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-18Qt: use recent.gui_bytes_view preference to remember bits / byte viewPascal Quantin1-1/+1
While we are at it, let's centralize bytes_view_type definition Bug: 11903 Change-Id: I606c779a8efaea668db1b440d3ae0336e6e3fc67 Reviewed-on: https://code.wireshark.org/review/12706 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-12-18Removed local definitions of offsetof().Stig Bjørlykke1-4/+0
The offsetof() macro is an ANSI C library feature. Change-Id: I2ac91b0b4c94c6f6baf14133b076fdc5ed2e182b Reviewed-on: https://code.wireshark.org/review/12707 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-06-03G_STRUCT_OFFSET gives warnings turned errors with MSVC2015,Anders1-1/+6
use offsetof if defined or define it ourselfs as done in other places in our code base. Change-Id: Ia1c72c9648336e93ba8c14d4bc0371d782835370 Reviewed-on: https://code.wireshark.org/review/8735 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-02-15ui/gtk/*.c: Add editor modelines; As needed: Fix indentationBill Meier1-6/+19
Change-Id: I8cd9d9fe5f12c284f46b8f725766f681faccd753 Reviewed-on: https://code.wireshark.org/review/7138 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-02-14Fix diagnostics macros and squelch a gcc warning.Gerald Combs1-4/+2
Both clang and gcc define __GNUC__. Make sure we account for that when defining diagnostic macros. Use DIAG_OFF + DIAG_ON to suppress gcc -pedantic warnings about frame_data. Get rid of packet_char_enc casts. Change-Id: Idbcc61bcdb35c1d20f185461c69451dcdf73bae9 Reviewed-on: https://code.wireshark.org/review/7106 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-01-01Remove unneeded includes from ui folderMartin Mathieson1-1/+0
Change-Id: Ifd1eebff9080cd3867e44e4dcb2d2681370ed60a Reviewed-on: https://code.wireshark.org/review/6128 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-10-12Make boolean bitmask type 64-bit wideDaniel Mack1-1/+1
There are protocols out there that have 64-bit wide bit mask fields, so make the internal representation and bitfield decoders 64-bit aware. For this, the ws_ctz() fallback and bits_count_ones() have to be tweaked slightly. Change-Id: I19237b954a69c9e6c55864f281993c1e8731a233 Reviewed-on: https://code.wireshark.org/review/4158 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-04-25Move the XXX-to-UTF-8 loops to routines in epan/charsets.c.Guy Harris1-0/+1
This moves a bunch of character set knowledge into epan/charsets.c. Change-Id: Ieb79dcaac9753c77703af756b666ad2ca9385d9e Reviewed-on: https://code.wireshark.org/review/1339 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-12-21Drop isprint.h use g_ascii_isprint() when this include hack was enabled.Jakub Zawadzki1-3/+1
svn path=/trunk/; revision=54327
2013-07-26gtk_widget_modify_font() has been renamed to gtk_widget_override_font() in GTK3Bill Meier1-0/+4
svn path=/trunk/; revision=50915
2013-06-26packet-editor: Allow focus for byteview, it should fix problems with field ↵Jakub Zawadzki1-0/+3
hexeditor not getting key-press-event. Generally it should be also safe for builds without packet-editor, just in case ifdef it. svn path=/trunk/; revision=50172
2013-06-21One more fix for the protocol grey highlighting.Evan Huus1-2/+4
svn path=/trunk/; revision=50100
2013-06-21Yet another fix, put spaces in insensitive or normal state.Jakub Zawadzki1-6/+9
svn path=/trunk/; revision=50099
2013-06-20Highlight protocol bytes in grey, idea stolen from qtsharkJakub Zawadzki1-13/+27
svn path=/trunk/; revision=50095
2013-06-08Fix 'Misaligned columns in hex dump pane' [1]Jakub Zawadzki1-0/+1
Old code was broken for all pango version < 1.20 [1] http://www.wireshark.org/lists/wireshark-dev/201306/msg00015.html svn path=/trunk/; revision=49848
2013-05-31Don't call gtk_widget_unregister_window() in bytes_view_unrealize() after ↵Balint Reczey1-3/+1
GTK+ 3.8.0 to prevent double invocation causing crash. This fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8604 . The patch is from Jakub Zawadzki. svn path=/trunk/; revision=49655
2013-05-30Use gtk_widget_register_window() and gtk_widget_unregister_window()Balint Reczey1-0/+8
instead of deprecated gdk_window_set_user_data() for GTK+ 3 >= 3.8 svn path=/trunk/; revision=49633
2013-03-28Follow up on bug 8416.Jaap Keuter1-5/+5
Remove C++ incompatibilities in GTK+ 3 code. svn path=/trunk/; revision=48606
2013-03-21From beroset:Bill Meier1-3/+3
remove C++ incompatibilities https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 attachment #10404 Note: The following parts of the patch had been previously done: asn1/snmp/packet-snmp-template.c epan/dissectors/packet-snmp.c epan/dissectors/packet-x11.c Also; hostlist_table.c: code under '#ifdef HAVE_GEOIP' didn't compile and needed a few additional patches. svn path=/trunk/; revision=48447
2013-03-08Use explicit casts.Anders Broman1-8/+8
svn path=/trunk/; revision=48187
2013-01-06Fix some Dead Store (Dead assignement/Dead increment) Warning found by ClangAlexis La Goutte1-1/+0
svn path=/trunk/; revision=46968
2012-11-25 Fix several [-Wshadow] warnings;Bill Meier1-39/+39
Also: Do some minor whitespace and formatting changes. svn path=/trunk/; revision=46185
2012-09-20We always HAVE_CONFIG_H so don't bother checking whether we have it or not.Jeff Morriss1-2/+0
svn path=/trunk/; revision=45016
2012-07-23Fix bug #7520: Byteview related Glib-GObject-Critical msgs during GTK2 ↵Jakub Zawadzki1-4/+33
Wireshark startup Put generated, with *proper* types version of marshaler (VOID:OBJECT,OBJECT) inside bytes_view.c It was also only blocker of #undef GTK_DISABLE_DEPRECATED, so remove it. XXX generated version of marshaler looks portable, but it'd be best to generate it using glib-genmarshal during compilation. svn path=/trunk/; revision=43947
2012-07-20BytesView: use "view" class (GtkTextView) instead of "entry" (GtkEntry) one.Jakub Zawadzki1-5/+5
Cheat a little and always make BytesView focused to make render blue-highlight instead of grey /inactive/ one. XXX, we should have our own BytesView class and allow user define his own style in css. svn path=/trunk/; revision=43859
2012-07-20Fix bug #7502Jakub Zawadzki1-0/+5
In gtk3 upper value of adjustment can't be smaller than page_size. Otherwise strange things happens ;-) svn path=/trunk/; revision=43856
2012-07-19Remove unused variable.Anders Broman1-1/+0
svn path=/trunk/; revision=43826
2012-07-19Use define instead of string constant.Jakub Zawadzki1-1/+1
svn path=/trunk/; revision=43824
2012-07-19BytesView: use GtkStyleContext for gtk-3 (bug #7502)Jakub Zawadzki1-7/+45
svn path=/trunk/; revision=43823
2012-07-19BytesView: Support for gtk3 scrollbar.Jakub Zawadzki1-5/+93
svn path=/trunk/; revision=43821
2012-07-17Now it compiles with 2.24 - hopefuly it will even workJörg Mayer1-2/+2
svn path=/trunk/; revision=43767
2012-07-17Bring compilation with gtk 2.24 one step further (not yet working)Jörg Mayer1-0/+5
svn path=/trunk/; revision=43766
2012-07-16- Restore optimization of drawing only lines in clipping areaJakub Zawadzki1-12/+19
- Fix compilation for < gtk-2.14 svn path=/trunk/; revision=43745
2012-07-16Compilation fixes for gtk-3.x + for gtk-2.x use clipping region not area.Jakub Zawadzki1-24/+47
svn path=/trunk/; revision=43744
2012-07-16- Make it compile gtk-2.24 with GSEAL_ENABLE enabledJakub Zawadzki1-63/+112
- ->draw for gtk-3.x (NOT TESTED!!!) svn path=/trunk/; revision=43743
2012-07-16Some gtk-3.0 fixes.Jakub Zawadzki1-7/+49
svn path=/trunk/; revision=43742
2012-07-16<gtk/gtkmarshal.h> doesn't appear to be necessary, at least with GTK+Guy Harris1-5/+15
2.24.5. Remove the include of it. Get rid of duplicate #undefs of GTK_DISABLE_DEPRECATED and GSEAL_ENABLE - nothing in config.h should depend on them. Make at least some of the changes that http://developer.gnome.org/gtk3/stable/ch24s02.html#id1459694 and http://developer.gnome.org/gtk3/stable/ch24s02.html#id1459754 seem to indicate we need to make for GTK+ 3. svn path=/trunk/; revision=43739
2012-07-16The CMake builds in the Ubuntu buildbot appear to be building with GTK+Guy Harris1-1/+3
3; if so, that might indicate that GTK+ 3 doesn't have gtkmarshal.h. Try not attempting to include it with GTK+ 3.x - if that causes other failures, well, I guess that means that, when building the BytesView widget under GTK+ 3, we can't use the gtk_marshal_ functions.... svn path=/trunk/; revision=43737
2012-07-16For the encoding and format, use the enum types.Guy Harris1-6/+6
Add some comments. svn path=/trunk/; revision=43736
2012-07-15Fix some gseal warnings.Jakub Zawadzki1-18/+31
svn path=/trunk/; revision=43734
2012-07-15Get rid of unnecessary include.Guy Harris1-2/+0
svn path=/trunk/; revision=43733
2012-07-15Squelch some more warnings with explicit casts.Guy Harris1-4/+4
svn path=/trunk/; revision=43732
2012-07-15Try gdouble here, to see if it removes "gdouble to gfloat" warnings withGuy Harris1-1/+1
MSVC. svn path=/trunk/; revision=43731
2012-07-15Fix bug #6690: Wireshark quite slow displaying frames with many detail pane ↵Jakub Zawadzki1-0/+1156
nodes and large byteviews Add custom widget to render hexdump or bitsdump. svn path=/trunk/; revision=43728