summaryrefslogtreecommitdiff
path: root/ui/qt/display_filter_combo.cpp
AgeCommit message (Collapse)AuthorFilesLines
2014-12-01qt: fix use-after-free patternPeter Wu1-4/+3
qstring.toUtf8() returns a QByteArray object and .constData() returns a pointer inside that object. It is not safe to store this pointer as it will become invalid after the statement. Store a const reference instead. (Due to scoping differences, some are copy-assigned though.) In the UAT dialog, strlen(bytes.constData()) has also been replaced by bytes.size() as an optimization. Caught by ASAN. Change-Id: Ie09f999a32d0ef1abaa1e658b9403b74bedffc37 Reviewed-on: https://code.wireshark.org/review/5528 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-03-12Fix bug 9866: Qt 'Clearing filters does not seem to affect the packet list'Hadriel Kaplan1-0/+3
Clicking the "X" clear filter button now applies the clearing to the displayed packet list. This commit also adds tooltips for the display filter display filter box's butons. Change-Id: I827020a7705a32a4a9204d22e94942853e25bba6 Reviewed-on: https://code.wireshark.org/review/601 Reviewed-by: Evan Huus <eapache@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2013-11-21Add a statistics tree dialog.Gerald Combs1-1/+1
Add menu items for each corresponding item in gtk/main_menubar.c that calls gtk_stats_tree_cb(). Hopefully that's everything. Note that we use quite a bit less code than the GTK+ flavor and why we might not want to do that. Change a few things in ui/qt/CMakeLists.txt to more closely match the GTK+ version. Add plumbing for tap registrations in CMakeLists.txt and Makefile.am. Add the ability to copy text as CSV or YAML. svn path=/trunk/; revision=53464
2013-07-27Have separate lists of recent capture filters for all interfaces, inGuy Harris1-16/+0
addition to a "global" list. Store all of those lists in the recent file. Maintain the lists in ui/recent.c, rather than attaching them to widgets; have the code that populates the combo boxes get the lists from the ui/recent.c code. This makes a little more of the code GUI-toolkit-independent, and should fix bug 7278. #BACKPORT 1.10, 1.8 svn path=/trunk/; revision=50956
2013-05-22Include "ui/recent_utils.h" so that the functions we define are checkedGuy Harris1-0/+1
against the declarations for them. svn path=/trunk/; revision=49528
2013-04-24The porting guide for Qt5 requires that Q_OS_ be used insteadJörg Mayer1-1/+1
of Q_WS_ in Qt4 projects See: http://qt-project.org/doc/qt-5.0/qtdoc/portingguide.html svn path=/trunk/; revision=49013
2013-01-18Rename the "saved_val" preference element to "stashed_val" in order toGerald Combs1-1/+1
more clearly indicate that it's a copy of a preference value rather than something we've saved in the preferences file. Update prefs_pref_to_str() to handle default, stashed, and current prefs. Create ui/preference_utils.[ch] and move some common routines there. Use prefs_pref_type_name() in the GTK+ preferences dialog. Make the "OK" button in the Qt preferences dialog work. We simply write the prefs and redissect on "OK" and do nothing on "Cancel". This is intentionally different from the Apply/OK/Cancel behavior in the GTK+ version. Add a general "emitAppSignal" method to wsApp and use it for packet dissection and preference changes. Suggest that we might want to create a WsString class to make conversion between QStrings, gchar *s, and GStrings easier. svn path=/trunk/; revision=47139
2012-12-26Fix a bunch of warnings.Guy Harris1-2/+2
Cast away some implicit 64-bit-to-32-bit conversion errors due to use of sizeof. Cast away some implicit 64-bit-to-32-bit conversion errors due to use of strtol() and strtoul(). Change some data types to avoid those implicit conversion warnings. When assigning a constant to a float, make sure the constant isn't a double, by appending "f" to the constant. Constify a bunch of variables, parameters, and return values to eliminate warnings due to strings being given const qualifiers. Cast away those warnings in some cases where an API we don't control forces us to do so. Enable a bunch of additional warnings by default. Note why at least some of the other warnings aren't enabled. randpkt.c and text2pcap.c are used to build programs, so they don't need to be in EXTRA_DIST. If the user specifies --enable-warnings-as-errors, add -Werror *even if the user specified --enable-extra-gcc-flags; assume they know what they're doing and are willing to have the compile fail due to the extra GCC warnings being treated as errors. svn path=/trunk/; revision=46748
2012-12-07Use a different border color on OS X.Gerald Combs1-0/+4
svn path=/trunk/; revision=46458
2012-12-07Properly resize the bookmark button so that the image centers properly.Gerald Combs1-2/+1
Adjust CSS. svn path=/trunk/; revision=46451
2012-12-07Implement the items under "Edit→Copy", "Analyze→Apply as Filter" andGerald Combs1-0/+17
"Analyze→Prepare a Filter". Add a context menu to the protocol tree and fill in the items we've implemented so far. Add an "applyAllPreferences" method and corresponding "preferencesUpdated" signal to wsApp. Use it to set the maximum display filter combo count. Move the packet filtering code from the display filter edit to the main window (which makes more sense and matches what we're doing in the GTK+ version and gets rid of more global cfile references). Try to center the display filter edit button images. Use a different "close" button in the main toolbar. It looks better but is still wrong (on OS X at least). svn path=/trunk/; revision=46434
2012-12-05Fix some C++ abuses that Guy found via LLVM.Gerald Combs1-1/+2
svn path=/trunk/; revision=46408
2012-09-04Add modelines for Qtshark fileAlexis La Goutte1-0/+13
svn path=/trunk/; revision=44766
2012-06-28Update Free Software Foundation address.Jakub Zawadzki1-1/+1
(COPYING will be updated in next commit) svn path=/trunk/; revision=43536
2012-03-07Add i18n to QtSharkAlexis La Goutte1-1/+1
The goal is only to translate the Gui (Not dissector) Actually, there is only a french translation. To try, (if you are not French) launch qtshark with LANG=fr ./qtshark (in ui/qt folder) Missing some feature : * Add preference to select (force) your language * Some Gui Text, it no available for translation * Documentation about how to translate (Coming soon...) * Your translation ! svn path=/trunk/; revision=41389
2012-01-18Reflect the changes to make the recent-file code GUI-independent.Guy Harris1-5/+5
svn path=/trunk/; revision=40563
2012-01-15Move gtk to ui/gtk.Jörg Mayer1-1/+1
This looses the last checkin to gtk, will add this manually back. svn path=/trunk/; revision=40518
2012-01-04Add initial support for Qt along with a "ui" subdirectory.Gerald Combs1-0/+116
svn path=/trunk/; revision=40378
generated by cgit v1.2.1 (git 2.18.0) at 2024-07-02 02:21:46 +0000