summaryrefslogtreecommitdiff
path: root/ui/qt/follow_stream_dialog.cpp
AgeCommit message (Collapse)AuthorFilesLines
2015-10-05Move utf8_entities.h to wsutilJoão Valverde1-1/+1
Change-Id: I6298b3de5f0a1cb988014ff16082eaf8c2a3c3c0 Reviewed-on: https://code.wireshark.org/review/10786 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-08-26Rework tapping in Qt dialogs.Gerald Combs1-18/+9
Add cf_cb_file_retap_started and cf_cb_file_retap_finished to file.[ch]. Add their associated signals to CaptureFile. Add registerTapListener and removeTapListeners to WiresharkDialog, which collect and automatically remove tap listeners. Add beginRetapPackets and endRetapPackets, which can be used to wrap critical sections so that we don't delete ourselves while tapping. Don't cancel tapping on close in WiresharkDialog. Use beginRetapPackets and endRetapPackets in WiresharkDialog and FollowStreamDialog. We will likely need to add them elsewhere. Update comments. Change-Id: I1788a6ade0817c31aa3419216df96be5e36b2178 Reviewed-on: https://code.wireshark.org/review/10261 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-08-26Add per-dialog progress frames.Gerald Combs1-0/+3
Add ProgressFame::addToButtonBox, which violates the UX guidelines on every platform we support by inserting a ProgressFrame into a QDialogButtonBox. Call addToButtonBox in the constructors of a bunch of dialogs. Change-Id: I33ac5fd7a976ee6e0527de569a5c4b528980dae1 Reviewed-on: https://code.wireshark.org/review/10242 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-08-03Make sure per-packet tap callbacks return gbooleans.Gerald Combs1-4/+4
The tap API changed the return type of per-packet listener callbacks from int to gboolean back in 2009. Update a bunch of functions and some documentation accordingly. Change-Id: I79affe65db975caed3cc296a7e2985b7b9cdf4cc Reviewed-on: https://code.wireshark.org/review/9853 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-07-31Use an ellipsis character instead of three dots.Gerald Combs1-1/+1
The OS X Human Interface Guidelines at https://developer.apple.com/library/mac/documentation/UserExperience/Conceptual/OSXHIGuidelines/TerminologyWording.html#//apple_ref/doc/uid/20000957-CH15-SW3 says: "Be sure to create the ellipsis character using the key combination Option-; (Option-semicolon). This ensures that an assistive app can provide the correct interpretation of the character to a disabled user. If you use three period characters to simulate an ellipsis, many assistive apps will be unable to make sense of them. Also, three period characters and an ellipsis don't look the same because the periods are spaced differently than the points of an ellipsis." The Windows desktop applications guidelines has a section on ellipses: https://msdn.microsoft.com/en-us/library/windows/desktop/dn742478.aspx but doesn't specify the a single glyph vs three dots. The GNOME HIG at https://developer.gnome.org/hig/stable/typography.html.en says "Take Advantage of Unicode" then specifically says to use U+2026 HORIZONTAL ELLIPSIS. Remove the ellipsis from "Find Next" and "Find Previous". Neither requires user interaction. Change-Id: I0e6c28bb8b3a84b242731e2ca96f1a6f6f42c303 Reviewed-on: https://code.wireshark.org/review/9833 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-07-16Add the RTP Stream Analysis dialog.Gerald Combs1-1/+1
Combine the GTK+ RTP Stream Analysis and RTP Graph Analysis dialogs into one. Yell at the user less. Disable the Analyze RTP Stream menu item if we don't have an RTP stream selected. There are a *lot* of moving parts in this dialog. I've tested with the few RTP captures I have but it's by no means complete. "To do" items are listed at the top of rtp_analysis.cpp. Change-Id: Id503977f069bebc46cc68bc749f0c9cbf4d37bf6 Reviewed-on: https://code.wireshark.org/review/9650 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-07-07Finish removal of Q_UNUSED.Joerg Mayer1-8/+3
Todo: qcustomplot via upstream Change-Id: I19cf98f1281ecb1f6efbb7d36c997d5aa43f5baf Reviewed-on: https://code.wireshark.org/review/9547 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2015-06-25Qt: use <> for including the generated ui_*.h filesMartin Kaiser1-1/+1
this should make Visual Studio pick up the generated include files from the build directory instead of the source directory (which may contain lefovers from an in-tree build) Change-Id: Ie3de4cdd85a2865e203118a42ab10f443372f03b Reviewed-on: https://code.wireshark.org/review/9129 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-06-24Remove another batch of deprecated tvb_length callsEvan Huus1-2/+2
Change-Id: Icfdde38e40cca05d0705a081153a4ea3e8782ee7 Reviewed-on: https://code.wireshark.org/review/9086 Reviewed-by: Evan Huus <eapache@gmail.com>
2015-01-08ep_<protocol>_port_to_display -> <protocol>_port_to_displayMichael Mann1-6/+9
Adjust any other ep_ related APIs related to the transition. Change-Id: I961b371c2c4bda557e0f1817705c27eef0dae66c Reviewed-on: https://code.wireshark.org/review/6388 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-12-31Qt: Convert more dialog titles.Gerald Combs1-1/+1
Change-Id: I9c3e3471a92b7af9347a541bece3d9405d37dce0 Reviewed-on: https://code.wireshark.org/review/6193 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-12-31Move the version_info.c stuff to wsutil/ws_version_info.c.Guy Harris1-2/+1
Change-Id: I3a5c7e219974bfb924819b43b4d445eaf00e5bde Reviewed-on: https://code.wireshark.org/review/6153 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-12-30Qt: More WiresharkDialog conversions.Gerald Combs1-37/+35
Convert the Follow Stream and Export Objects dialogs. Change-Id: I8a4dda634f2f0475a24cf09601f76fb52069fe50 Reviewed-on: https://code.wireshark.org/review/6126 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-12-29Add ability to follow UDP stream by indexPascal Quantin1-6/+21
-z "follow,udp" tshark cli command now supports a stream index It is now possible to select the UDP stream displayed in Qt GUI (like for TCP) Change-Id: Ia367f36ea4f60db0fddb997a7e0903c09e172f2d Reviewed-on: https://code.wireshark.org/review/6083 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-12-28Qt Follow window: keep data representation when switching between streamsPascal Quantin1-3/+3
Change-Id: I1c7092d33d841e80ce110224f3bd617cb112be61 Reviewed-on: https://code.wireshark.org/review/6091 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-12-28Removed duplicated #include linesDario Lombardo1-1/+0
Change-Id: I9cafa3cd5c74121168777d8c656e7e94e89efd3c Reviewed-on: https://code.wireshark.org/review/6065 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-12-09Qt: Initial VoIP Calls dialog.Gerald Combs1-1/+0
Add Telephony menu items for VoIP Calls and SIP Flows. Put VoIP Calls at the top, since that seems to be the primary item. Add configure-time checks for QtMultimediaWidgets in anticipation of adding a VoIP playback dialog. Add an icon for the playback button. (Yes, I've been avoiding GNOME-level gratuitous icons so far but this is one of the rare occiasions where it makes sense.) Add a help link define for the VoIP calls dialog. Change-Id: I5d0799685c598ad9af76fe9667f8ea7d14b66050 Reviewed-on: https://code.wireshark.org/review/5674 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-12-09Qt: Update and rename the summary dialog.Gerald Combs1-0/+1
Go back to a single view similar to the GTK+ UI. Apply layouts using Qt Designer. Rename the menu item and class to "Capture File Properties". It's not really a summary if it contains details such as "marked average bits per second". We might want to move this to a "Properties" item under the "File" menu similar to other applications. Add the GTK+ summary icon (for now) to the toolbar and open the properties dialog on clicking. Singleton dialogs delenda est[1]. Let the user open as many summaries on as many capture files as he or she wishes. Also, global cfile delenda est[2]. Don't blindly include QtGui. Add specific components instead. Use consistent method names, variable names, and patterns. Try to document what "consistent" means. Adjust the way we display some statistics to match the summary bar, e.g. displayed = captured if we don't have a filter applied. [1] Not really. [2] Yes, really. Change-Id: I11793b1d79dd0c3f70414ac8592b86181da59916 Reviewed-on: https://code.wireshark.org/review/5274 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-12-08Remove an unnecessary include.Gerald Combs1-2/+0
Change-Id: I55332c21ea66ee7d564c2b338cba524ea774b19c Reviewed-on: https://code.wireshark.org/review/5677 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-11-03Qt: fix a potential memory leak FollowStreamDialog::follow() found by ↵Pascal Quantin1-1/+4
Coverity (CID 1159304) Change-Id: I53709c6729c6d9156d2ba5ccd83e92bc27433e26 Reviewed-on: https://code.wireshark.org/review/5065 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-11-01Qt: Limit the amount of Follow Stream text.Gerald Combs1-27/+47
QTextEdit + QTextDocument don't handle large amounts of data very well. Truncate our displayed text after 2 MB. Change-Id: I0b549a0b05a490272bc0d34af0f2c6661c548d0f Reviewed-on: https://code.wireshark.org/review/5042 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-10-31Qt: Better Follow Stream hints.Gerald Combs1-2/+6
Show the client and server colors in the hint text. Change-Id: Iddcda8c3f4f7dc0d8919749aeffc8c09c6445c17 Reviewed-on: https://code.wireshark.org/review/5035 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-10-31Qt: Disable our widgets while tapping.Gerald Combs1-4/+27
Prevents a crash when changing the spinbox value during the middle of a follow. Change-Id: I07cea883c72c5975633e4b7046155f9b6de9cc4a Reviewed-on: https://code.wireshark.org/review/5034 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-08-30Qt Follow Stream Dialog : Add some missing text to translateAlexis La Goutte1-10/+10
Fix also indent Change-Id: I864cd785f3b17e6360be63922ca63e349ae13f25 Reviewed-on: https://code.wireshark.org/review/3913 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-07-07Update README.qt and add todo items.Gerald Combs1-0/+1
Change-Id: I69c080253cf7e861c575573e74a66b83e014cbb0 Reviewed-on: https://code.wireshark.org/review/2925 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-05-13isprint() -> g_ascii_isprint()AndersBroman1-2/+2
Change-Id: Ia586ef8ce500d5fc7578c52014206fa7a7eaea41 Reviewed-on: https://code.wireshark.org/review/1624 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-05-11Identify client/server by their IP address and port number in follow streams ↵Pascal Quantin1-3/+9
dialog box This allows to properly identify hosts that use the same port number Change-Id: I93bf5b53e4df1d339fb06b372b90f88fce6785a0 Reviewed-on: https://code.wireshark.org/review/1588 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-05-11Small fixes to Follow Streams dialog box:Pascal Quantin1-5/+5
- get the right IPv6 client address - display the right client to server string for UDP/SSL in Qt port Change-Id: I399cc38b8a32321198deccdd8e2ecd05b54e14db Reviewed-on: https://code.wireshark.org/review/1586 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-04-19More name changes.Guy Harris1-6/+6
Add ep_ to routines that may return ephemeral strings. Change "get_XXX" to "XXX_to_display" if the routine returns a formatted string if it can't get a name. Change-Id: Ia0e82784349752cf4285bf82788316c9588fdd88 Reviewed-on: https://code.wireshark.org/review/1217 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-03-21Add dot to stringAlexis La Goutte1-1/+1
And avoid different string for translation... Change-Id: I36ae0fd3366cb9b42f146163f4355778f0b9b40c Reviewed-on: https://code.wireshark.org/review/771 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte1-2/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-01-04Add tooltips for the total number of streams.Gerald Combs1-1/+8
svn path=/trunk/; revision=54585
2013-12-24add ssl detection to proto_get_frame_protocols()Martin Kaiser1-1/+1
svn path=/trunk/; revision=54439
2013-12-21fix warnings.Jakub Zawadzki1-0/+1
svn path=/trunk/; revision=54338
2013-11-23Create the ability to have packet scoped "proto" data. Bug 9470 ↵Michael Mann1-1/+1
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9470) I'm not sold on the name or module the proto_data functions live in, but I believe the function arguments are solid and gives us the most flexibility for the future. And search/replace of a function name is easy enough to do. The big driving force for getting this in sooner rather than later is the saved memory on ethernet packets (and IP packets soon), that used to have file_scope() proto data when all it needed was packet_scope() data (technically packet_info->pool scoped), strictly for Decode As. All dissectors that use p_add_proto_data() only for Decode As functionality have been converted to using packet_scope(). All other dissectors were converted to using file_scope() which was the original scope for "proto" data. svn path=/trunk/; revision=53520
2013-11-23Replace similar code with a common routine.Gerald Combs1-18/+1
svn path=/trunk/; revision=53519
2013-11-21Remove packet_info->ipproto and packet_info->ethertype uses in the GUI. ↵Michael Mann1-3/+22
Convert to walking packet protocol list looking for desired protocols. I may eventually switch this to use proto_* values instead of strings, but just the addition of the loop is more jarring as compared to the simple comparing of ip or ethernet values. But it should lead to a smaller (less protocol specific) packet_info structure. svn path=/trunk/; revision=53476
2013-11-19Print one YAML item per packet.Gerald Combs1-4/+7
svn path=/trunk/; revision=53439
2013-11-19fix compiler warning about write-only variableMartin Kaiser1-1/+2
svn path=/trunk/; revision=53426
2013-11-19#if 0 out an error check that wasn't doing anything interesting for anGuy Harris1-3/+5
error, and put in a pseudo-code call to stand in for error reporting code. Fix a signed-vs-unsigned comparison issue. svn path=/trunk/; revision=53422
2013-11-18Follow dialog data display improvements.Gerald Combs1-68/+89
Change the "Raw" character type to UTF-8. I'm not sure it's possible to show true raw data in a QTextEdit widget and calling it UTF-8 more accurately repesents what happens when you pass a char * to a QString. Add a YAML display. Hopefully Scapy users will find it useful. Sort the the character display items alphabetically. Make sure we go back to the top of the buffer when we change the direction or character set. Be less aggressive about setting focus on the "find text" entry. svn path=/trunk/; revision=53421
2013-11-18Remove duplicate (wireshark_application.h) and unused #include filesAlexis La Goutte1-3/+0
svn path=/trunk/; revision=53413
2013-11-15Reset data_out_file when we close it. Add comments and fixup whitespace.Gerald Combs1-8/+17
svn path=/trunk/; revision=53343
2013-11-15Apply the changes from r52506. Fixes bug 9044 for the Qt port.Gerald Combs1-79/+0
svn path=/trunk/; revision=53340
2013-11-15Add a "to do" item.Gerald Combs1-0/+4
svn path=/trunk/; revision=53335
2013-11-14Create a plural-only English translation. Use it to pluralize the FollowGerald Combs1-2/+3
Stream and Flow Graph hint statistics. svn path=/trunk/; revision=53326
2013-11-14Add packet information and selection to the Follow Stream dialog.Gerald Combs1-40/+107
Collect packet numbers when following streams so that we can correlate text positions with packets. Add a FollowStreamText class so that we can track mouse events. Add a hint label that shows the packet under the cursor along with packet counts and the number of "turns". Add the packet number to the C array dump. Note that dumping to YAML might be useful for Scapy users. svn path=/trunk/; revision=53314
2013-11-13Highlight selected sequence diagram items.Gerald Combs1-225/+276
Create a new dialog each time the user follows a stream. A lot of the follow code seems to assume one and only one dialog so there are likely outstanding bugs. Don't use the global cfile (should we deprecate its usage?). We want to move closer to multiple documents, not further away. Clean up after ourselves. Free our payload list and unlink our temp file. Make a bunch of gchar*s QStrings. Make sure our destructor gets called and use it. Make member variable and method names more consistent. svn path=/trunk/; revision=53306
2013-10-15Adjust parenthesis to make gcc happy.Gerald Combs1-1/+1
svn path=/trunk/; revision=52632
2013-10-15Add some missing parenthesis. Make sure we set our font in the right place.Gerald Combs1-18/+8
Make the ColorUtils::fromColorT() convenience function a little more convenient. Use it. svn path=/trunk/; revision=52620
generated by cgit v1.2.1 (git 2.18.0) at 2024-07-10 10:16:12 +0000