summaryrefslogtreecommitdiff
path: root/ui/win32
AgeCommit message (Collapse)AuthorFilesLines
2015-09-26Fix checkapi warningsGraham Bloice1-17/+17
Fix some (mostly spurious) checkapi warnings by renaming the offending variables. Change-Id: I7a43ac89f5ed35053a6526fa838fbad67669a49a Reviewed-on: https://code.wireshark.org/review/10655 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2015-04-16Minor Win32 console fix.Gerald Combs2-3/+3
Fix a no-op in set_has_console. Mark it and set_console_wait GTK+ only. Change-Id: Ifc6540b30edc0296c4a47c004a397cc309e71d2b Reviewed-on: https://code.wireshark.org/review/8099 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-02-09(Trivial) Fix printf-related 'Mismatch on sign' warningsBill Meier1-2/+2
Found by MSVC2013 Code Analysis Change-Id: I58063946dd558e98308c87b36eeac0ddbe1a6e79 Reviewed-on: https://code.wireshark.org/review/7045 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-01-18Fix another dfilter_compile() call.Guy Harris1-1/+1
Change-Id: I8b035a09b1bc1981a78a80e0a2547dce65a2ac9c Reviewed-on: https://code.wireshark.org/review/6609 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-01-12Remove emem APIs from UAT functionality.Michael Mann1-1/+4
Change-Id: I009c09f25d170e5c9aaaef713eaacb3252817856 Reviewed-on: https://code.wireshark.org/review/6460 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Evan Huus <eapache@gmail.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-01-08Small parenthesis fixDario Lombardo1-1/+1
Change-Id: I6bab238a37f7309daece7a7bfc062da41819d9ff Reviewed-on: https://code.wireshark.org/review/6394 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-01-02Add '*.nativecodeanalysis.xml' to 'clean' targetsBill Meier1-1/+1
Change-Id: I90dbf0b31fc737150a01533763a7869b34c68cb6 Reviewed-on: https://code.wireshark.org/review/6220 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2015-01-01Remove unneeded includes from ui folderMartin Mathieson2-11/+0
Change-Id: Ifd1eebff9080cd3867e44e4dcb2d2681370ed60a Reviewed-on: https://code.wireshark.org/review/6128 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
2014-11-30win32: use target file format when checking if it supports commentsPascal Quantin1-1/+1
Bug: 10656 Change-Id: Ib74f213630d6d382118c09b3cbf998b28cbc045e Reviewed-on: https://code.wireshark.org/review/5544 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-10-06Adjust some whitespace to match editor modelines.Bill Meier1-45/+45
Change-Id: Ia22cac3ebd7a454c156f98d967e6fd61f708a2b3 Reviewed-on: https://code.wireshark.org/review/4489 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2014-08-20In Visual Studio builds, enable the L4 warningGraham Bloice2-4/+0
4189: Local variable is initialized but not referenced Fix some variables found by this Change-Id: Icc13def5413f1fe885ec25e659462c8906a6cfa0 Reviewed-on: https://code.wireshark.org/review/3748 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com> Petri-Dish: Graham Bloice <graham.bloice@trihedral.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2014-05-23Revert "Allow wtap_read() and wtap_seek_read() to return non-packet records."Guy Harris1-23/+18
This reverts commit c0c480d08c175eed4524ea9e73ec86298f468cf4. A better way to do this is to have the record type be part of struct wtap_pkthdr; that keeps the metadata for the record together and requires fewer API changes. That is in-progress. Change-Id: Ic558f163a48e2c6d0df7f55e81a35a5e24b53bc6 Reviewed-on: https://code.wireshark.org/review/1741 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-05-23Allow wtap_read() and wtap_seek_read() to return non-packet records.Guy Harris1-18/+23
This is the first step towards implementing the mechanisms requestd in bug 8590; currently, we don't return any records other than packet records from libwiretap, and just ignore non-packet records in the rest of Wireshark, but this at least gets the ball rolling. Change-Id: I34a45b54dd361f69fdad1a758d8ca4f42d67d574 Reviewed-on: https://code.wireshark.org/review/1736 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-05-09Revert "Refactor Wiretap"Guy Harris1-3/+3
This reverts commit 1abeb277f5e6bd27fbaebfecc8184e37ba9d008a. This isn't building, and looks as if it requires significant work to fix. Change-Id: I622b1bb243e353e874883a302ab419532b7601f2 Reviewed-on: https://code.wireshark.org/review/1568 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2014-05-09Refactor WiretapMichael Mann1-3/+3
Start of refactoring Wiretap and breaking structures down into "generally useful fields for dissection" and "capture specific". Since this in intended as a "base" for Wiretap and Filetap, the "wft" prefix is used for "common" functionality. The "architectural" changes can be found in cfile.h, wtap.h, wtap-int.h and (new file) wftap-int.h. Most of the other (painstaking) changes were really just the result of compiling those new architecture changes. bug:9607 Change-Id: Ife858a61760d7a8a03be073546c0e7e582cab2ae Reviewed-on: https://code.wireshark.org/review/1485 Reviewed-by: Michael Mann <mmann78@netscape.net>
2014-04-03(Pedantic): set editor modelines tab-width & etc to 8; Also: fix some ↵Bill Meier1-3/+3
indentation in packet-sip.c Change-Id: I623fc5e4c1247dbe5e15f0f33270f4f0994268ab Reviewed-on: https://code.wireshark.org/review/943 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-03-31Continue to remove $Id$ from top of fileAlexis La Goutte2-2/+0
(Using sed : sed -i '/^\# \$Id\$/,+1 d') (start with dash) Change-Id: Ia4b5a6c2302f6a531f6a86c1ec3a2f8205c8c2dd Reviewed-on: https://code.wireshark.org/review/881 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-03-04Add a cast.Gerald Combs1-1/+1
Change-Id: Ib1885bcbe061942ecba55b90e6b1d9b20f033f41 Reviewed-on: https://code.wireshark.org/review/505 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2014-03-04win32: Implement format type selector in open file dialogMichal Labedzki2-2/+18
Change-Id: Idef1829fcc2b7b08783e5288bb6486ce19c4779b Reviewed-on: https://code.wireshark.org/review/405 Reviewed-by: Evan Huus <eapache@gmail.com> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2014-03-04Remove all $Id$ from top of fileAlexis La Goutte6-12/+0
(Using sed : sed -i '/^ \* \$Id\$/,+1 d') Fix manually some typo (in export_object_dicom.c and crc16-plain.c) Change-Id: I4c1ae68d1c4afeace8cb195b53c715cf9e1227a8 Reviewed-on: https://code.wireshark.org/review/497 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2014-02-25Remove trailing whitespaceBill Meier1-3/+3
Change-Id: I8116f63ff88687c8db3fd6e8e23b22ab2f759af0 Reviewed-on: https://code.wireshark.org/review/385 Reviewed-by: Bill Meier <wmeier@newsguy.com> Tested-by: Bill Meier <wmeier@newsguy.com>
2014-02-25Wireshark: Add option to choose format type of capture fileMichal Labedzki1-1/+1
The best heuristic can fail, so add possibility to manually choose capture file format type, so not correctly recognize file format can be loaded in Wireshark. On the other side now it is possible to open capture file as file format to be dissected. Change-Id: I5a9f662b32ff7e042f753a92eaaa86c6e41f400a Reviewed-on: https://code.wireshark.org/review/16 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com> Reviewed-by: Evan Huus <eapache@gmail.com> Tested-by: Evan Huus <eapache@gmail.com>
2014-01-26Drop support of Visual Studio 2005Alexis La Goutte1-4/+0
* Remove _MSC_VER < 1500 check * Cleanup config.nmake See http://www.wireshark.org/lists/wireshark-dev/201305/msg00159.html svn path=/trunk/; revision=54965
2013-12-15Fix warning found by doxygenAlexis La Goutte1-0/+9
svn path=/trunk/; revision=54130
2013-12-13Fix Visual Studio Code Analysis warning C6011: Dereferencing NULL pointer ↵Chris Maynard1-0/+8
'returnedDevmode' svn path=/trunk/; revision=54051
2013-12-13Fix Visual Studio Code Analysis warning C6001: Using uninitialized memory ↵Chris Maynard1-2/+2
'keylist' svn path=/trunk/; revision=54050
2013-12-01Patch to include YAML export. Bug 9452 ↵Michael Mann1-1/+1
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9452) From Deon van der Westhuysen From me: use switch statements instead of if-else svn path=/trunk/; revision=53698
2013-11-29Stats_tree enhancements for sorting, averages and burst rate. Bug 9452 ↵Michael Mann2-0/+98
(https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9452) From Deon van der Westhuysen - Bug fix: object leak in stats_tree after a tap reset (for example apply statistics preferences with a stats_tree window open) - Bug fix: correct sample code in README.stats_tree - Add: slash in plug-in name now creates submenu as docs describe (was a bug?) - Add: menu separator before the stat_tree registered plug-ins - Add: stats_tree can now calculate averages for nodes; automatically calculated for range nodes. Add section in README.stats_tree describing averages. - Add: stats_tree can now calculate burst rate of each node (like rate but with a shorter, sliding time window) - Add: sorting for stats_tree plug-ins. Can sort on node name, count, average, min, max values and burst rate. - Add: preferences for stats_tree system (default sort column, burst calc params) - Add: stats_tree window copy to clipboard and export and plain text, csv and XML. - Added sample of new functionality in $srcdir/plugins/stats_tree/pinfo_stats_tree.c - Moved all stats_tree sample plug-ins to "IP Statistics" submenu. svn path=/trunk/; revision=53657
2013-11-17Move the epan/filesystem.c routines to wsutil; they're not specific toGuy Harris1-1/+1
packet dissection, they're specific to the entire Wireshark suite of programs. svn path=/trunk/; revision=53377
2013-11-08Indentation tweaks.Guy Harris1-3/+4
svn path=/trunk/; revision=53173
2013-11-08Didn't need to include wtap.h againMartin Mathieson1-1/+0
svn path=/trunk/; revision=53171
2013-11-08Fix up function names: type -> type_subtypeMartin Mathieson1-4/+5
svn path=/trunk/; revision=53170
2013-11-08Fix more errors.Guy Harris1-3/+2
svn path=/trunk/; revision=53159
2013-11-08Wrong function.Guy Harris1-1/+1
svn path=/trunk/; revision=53158
2013-11-08Fix errors.Guy Harris1-1/+1
svn path=/trunk/; revision=53157
2013-11-08For open dialogs, offer a list of sets of extensions, not of file types;Guy Harris1-45/+82
.cap, for example, doesn't refer to a particular file type - a whole bunch of file types use .cap. Also offer, in addition to "All Files", "All Capture Files", which matches all the extensions we know about. svn path=/trunk/; revision=53156
2013-10-21Tentative fix for https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9287 :Pascal Quantin1-0/+1
Initialize ofn->lCustData variable svn path=/trunk/; revision=52740
2013-10-20From RobiOneKenobi via ↵Pascal Quantin1-165/+68
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9297 : Add support for MSVC2013 svn path=/trunk/; revision=52716
2013-10-15Make sure we have a valid capture file pointer in win32_export_file().Gerald Combs1-0/+3
Fixes bug 9271. svn path=/trunk/; revision=52612
2013-10-11Remove GTK+ and global cfile dependencies from file_dlg_win32.c.Gerald Combs2-42/+55
Move the declaration of set_last_open_dir() to ui/util.h. It still has separate GTK+ and Qt implemenations. We might want to move it to ui/util.c at some point. Remove a lot of unnecessary GTK+ includes. Remove most of the references to the global cfile while we're at it. svn path=/trunk/; revision=52542
2013-09-26When a line of text wraps to the next line, the character that caused the ↵Chris Maynard1-2/+1
line to wrap was not being printed. #BACKPORT(1.10,1.8) svn path=/trunk/; revision=52221
2013-08-23For the Windows Open dialog for capture files, get rid of the "(*.*)" inGuy Harris1-5/+54
the "All Files" entry (the current UI guidelines from Microsoft say to do so, and that's what Paint does, at least), and add an "All Capture Files" entry with all the file extensions for the file types we support (it'll pick up all text files, but there's not much we can do about that, and it won't pick up files with *no* extension or weird extensions, such as you might get from UN*X systems or from WinDump commands, but at least it'll filter out some other crud). Fix what appear to be memory leaks; that should be backported unless I've missed something and they aren't leaks. Fix an out-of-date comment, and add an additional comment. svn path=/trunk/; revision=51481
2013-07-16Move merge.{h,c} into wiretap: these modules use wiretap to merge files.Jeff Morriss1-3/+5
svn path=/trunk/; revision=50656
2013-07-14Fix whitespace.Guy Harris1-1/+1
svn path=/trunk/; revision=50572
2013-07-12Move the print modules into epan.Jeff Morriss1-1/+1
svn path=/trunk/; revision=50526
2013-06-19Allow for column headers not to be printed in order to make it possible to ↵Chris Maynard2-8/+22
export packets as plain text in a format that could then have a chance of being imported again (assuming other factors such as packet bytes were printed, etc.) in order to recover the original pcap file. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1636 svn path=/trunk/; revision=50036
2013-06-15Make use of text metrics and devmode data to properly format a page for ↵Chris Maynard1-161/+183
printing. Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7543 #BACKPORT(1.10,1.8) svn path=/trunk/; revision=49946
2013-06-04The CommDlg_OpenSave_GetFilePath macro fetches the path+name of the mostGerald Combs1-36/+26
recently selected file in the current file dialog. This isn't the proper routine to use when trying to figure out the save/export file name. We have to dig through the OPENFILENAME struct instead. Fixes bug 8224. #Backport 1.10 svn path=/trunk/; revision=49765
2013-04-27Fix a comment (the "it worked but didn't pop up a window" conclusionGuy Harris1-3/+3
came from a bad test). svn path=/trunk/; revision=49070
2013-04-27Update comments.Guy Harris1-4/+3
svn path=/trunk/; revision=49069