summaryrefslogtreecommitdiff
path: root/ui
AgeCommit message (Collapse)AuthorFilesLines
2016-02-20autotools: Use Qt flags only for building Qt GUIJoão Valverde1-1/+1
Change-Id: I041e2fab6de948c803cc059e78358077000efee8 Reviewed-on: https://code.wireshark.org/review/14006 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-02-20Qt: only "Comment" column should be editable in Local Interfaces management tabPascal Quantin2-1/+12
Bug: 12146 Change-Id: Ife481b7c0b201a54749e212416571aa3dcaf7542 Reviewed-on: https://code.wireshark.org/review/14017 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-02-20Qt: Set maximumSize on AccordionFrame widget buttonsStig Bjørlykke2-0/+24
After switching to QPushButton for buttons in SearchFrame and GoToFrame the widgets needs a maximum size to reduce the height of the frame. Change-Id: I504e65add446c4262e9b1e02ff3e41c08d1cfdfd Reviewed-on: https://code.wireshark.org/review/14019 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-02-19Qt: Fix Open protocol preferences button.Stig Bjørlykke1-1/+1
Do showProtocolPreferences before removing the variable which this depends on. The button does not work without at module. Change-Id: I7d31aa5ab19340a4102523b13de961e799cae5e4 Reviewed-on: https://code.wireshark.org/review/14015 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-02-19Qt: Update AccordionFrame widgets to use common layoutStig Bjørlykke11-23/+67
- Use QPushButton for buttons and set the "Find" button as default in SearchFrame. - Use QPushButton for buttons, added a "Packet:" label, and set the "Go to packet" button as default in GoToFrame. - Set Qt::WA_MacSmallSize in OS X for FilterExpressionFrame and PreferenceEditorFrame. - Removed QFrame::StyledPanel and QFrame::Raised from ColumnEditorFrame. - Update ui files to reflect that AccordionFrame is used for AddressEditorFrame, FilterExpressionFrame and PreferenceEditorFrame. Change-Id: Icfbfff973535317997109a1020dfe24ba932e098 Reviewed-on: https://code.wireshark.org/review/13995 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-02-18Another include that needs fixing.Guy Harris1-1/+1
Change-Id: If06ba1bd887e0e47d74c9b75cbabedcfd7b84130 Reviewed-on: https://code.wireshark.org/review/13991 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-02-18Don't add the wiretap directory to the list of include directories.Guy Harris35-49/+47
If you include something from the wiretap directory, always precede it with wiretap/. Fix some includes of files in the top-level directory to use a path relative to the current directory, not relative to the wiretap directory. This makes it a bit clearer what's being included. Change-Id: Ib99655a13c6006cf6c3112e9d4db6f47df9aff54 Reviewed-on: https://code.wireshark.org/review/13990 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-02-18Qt: Add regex support in Find PacketStig Bjørlykke4-9/+71
Add support for using regular expressions in the Search Frame when searching in packet list, packet details and packet bytes. This search is in many cases faster than plain string search. Change-Id: I2d8a709046f90d7b278fb39547fc4e2e420623bc Reviewed-on: https://code.wireshark.org/review/13981 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-02-17Qt: Validate FindLineEdit regexpStig Bjørlykke2-1/+33
Check if regexp is valid and set valid/invalid background color. Change-Id: Ibf4d3fa84463afbd7c68631cfaddec8261807b8f Reviewed-on: https://code.wireshark.org/review/13962 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-02-16Cast away a warning.Guy Harris1-1/+1
The argument to the resize method for QByteArray is an int, not a size_t. Change-Id: Id30bc03daec6d6ead8669794b5cb0247718be66b Reviewed-on: https://code.wireshark.org/review/13977 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-02-16Qt: Add Decode as in Show Packet BytesStig Bjørlykke5-75/+438
Add an option to decode the packet bytes from base64 or zlib compressed. Also add configurable start byte and end byte to make it possible to decode a subset of bytes. It's also possible to select a range in ASCII view and select "Show selected" from the context menu to make a subset. In ASCII view a null terminator is replaced by UTF8 symbol for NULL, and a CR is replaced by UTF8 symbol for carriage return. This is done to make it possible to "Show selected" from the context menu. Change-Id: Ie03c9912c304c121af6ca9e998a6e8445b5382c5 Reviewed-on: https://code.wireshark.org/review/13958 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-02-16const gpointer -> gconstpointerJoão Valverde7-18/+18
'const gpointer' is the same as 'void *const'. Replace with gconstpointer where straightforward (assuming that was the intent) and use gpointer everywhere else for clarity (that does not change *API* constness contract; it just means a variable is not declared immutable inside the called funtion). Change-Id: Iad2ef13205bfb4ff0056b2bce056353b58942267 Reviewed-on: https://code.wireshark.org/review/13945 Petri-Dish: Anders Broman <a.broman58@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-15Qt: Add FindLineEdit with regex search optionStig Bjørlykke11-6/+211
Add settings to the QLineEdit context menu to use textual or regular expression search. Use this in Follow Stream and Show Packet Bytes. Change-Id: I3a9f5a923f616629aa40a334921871f98b518f30 Reviewed-on: https://code.wireshark.org/review/13942 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-02-14tango_color(.h): avoid ‘tango_butter_3’ defined but not used ↵Alexis La Goutte1-0/+7
[-Werror=unused-const-variable] found by gcc6 Change-Id: I5500c7228003358421d2aa40808213ef739e765b Reviewed-on: https://code.wireshark.org/review/13906 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-02-14[Automatic update for 2016-02-14]Gerald Combs14-344/+1083
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I85afd74e86c8e38f9ddc73ec92c26d7f24776743 Reviewed-on: https://code.wireshark.org/review/13938 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-02-12tap-iostat: fix logical ‘or’ of equal expressions [-Werror=logical-op] ↵Alexis La Goutte1-1/+1
found by gcc6 Change-Id: Ic10ba8df57ae69994f7ac0e6ddbdec92af797fc8 Reviewed-on: https://code.wireshark.org/review/13920 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-02-11Qt: Add Show as C Array and YAML in Show Packet BytesStig Bjørlykke2-8/+75
Change-Id: Ib9ccd72128f55741d4c94cf849f8e0f8866c2cb7 Reviewed-on: https://code.wireshark.org/review/13907 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-02-11Qt: Add hint label in Show Packet BytesStig Bjørlykke3-2/+121
Show frame number, field name (abbrev) and number of bytes. Added some translations. Change-Id: I9777d43d63a52fcdb221864bad097a9604522d3a Reviewed-on: https://code.wireshark.org/review/13888 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-02-11extcap: Convert settings to preference friendly key namesMikael Kanstrup3-7/+6
Preferences are only allowed to contain lowercase ASCII letters, numbers, underscores or dot characters. Create a utility function to convert an extcap setting to its equivalent preference key and use it wherever conversion from setting to preference key is needed. Bug: 12064 Change-Id: I39bbac7de5f0f905bd41c54257fa997a3b32442d Reviewed-on: https://code.wireshark.org/review/13687 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-02-10Qt: fix jitter buffer managementPascal Quantin2-5/+5
Small bugs were introduced when copy/pasting the code from GTK UI: - arrive_offset is stored in seconds and not milliseconds - some tests regarding the current playback mode were wrong Change-Id: I21fb82ba8ff6c8defa7df90c815c040e9e074aaa Reviewed-on: https://code.wireshark.org/review/13885 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-02-10Qt: Fix plural translationsStig Bjørlykke3-19/+24
Change-Id: I17df0c0a3462b7ccdda2105204c0ad72e80fc175 Reviewed-on: https://code.wireshark.org/review/13882 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-02-10Qt: Align hex dump text in follow streamStig Bjørlykke1-1/+1
Put some extra spaces between hex and text output in follow stream hex dump to align with the layout used in ByteViewText. Change-Id: Ie2743ccf46a8941595580878955e96b9ada56de9 Reviewed-on: https://code.wireshark.org/review/13867 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-02-10Qt: Add Show as Hex Dump in Show Packet BytesStig Bjørlykke2-0/+50
Change-Id: I81a42ef263d87880cfe0d1230dbbcb692e473d6f Reviewed-on: https://code.wireshark.org/review/13868 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-02-09Properly check the return value of color_filters_set_tmp().Guy Harris1-1/+1
It returns FALSE, not TRUE, on failure. Bug: 12101 Change-Id: I2fb4f407d2040e7b84f17af197de81555d64c647 Reviewed-on: https://code.wireshark.org/review/13857 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-02-08QCP: Fix retina label calculations.Gerald Combs1-8/+16
The retina fixes in gb10bad1 and gb3f3d66 were incomplete and caused rendering problems in our axis labels. Handle the device pixel ratio in a couple of more places so that our axis rects are correctly sized. Add a switch (WS_ENABLE_DP_RATIO) to make it easy to turn scaling on and off. Change-Id: I633d94d633e0743be2a607c9a4cbb3409e9eed62 Ping-Bug: 11710 Reviewed-on: https://code.wireshark.org/review/13834 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-02-08Qt: Restore sequence diagram labels, other fixes.Gerald Combs2-2/+10
SequenceDiagram implements time, address, and comment labels using QCPAxis::setTickVector and QCPAxis::setTickVectorLabels. It also calls QCPAxis::setTicks(false) so that we don't draw tick marks. It appears that doing so also disables the labels themselves in our current version of QCP. Set the tick pen to Qt::NoPen instead. Only draw node lines where we have nodes. Add notes about a retina issue and the need for zooming. Bug: 11710 Change-Id: I88c30a1ddcd29832f86b1ca8c018c7fa6b6d64a7 Reviewed-on: https://code.wireshark.org/review/13781 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-02-08Qt: Add Show Packet Bytes DialogStig Bjørlykke13-0/+607
Show selected packet bytes as ASCII, HTML, Image, ISO 8859-1, Raw or UTF-8. Images supported are what's supported by QImage, and HTML supported is what's supported by QTextEdit. Change-Id: I96fc5c5d222c5389078576463cf78d82cf55528d Reviewed-on: https://code.wireshark.org/review/13807 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-02-08Revert "Add free_address_wmem() and other extensions to address API"João Valverde10-33/+57
This reverts commit 13ec77a9fc3af3b0b502820d0b55796c89997896. This commit introduces a segmentation fault for Lua code (uncovered by the test suite). Change-Id: Ibc273d1915cda9632697b9f138f0ae104d3fb65e Reviewed-on: https://code.wireshark.org/review/13813 Reviewed-by: João Valverde <j@v6e.pt>
2016-02-07Add free_address_wmem() and other extensions to address APIJoão Valverde10-57/+33
Try to improve 'address' API (to be easier/safer) and also avoid some constness warnings by not overloading the 'data' pointer to store malloc'ed buffers (use private pointer for that instead). Change-Id: I7456516b12c67620ceadac447907c12f5905bd49 Reviewed-on: https://code.wireshark.org/review/13463 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-02-07GTK: Check if lrint() is usable, fix warnings [-Wbad-function-cast]João Valverde2-62/+70
Change-Id: I4714ba6cfbd18847d99650f5c5cdc60dd2e7af26 Reviewed-on: https://code.wireshark.org/review/13808 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-02-07[Automatic update for 2016-02-07]Gerald Combs13-340/+261
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: If7d44f7c40a98454261f9f71ce7e084a16b5add7 Reviewed-on: https://code.wireshark.org/review/13799 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-02-05Qt: Add check for field extractorsStig Bjørlykke1-2/+3
The proto tree is needed in several cases when using Lua field extractors, because they fetch values from the tree. Without a valid field extractor a Lua plugin may misbehave and display wrong column info. This fixes column issues when: - Calling resetColumns() in Qt. This involves adding a display filter, change time display format, change name resolution and other changes in UI which requires column updates. - Print summary lines. - Export as CSV and PSML. Change-Id: Ieed6f8578cdf2759f1f836cd8413a4529b7bbd80 Reviewed-on: https://code.wireshark.org/review/13708 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-05Qt: Reset columns before auto resize time columnsStig Bjørlykke1-9/+11
When changing timestamp format, timestamp precision and display seconds with hours and minutes we must reset columns before auto resizing the time columns to get the size of the new column values. Without this we will resize to the length of the preference we are changing from, which is not what we want. Change-Id: If7081bf0b9b6f6974232cea0b3fe0186c904f2a2 Reviewed-on: https://code.wireshark.org/review/13711 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-04[text2pcap] Fix parsing of hash sign at the end of the lineVasil Velichckov1-4/+4
Change-Id: I4ff1ef28aba353fd7548cb5c0603fc29479aa854 Reviewed-on: https://code.wireshark.org/review/13294 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-04Fix memleaks related to get_dirnamePeter Wu3-13/+13
get_dirname may return NULL instead of the original string, so avoid patterns like get_dirname(strdup(x)). Writing to cf_path.toUtf8().data() is fine btw, toUtf8() returns new memory. This fixes two memleak reported by LeakSanitizer via fileset_add_dir and MainWindow::captureFileReadFinished (both via cf_callback_invoke). Change-Id: I0f1528763e77e1f55b54b6674c890a9d02302ee8 Reviewed-on: https://code.wireshark.org/review/13691 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-02-03Fix Qt4 moc option argument and add build parametrizationJoão Valverde2-3/+3
Change-Id: Ib758f0eabaf96f9c6010201e7e16147fcfa0daa2 Reviewed-on: https://code.wireshark.org/review/13671 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Michal Labedzki <michal.labedzki@tieto.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-02-02Display Filter Expression dialog updates.Gerald Combs1-5/+6
De Morganize an expression. Clear the selection at start. Selecting the first item (104apci) seems to confuse people. Change-Id: I8fcd1f068f1801042a2658940175b46bdfb2b462 Reviewed-on: https://code.wireshark.org/review/13647 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-02-02Qt: Make moc less chattyJoão Valverde2-3/+5
Change-Id: Ide644647271663517ddc6a84ffe61d58dabd6bd2 Reviewed-on: https://code.wireshark.org/review/13629 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-02-01main_toolbar: fix redundant redeclaration of ‘cfile’ [-Wredundant-decls]Alexis La Goutte1-2/+0
Change-Id: I25d88852f87fdd8f760f29f9e5fdeb7a63391b87 Reviewed-on: https://code.wireshark.org/review/13636 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: João Valverde <j@v6e.pt>
2016-02-01extcap: Correct save for file argumentsRoland Knall1-3/+17
Also add check to has_configuration Change-Id: Ia0ffbd3bf68ad51c26bc75b5ee179db179e22bd4 Reviewed-on: https://code.wireshark.org/review/13635 Reviewed-by: Roland Knall <rknall@gmail.com>
2016-02-01extcap: Add Save functionality to options dialogRoland Knall6-5/+172
This patch creates the functionality of saving all parameters for extcap devices in the general preference section. For now, multiselect and fileselect do not save their values but patches for this will be provided in the future Also, all preferences are stored as strings to make handling easier. This might change in the future, but for the first version it will stick. Restore to Defaults is not implemented as of yet, and will be in a future version, once the preference storing is finalized Bug: 11666 Change-Id: I178346405146d2e43f4f3481c05c92c0b3595af5 Reviewed-on: https://code.wireshark.org/review/13451 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-01-31[Automatic update for 2016-01-31]Gerald Combs13-1370/+1647
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I7e8ade92cce819240ee8e40cfc63363185d9d944 Reviewed-on: https://code.wireshark.org/review/13625 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-01-31Switch from QLibrary to ws_load_library.Gerald Combs2-14/+5
From the comments in qlibrary_win.cpp: // We make the following attempts at locating the library: [ ... ] // Windows // if (absolute) // fileName // fileName + ".dll" // else // fileName + ".dll" // fileName We were passing "riched20.dll" to QLibrary, which meant that it searched for "riched20.dll.dll" first. Switch to ws_load_library, which we use elsewhere and which has much safer default behavior. Change-Id: Ic8f0cf5686c9b1856d37e76be4404d6236c076e5 Reviewed-on: https://code.wireshark.org/review/13607 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-31RLC LTE: upgrade dissector to v13.0.0Pascal Quantin1-3/+3
Change-Id: Ibe4586925ffe49f5aaab72956c40e123855a1a1e Reviewed-on: https://code.wireshark.org/review/13620 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-01-30Update filter bookmark icons.Gerald Combs2-4/+4
Separate the capture and display filter bookmark icons. Make the capture icon green to match(-ish) the active capture icon. Tested on nice+new and janky+old displays. Change-Id: I6ed532c8a49da50fe2a7de3d8fbd0b1af7623b4a Reviewed-on: https://code.wireshark.org/review/13612 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-01-29Qt: No capture filter bookmarks in capture interfaces listStig Bjørlykke3-4/+4
Change-Id: I4f53758c0fa4448656daac3ad186a6b0e687fc5c Reviewed-on: https://code.wireshark.org/review/13593 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-01-28Qt: Enable capture filter bookmarksStig Bjørlykke6-13/+167
Update the code handling capture filter bookmarks and enable the bookmark button and clear button in CaptureFilterEdit(). Disable the apply button (which starts a capture) for now. Bug: 11836 Change-Id: Ia33cbb8c9bb839be037112eef26daf744c4ea8f8 Reviewed-on: https://code.wireshark.org/review/13568 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-01-28Qt: Update display filter bookmarks when list changedStig Bjørlykke5-26/+79
Recreate the display filter bookmarks menu only when the list has changed, not every time the display filter changes. The list changes when removing an entry from the menu and when changing the list in the "Manage Display Filters" dialog. Save the list when removing an entry from the menu. Change-Id: Icd08e0a80085cca55c0e63177d45abe4902c7c3e Reviewed-on: https://code.wireshark.org/review/13567 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-01-28autotools: Don't use "user variables" to set build flagsJoão Valverde4-48/+15
GNU coding standards recommend against it and automake is designed around it. This allows overriding the global build flags using AM_CFLAGS, etc., or per object flags, something that is difficult or impossible currently because of automake precedence rules. Change-Id: I3f1ea12e560af5a46b2f04b342b1882bbf123f12 Reviewed-on: https://code.wireshark.org/review/13455 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-01-28extcap: Cleanup complex types and add save optionRoland Knall7-100/+84
Cleanup handling of complex data types and use only glib defined datatypes while handling argument values. Add a save parameter, which (additionally) can set, that a parameter is not saved in a configuration file. Passwords are by default not saved, which may be overwritten using this parameter Change-Id: I67eff0f3286170f082d532e806a39511c40df647 Reviewed-on: https://code.wireshark.org/review/13573 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com>
generated by cgit v1.2.1 (git 2.18.0) at 2024-07-03 23:39:31 +0000