summaryrefslogtreecommitdiff
path: root/ui
AgeCommit message (Collapse)AuthorFilesLines
2016-10-22On UN*X, st_ctime is the last status change time, not the creation time.Guy Harris2-11/+31
That's the time the file's inode last changed, so size changes, permission changes, etc. affect it. It's *not* the time the file was created; most UN*Xes don't provide that. Newer versions of FreeBSD, NetBSD, OpenBSD, and macOS do, but other UN*Xes don't appear to. On Windows, at least according to Microsoft's documentation, st_ctime *is* the creation time. Hopefully that's not the result of confusion on the part of somebody at Microsoft. Change-Id: I20743703f6ef66e40dff9004dc91bed46af6fad0 Reviewed-on: https://code.wireshark.org/review/18378 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-10-22Fix some errors from the previous commit.Guy Harris2-2/+2
Pro tip: if you're modifying GTK+ code, make sure you explicitly configure to build the GTK+ version. Change-Id: Ia24321a5037dff67d9acf1444fa0b74f5aed089e Reviewed-on: https://code.wireshark.org/review/18371 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-10-22More checks for localtime() and gmtime() returning NULL.Guy Harris11-126/+195
And some comments in the case where we're converting the result of time() - if your machine's idea of time predates January 1, 1970, 00:00:00 UTC, it'll crash on Windows, but that's not a case where a *file* can cause the problem due either to a bad file time stamp or bad time stamps in the file. Change-Id: I837a438e4b875dd8c4f3ec2137df7a16ee4e9498 Reviewed-on: https://code.wireshark.org/review/18369 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-10-22localtime() can return NULL, even if it's unlikely.Guy Harris1-1/+4
ANSI C says it can return NULL - and, at least on Windows with the MSVC library, it *will* return null for dates prior to the Epoch. Check for a null return and handle it. Fixes CID 1374109. Change-Id: Ib18566d1a75e4109adb21834b157e87532fcac10 Reviewed-on: https://code.wireshark.org/review/18365 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-10-21Fix build for Qt 4.8Michal Labedzki2-3/+25
setCurrentText is only available in Qt5, so select the item manually. https://doc.qt.io/qt-5/qcombobox.html#currentText-prop Fixes: v2.3.0rc0-1002-g1cd2255 ("Qt: convert UatDialog to model/view pattern, improve UX") Change-Id: I402e7d159d512e870849ee54d851276c4cc7cf34 Reviewed-on: https://code.wireshark.org/review/18351 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-10-21Qt: fix weird tree expander that results in a crashPeter Wu1-3/+12
According to the Qt documentation, rowCount and columnCount must return 0 when a valid parent index is passed to a table model. Otherwise deep recursion would occur resulting in a stack overflow in Qt4. Change-Id: I60bb15384470861013591e149c0f285ea1bdf9a7 Fixes: v2.3.0rc0-1002-g1cd2255 ("Qt: convert UatDialog to model/view pattern, improve UX") Reviewed-on: https://code.wireshark.org/review/18354 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-10-21WelcomeUI: Enhance Open and Capture clickable labelsJaap Keuter1-0/+15
Open and Capture are now clickable labels, but they are sensitive throughout the whole width of the central column. Without background highlighting, as in the file list, this may be non-intuative. To more closely resemble a button, limit the sensitivity to the text of the label only, by limiting the label size. Change-Id: I0b703af02abc71a48dfbcee81f336bba955b4a70 Reviewed-on: https://code.wireshark.org/review/18349 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-10-20InterfaceList: Add button to toggle hidden interfacesRoland Knall4-1/+30
Add a button to the context menu, to allow for easy display of hidden interfaces, and make that a storable preference Change-Id: I8df5562b3ce8119b0ed38f9893c1879127f40c47 Reviewed-on: https://code.wireshark.org/review/18005 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-10-20Qt: remove unused private member (found by clang).Dario Lombardo1-1/+0
Error: ui/qt/wlan_statistics_dialog.cpp:462:9: error: private field 'retry_packets_' is not used [-Werror,-Wunused-private-field] Change-Id: I10785eab098db14a53ef8085421c0f1046c269f3 Reviewed-on: https://code.wireshark.org/review/18337 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-20Fix compilation error without PCAP (using correct define)Mikael Kanstrup1-1/+1
Incorrect define HAVE_PCAP was checked for. That one was never set even with PCAP enabled and thus broke the wireless toolbar functionality. Change-Id: I856c836de75b198340661d5e5b734c7d8ada70ac Reviewed-on: https://code.wireshark.org/review/18335 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-20wlan_statistics_dialog (Qt): Add percent of retryAlexis La Goutte1-12/+21
Change-Id: I1b77805d0bb71cda0ba8296f88854eec7111eff4 Reviewed-on: https://code.wireshark.org/review/18307 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-20Qt/Bluetooth: Add Mark/Unmark functionalityMichal Labedzki12-10/+291
Add Mark/Unmark functionality for tree/table widget items, user can now mark row or cell. Change-Id: I31b9ca128d97da4fb959ae2d92f5c1646ebea478 Reviewed-on: https://code.wireshark.org/review/18266 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-20WelcomeUI: Make Open and Capture clickableRoland Knall9-4/+165
Make the texts "Open" and "Capture" clickable, and have them open the FileOpen and CaptureOptions dialogs respectively Change-Id: I2a3efbc4cdf160aa0b4efc6496d09228affbff46 Reviewed-on: https://code.wireshark.org/review/18303 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-20Officially require Qt 4.8 or newerPeter Wu4-18/+0
Since v2.3.0rc0-1002-g1cd2255, Qt 4.8 became mandatory, reflect this in the version requirements. This will not affect a lot of distributions (RHEL and SLES only had Qt 4.6). For a more complete list of supported platforms, see https://wiki.wireshark.org/Development/Support_library_version_tracking While at it, correct some other minimum versions in documentation. Change-Id: I11f2dfba72c75429f6838404a81ed3b3dc302d5f Reviewed-on: https://code.wireshark.org/review/18314 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Petri-Dish: Anders Broman <a.broman58@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-20wlan_statistics_dialog: Add number of retryAlexis La Goutte1-11/+32
Change-Id: I27194670dcd2e6c2ec6502c562e50ee6925c4c45 Reviewed-on: https://code.wireshark.org/review/18306 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-19InterfaceList: Changing text clears the cellRoland Knall1-1/+1
If the cell is double-clicked to edit an existing text, it is cleared upon start of the edit widget Change-Id: I9d718635de5c4b091aab1f88c2482434aaae1286 Reviewed-on: https://code.wireshark.org/review/18319 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-19Qt: add include to fix compilation without pcap.Dario Lombardo1-0/+1
Regression introduced in 864f750be560a7a739c7453f19a8f5679cf7d6b3. Change-Id: I306903e8252d932425f420e1901a8f3e949f5568 Reviewed-on: https://code.wireshark.org/review/18309 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-19Qt: declare one_em to fix compile error when HAVE_PCAP_REMOTE is definedHessam Jalali1-0/+1
Occured on Windows(10) x64 build. Change-Id: I04d88bec1660dae20f459d2e03c88864c9366dc3 Reviewed-on: https://code.wireshark.org/review/18315 Reviewed-by: Roland Knall <rknall@gmail.com>
2016-10-19InterfaceTree: Change foreach to const_iteratorRoland Knall3-18/+37
Change all occurences of the foreach macro to while loops with const_iterator for performance reasons Change-Id: I1cd378696136b3d6cc100b9bfff95295baa2ff83 Reviewed-on: https://code.wireshark.org/review/18286 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-19ManageInterfacesDialog: Implement View/Data ModelRoland Knall9-241/+456
Implement the same interface view/data model as used for the interface_tree selection in this dialog, to encapsulate all access to global_capture_devices from the dialog. Change-Id: I0e568fe236d077befa2a79765638db8bb3ed1a3f Reviewed-on: https://code.wireshark.org/review/18062 Petri-Dish: Roland Knall <rknall@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-18Rename a function to have a name different from a data object's name.Guy Harris1-2/+2
Change-Id: Iefef8b2161b43900fd81fb1b163a4feee69fd069 Reviewed-on: https://code.wireshark.org/review/18285 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-10-18Fix wrong local function namesMichal Labedzki1-6/+6
Copy->Paste issue. Change-Id: I77bc755c772df0fb95a9e4ce91b8b3bc8a8e019d Reviewed-on: https://code.wireshark.org/review/18282 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-18WiresharkApplication: Add signal emitter for Interface ChangesRoland Knall2-0/+4
Change-Id: I468ef9462aa91d02c5568cec0d08081a2b3840bb Reviewed-on: https://code.wireshark.org/review/18269 Petri-Dish: Roland Knall <rknall@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-10-18Qt: Main welcome show/hide interface updates.Gerald Combs2-61/+43
Pluralize the text in the main welcome show/hide interfaces button. Remove the styling, which matches other places we use a pushbutton + menu. Change-Id: I7559f98d0c1afbfb2920b09c3885d9b1fbdf76f1 Reviewed-on: https://code.wireshark.org/review/18260 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-10-17InterfaceList: Change Buttons to comboboxRoland Knall8-97/+118
Change the buttons to a combobox selector, and move that selector to the right of the capture filter box. Bug: 12971 Change-Id: Ib85d51cca128ed76eb08886e92660ede51d5982f Reviewed-on: https://code.wireshark.org/review/18186 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-10-17Some get rid of the remaining trivial Q_UNUSED cases.Joerg Mayer2-14/+11
Fix the placement of Q_UNUSED inside #ifdef Change-Id: I015ff87fcb300a701bf8ccb42bd85e3068a08138 Reviewed-on: https://code.wireshark.org/review/18228 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-10-17Get rid of the trivial Q_UNUSED casesJoerg Mayer1-76/+33
Change-Id: Ia7ddde278158f3321eb4244189375bdd51c8976d Reviewed-on: https://code.wireshark.org/review/18227 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-10-16[Automatic update for 2016-10-16]Gerald Combs7-62/+96
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I016f035d04c44a68163ea0670e27fa454f4ba660 Reviewed-on: https://code.wireshark.org/review/18217 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-10-16Inspired by prevous commit: grep for wlan_mgt turned up a few more ↵Joerg Mayer2-4/+4
occurrences. Fix them. Change-Id: I6661f483f7bf1e34c96467917358dbddf45f808e Reviewed-on: https://code.wireshark.org/review/18216 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2016-10-14UI: Free up the -m flag.Gerald Combs1-4/+0
The -m (monospace font) flag was deprecated in 2.2. Go ahead and remove it in 2.3 / 2.4. Change-Id: I6b4911174675cedec979621c2776353314e73eb1 Reviewed-on: https://code.wireshark.org/review/18193 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-13Qt+macOS: Fix the default font name.Gerald Combs1-2/+8
"SF Mono" is the name of the new monospace font in Sierra. Note that it appears to have limited availability and that we're outside those limits. Fix up a comment. Change-Id: I97f0077098ea78d4550b58fb92645f4d62342b2e Reviewed-on: https://code.wireshark.org/review/18168 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-10-13Fix compilation error without PCAP.Dario Lombardo1-1/+1
Change-Id: I414f11387ec5a48dfe7c1debb3bcef1dbc846b28 Reviewed-on: https://code.wireshark.org/review/18184 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-13Interface List: Fix display of zero entriesRoland Knall5-12/+42
If WS is started with zero entries, no text is being displayed, and pushing a button does not yield the display of the list. This fixes it. Change-Id: I70b0637e5f95e805b54780afb7eb2e43b3e5f21c Reviewed-on: https://code.wireshark.org/review/18180 Petri-Dish: Michael Mann <mmann78@netscape.net> Reviewed-by: Roland Knall <rknall@gmail.com> Tested-by: Roland Knall <rknall@gmail.com>
2016-10-12MTP3: Added SS7 Point Code Name ResolutionBinh Trinh1-1/+2
bug: 7592 Change-Id: I1af2c5d6664e172c358cd19bc20e9352c2582eae Reviewed-on: https://code.wireshark.org/review/17677 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-12Qt: convert UatDialog to model/view pattern, improve UXPeter Wu11-437/+864
Fixes: - Fix crash (heap-use-after-free) on removing a record while editing. - Mark a record as invalid if any of the fields fail the validation. (Fixes crash in at least the ISAKMP dissector.) - Prevent saving of invalid UAT entries (e.g. empty UATs). - Do not close the dialog on pressing Enter/Escape while editing, close the editor instead. - Fix HTML injection in the error messages. Improvements: - Tab-navigation now works between fields. - The field editor is now closed once the focus is lost. - Fields that fail validation are marked (currently with a pink color). - The error hint selection has become smarter (see comments in UatDialog::checkForErrorHint). - Properly recognizes PT_TXTMOD_HEXBYTES formats like "aa:bb" (previously it would not expect the ":" and report a bad length). A validator prevents invalid strings from being entered. - The OK button is disabled when new/edited records are bad. Notably, existing (possibly invalid) records are skipped. (Bug 7471). Live validation (while typing in the editor) was dropped during conversion, but it can be added later if desired. Drag and drop reordering still needs to be implemented. Bug: 11714 Bug: 7471 Change-Id: Ic0b6a177f90503fbd65b5001d8a87a10e38f4d64 Reviewed-on: https://code.wireshark.org/review/17994 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-09[Automatic update for 2016-10-09]Gerald Combs7-253/+304
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I84adcfee2652783d1b3b7d7e3ff9b209f8b23d96 Reviewed-on: https://code.wireshark.org/review/18130 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-10-08Combine Decode As and port preferences for tcp.port dissector table.Michael Mann12-365/+381
This patch introduces new APIs to allow dissectors to have a preference for a (TCP) port, but the underlying data is actually part of Decode As functionality. For now the APIs are intentionally separate from the regular APIs that register a dissector within a dissector table. It may be possible to eventually combine the two so that all dissectors that register with a dissector table have an opportunity to "automatically" have a preference to adjust the "table value" through the preferences dialog. The tcp.port dissector table was used as the guinea pig. This will eventually be expanded to other dissector tables as well (most notably UDP ports). Some dissectors that "shared" a TCP/UDP port preference were also converted. It also removed the need for some preference callback functions (mostly when the callback function was the proto_reg_handoff function) so there is cleanup around that. Dissectors that has a port preference whose default was 0 were switched to using the dissector_add_for_decode_as_with_preference API rather than dissector_add_uint_with_preference Also added comments for TCP ports used that aren't IANA registered. Change-Id: I99604f95d426ad345f4b494598d94178b886eb67 Reviewed-on: https://code.wireshark.org/review/17724 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-07Qt: valign text in RTP Stream Analysis window.Jaap Keuter1-24/+24
The text on the left hand side of the RTP Stream Analtsis window is a (HTML) table of table headers followed by table data. For some reason the table data is center aligned in the cells of the table. This does not line up with the text in the table header cells. See http://imgur.com/a/QIQFd Also the HTML document is not compliant. Closing tags are missing, for td and html itself. Change-Id: I1cd58e8702db12433c863757141a6b68c1e2550c Reviewed-on: https://code.wireshark.org/review/18074 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-10-07Interface View/Model: Correct column orderingRoland Knall5-17/+63
This orders the columns correctly in the sequence the developer has intended when adding them with setColumns. Also it allows for disabling and inverting the filtering by type, as well as query additional roles instead of only Qt::DisplayRole from the tree model. Change-Id: I90469e8e3f3caa50debb3c839590d42719a6fb10 Reviewed-on: https://code.wireshark.org/review/18096 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-10-04Qt: add condition to compile without extcap.Dario Lombardo1-0/+2
Change-Id: Ieabccb5dfc7884bebf9f2b68caaa16a82609bd30 Reviewed-on: https://code.wireshark.org/review/18060 Petri-Dish: Dario Lombardo <lomato@gmail.com> Reviewed-by: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2016-10-04Interface View/Model: Fix pcap-less buildRoland Knall1-7/+6
Change-Id: I88bc6c939b7ce6986299e4ebf99358437b758bd2 Reviewed-on: https://code.wireshark.org/review/18045 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-10-04Qt: Have logo in the center of the about dialogJaap Keuter1-0/+3
Change-Id: I5dca338e7e3eda3f4b0fa827fe6f7177337f5393 Reviewed-on: https://code.wireshark.org/review/18011 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-03Be more forgiving about invalid Coloring Rules.Gerald Combs1-5/+7
In ColoringRulesDialog: Only check a rule's display filter if that rule is enabled. This keeps us from disabling the OK button when we shouldn't. Adjust the "Your coloring rules file contains unknown rules" dialog text and buttons for accuracy. In color_filters.c: Don't try to compile disabled filters in color_filters_apply. Don't warn about disabled and invalid filters in read_filters_file. Bug: 12814 Change-Id: I7143bf8e7a6162d296f1e93769344b69763195c8 Reviewed-on: https://code.wireshark.org/review/17823 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-03Interface List: Allow column filtering in modelRoland Knall5-100/+210
This change allows for the definition of columns to be shown to the enduser if instanting the proxy model. The tree model will allways transport ALL data, and it is the job of the proxy model to determine which data is actually shown. Additionally, this removes the final definitions of the global interface array from interface_frame as well as sort_filter, so that knowledge about the inner workings of the interface list is contained to interface_tree_model Change-Id: Ib34b150066ee344ad0d18bec1d90826eb0fa28b2 Reviewed-on: https://code.wireshark.org/review/18039 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-10-03Qt: make parameter unused when SHOW_BUFFER_COLUMN is undefined.Dario Lombardo1-0/+2
Change-Id: I87843f61d4c98fea90e49088f3d56df5aa801e58 Reviewed-on: https://code.wireshark.org/review/17946 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2016-10-03Qt: properly handle UAT changes on dialog closePeter Wu2-4/+6
Ensure that UAT changes are always applied, not just when pressing the OK/Cancel buttons, but also when closing the dialog via the window close button or by pressing Escape. Change-Id: I0f0b97588553c6b01a24dfde78218d0ce2667e2c Reviewed-on: https://code.wireshark.org/review/17993 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-03tshark: follow streams should start with chunk 1.Michael Mann1-1/+1
Chunk 0 is not allowed, so it's discarded when outputting a stream. Ping-Bug: 12855 Change-Id: Ia7bbb0e222b6b4e714f8bfa245e910c151d82905 Reviewed-on: https://code.wireshark.org/review/18034 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-02Interface List: Fix build for no PCAP buildsRoland Knall4-12/+49
This is a fix for building without libpcap. Also, changing _U_ to Q_UNUSED for the tree_model Change-Id: I38a992731a3d3c4062ffab3cca0049cf08050794 Reviewed-on: https://code.wireshark.org/review/18019 Petri-Dish: Roland Knall <rknall@gmail.com> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-10-02Interface List: Hide button for only one interfaceRoland Knall2-38/+54
If only one interface type exists, the button row is being hidden. Change-Id: Ieed9c363ab1ebc4bc15d0e09bceeb79a04d6e76e Reviewed-on: https://code.wireshark.org/review/18017 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-10-02Qt: Only color sequence analysis items having color filterStig Bjørlykke3-3/+9
Packets without a color filter will end up with fg_color and bg_color = 0, so avoid drawing all in black. Bug: 12065 Change-Id: I76bcabcfa3281fcece08f1b2af66274c808b80bb Reviewed-on: https://code.wireshark.org/review/18018 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
generated by cgit v1.2.1 (git 2.18.0) at 2024-07-02 21:57:58 +0000