summaryrefslogtreecommitdiff
path: root/ui
AgeCommit message (Collapse)AuthorFilesLines
2016-11-28Qt: Update UAT OK button enabled on delete.Stig Bjørlykke2-0/+11
Check if the OK button should be enabled when removing a row in a UAT dialog. Also update the error hint. Change-Id: Icb5c47c2b2e65ed266fd2c7e3a1535f6a3a50279 Reviewed-on: https://code.wireshark.org/review/18967 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-11-28Qt: Fix conversation buttons.Gerald Combs2-15/+24
Move parts of currentTabChanged to conversationSelectionChanged. This lets us enable the "Follow Stream" and "Graph" buttons when either the current tab or the current selection changes. Bug: 12893 Change-Id: I025447d26073a938f2d8b5a8fcad7c0d5e855650 Reviewed-on: https://code.wireshark.org/review/18963 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-11-28Qt: fix heap-use-after-free when double-clicking a packet numberPeter Wu1-4/+2
On double-clicking a packet number, the current field item is invalidated by goToPacket. Skip the URL since a field can either have a URL or a frame number (but not both). Change-Id: I58e5445fa74071fa0fd203df77ebdecdd1478d31 Reviewed-on: https://code.wireshark.org/review/18971 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-11-26Qt: Clean up the byte view hover highlight.Gerald Combs4-46/+68
Rename the text highlight enum "HighlightMode" to make its use and intent more clear. Add a mode for the offset highlight instead of using a separate variable. Use our palette to draw the hover highlight colors. Add a note about colors to the Developer's Guide. Change-Id: I488b2512a5058e17eb5b49c8ac55616100f32fbc Reviewed-on: https://code.wireshark.org/review/18953 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-11-25Get rid of "cast throws away constness" warnings.Guy Harris1-2/+2
Change-Id: I62cf58798341a5301a787c321f65ecc2a3cec171 Reviewed-on: https://code.wireshark.org/review/18947 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-11-19LBM_UIMflow: Fix range_ratio calculation (CID-1355421)Jaap Keuter1-1/+1
Port the same calculation from sequence_dialog.cpp. Resolves the Coverity issue and aligns the output just a bit better. Change-Id: Iaa464149630e0fafb5bdff20019440c3fb67bbbd Reviewed-on: https://code.wireshark.org/review/18868 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-13[Automatic update for 2016-11-13]Gerald Combs7-3796/+3883
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I83298430701c25aaba15cc5db02603bacd6d196a Reviewed-on: https://code.wireshark.org/review/18798 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-11-13Qt: populate Bookmarks menu in capture options dialogPeter Wu1-0/+1
The bookmarks menu is populated for the main window when the appInitialized signal is emitted, this ensures that any preferences are applied. For the Capture Options dialog however, the appInitialized signal is never triggered since the GUI has already started. Just invoke it from the constructor such the menu is populated at least once. Bug: 12986 Change-Id: I04457fd25e52a25714ac471131b90e3a128515d8 Reviewed-on: https://code.wireshark.org/review/18734 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-11Qt: Fix a "No such slot" warning.Gerald Combs2-2/+4
Make sure on_actionCaptureOptions_triggered always exists so that we don't get a "No such slot" warning when building without libpcap. Change-Id: Ib7c82df6c72bf080ff080e0a650216b345a97e9c Reviewed-on: https://code.wireshark.org/review/18747 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-11-11Qt: fix build without libpcapPeter Wu1-5/+7
Change-Id: I89a2f9a21a17a318529c7f0785ab60385fe08dcf Fixes: v2.3.0rc0-1445-g414c132 ("Qt: Handle retranslation events in the main window") Reviewed-on: https://code.wireshark.org/review/18746 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-11-10tcp: Fix Follow TCP tap data and when its tapped.Michael Mann3-19/+25
Use the model from the 2.0 branch and earlier that only "tapped" the follow data in a single location. This fixes duplicate data for reassembled data and handles out-of-order packets. Bug: 12855 Change-Id: I5268f13e3c08e9271acf026b859de693ad794c94 Reviewed-on: https://code.wireshark.org/review/18368 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-11-10Enable exporting IMF traffic as an EML fileMoshe Kaplan9-1/+97
Change-Id: Ia56b38a770a148dd8bf030699615189601944cc2 Reviewed-on: https://code.wireshark.org/review/18656 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2016-11-10Qt: Handle retranslation events in the main window.Gerald Combs10-83/+125
Update most (but not all) of the main status bar text when the user changes the language setting. Try to distinguish between recent preferences and recent captures more clearly. Change-Id: I5278a503178fe3620a25b185742688f957dc30f4 Ping-Bug: 11307 Reviewed-on: https://code.wireshark.org/review/9575 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-09CMake: Use find_program to find a program.Gerald Combs1-3/+3
Use find_program to find glib-compile-resources instead of find_file. Change-Id: I565c3a596923ff4761bc38988ee396aa24bd63a6 Reviewed-on: https://code.wireshark.org/review/18714 Petri-Dish: Gerald Combs <gerald@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-11-08Qt: Restore the default "About" box tab.Gerald Combs1-1/+1
Set the default about box tab back to "Wireshark". (Presumably this changed due to Qt Creator's annoying last-tab-selected-wins behavior.) Change-Id: I85f64b623758a14e9588f6b3929bad26a6a60ad5 Reviewed-on: https://code.wireshark.org/review/18716 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-11-07interface_tree_model.cpp - ensure QObject namespace for tr()Michael Mann1-1/+1
Change-Id: I64214b5e2eb8b64ae36e049174d94d10da1e5bc5 Reviewed-on: https://code.wireshark.org/review/18698 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-11-06[Automatic update for 2016-11-06]Gerald Combs7-665/+770
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: Ia867e3b78363ba806ab99dd8da321f5f48c279cc Reviewed-on: https://code.wireshark.org/review/18691 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-11-06Qt: move declaration inside ifdef.Dario Lombardo1-1/+1
Variable col is unused if compiled without extcap. Change-Id: Iffc4951d4655e2649ecf350eefb09988370277e6 Reviewed-on: https://code.wireshark.org/review/18680 Reviewed-by: Roland Knall <rknall@gmail.com> Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-04Qt/Bluetooth: Split LE Meta EventsMichal Labedzki2-6/+157
Add 3rd level subtree in Event->LE Meta, because of existance of "Subevent" which is in similar thing to Event or Opcode in CommandComplete. Change-Id: Ib732ab417c5141251736b608de2e4e64b702c20a Reviewed-on: https://code.wireshark.org/review/18667 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2016-11-03Fix lintian found spelling error "splitted" -> "split"Michael Mann1-1/+1
Change-Id: I4b00ef460ae1792cd6f14856493f7a58ab8e0b9a Reviewed-on: https://code.wireshark.org/review/18645 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-11-02Qt: add "search authors" feature.Dario Lombardo3-11/+39
Add a search field in the authors tab. The list of authors has became huge and it's very hard to find someone in it. Having a fast way to search yourself or your friends would be fun. Change-Id: I0c6a5e8d5893d6f7b5a3258e63bdc91969f53d31 Reviewed-on: https://code.wireshark.org/review/18594 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Dario Lombardo <lomato@gmail.com>
2016-10-31Handle -K, -n, -N, and -u in the common dissection option code.Guy Harris3-37/+51
Also update tfshark to use that code. Change-Id: Ic03fb8ff48c8bfc460298d180b436e53f0076cbe Reviewed-on: https://code.wireshark.org/review/18588 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-10-31Have the routine that handles dissection options not exit.Guy Harris3-8/+14
Have it return TRUE if the option is OK and FALSE if it isn't, and let its caller exit as appropriate. Also, rename it - it's not adding something to a collection, it's just handling the option. Change-Id: I41863cbb67b7c257d900d3011609891b9b4a7467 Reviewed-on: https://code.wireshark.org/review/18587 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-10-30Have routines for parsing options that affect dissection.Guy Harris9-67/+262
Have them handle -d, -t, --disable-protocol, --disable-heuristic, and --enable-heuristic for TShark and both flavors of Wireshark. Change-Id: I612c276b1f9df8a2092202d23ab3d48be7857e85 Reviewed-on: https://code.wireshark.org/review/18583 Petri-Dish: Guy Harris <guy@alum.mit.edu> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-10-30InterfaceList: Fix build without pcapRoland Knall2-10/+42
Change-Id: I2b1a955270e7d3fe0097b09517a268263facd1be Reviewed-on: https://code.wireshark.org/review/18580 Reviewed-by: Roland Knall <rknall@gmail.com>
2016-10-30[Automatic update for 2016-10-30]Gerald Combs7-5102/+5507
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I192e3989204931901b9890366860abdfddf990a4 Reviewed-on: https://code.wireshark.org/review/18577 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-10-30wlan_statistics_dialog (Qt): Fix display when there is no packets_Alexis La Goutte2-3/+15
Make sure we don't pass an invalid value to PercentBarDelegate. Make sure PercentBarDelegate handles invalid values more gracefully. Change-Id: I18f07542be3432d0fcf5dff479eef2ea4d5e7931 Reviewed-on: https://code.wireshark.org/review/18276 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-10-30Fix two warnings when compiling with rpcap support on macOS.Joerg Mayer2-3/+1
One is an unused variable warning turning error, the other is [ 71%] Building C object ui/CMakeFiles/ui.dir/recent.c.o /Users/jmayer/worktmp/wireshark/git/ui/recent.c:494:23: error: implicit conversion loses integer precision: 'glong' (aka 'long') to 'gint' (aka 'int') [-Werror,-Wshorten-64-to-32] rh->auth_type = auth_type; ~ ^~~~~~~~~ 1 error generated. Please review. Change-Id: If838f8fa1e8a76dc8c6cc78db495befdd527da92 Reviewed-on: https://code.wireshark.org/review/18544 Reviewed-by: Michael Mann <mmann78@netscape.net> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-10-28Qt: fix typo in layout_preferences_frame.Dario Lombardo1-7/+7
Change-Id: I3827557445670c4a5b86b1fde0871c8828e91e68 Reviewed-on: https://code.wireshark.org/review/18546 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-27ManageInterfacesDialog: New handling of pipesRoland Knall13-267/+530
This moves the handling of pipes to the new InterfaceTreeModel as well. It also includes a new PathChooserDelegate and cache handling for adding data to an interface list without putting it into storage Change-Id: Id255a81161b4da517e26127abe8ea7f5eb36d55a Reviewed-on: https://code.wireshark.org/review/18497 Reviewed-by: Roland Knall <rknall@gmail.com>
2016-10-27Fix compile errors in GTK buildMichael Mann2-2/+2
Change-Id: Ib28c63e0ead6950b3b11b7c87adc543f80c070ed Reviewed-on: https://code.wireshark.org/review/18498 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-26Qt: WLAN Statistics performance improvements.Gerald Combs2-3/+33
In the WLAN statistics dialog, add our stations to the tree in the background. This returns control to the user immediately after tapping. Add notes about further performance improvements. Change-Id: Ie7ff818b8d835ecb38f5ff702a0d0e8f2635abb2 Reviewed-on: https://code.wireshark.org/review/18495 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-10-26Gtk: remove atoi calls and use ws_strtoi functions.Dario Lombardo7-18/+52
Change-Id: Ie38bdd27d9e3810e3a64b985dfd5621a3aa6d073 Reviewed-on: https://code.wireshark.org/review/18445 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-26Qt: Set uniformRowHeights for some of our trees.Gerald Combs6-0/+21
Set the uniformRowHeights property for a few of our QTreeWidgets. This can improve performance, particularly when we have many items. Change-Id: I2685646a533aa7accfb3a8578b5198894d873fb2 Reviewed-on: https://code.wireshark.org/review/18476 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-10-26qt: fix build without pcap_createPeter Wu1-1/+4
Fixes a build failure on the OS X buildbot which has libpcap disabled. Change-Id: I5564c0e3f2097cb45905bb503f45bb03561bf748 Fixes: v2.3.0rc0-1237-g6eee29b ("InterfaceTreeList: Enable all editable columns") Reviewed-on: https://code.wireshark.org/review/18472 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Tested-by: Peter Wu <peter@lekensteyn.nl>
2016-10-26InterfaceList: Make storing preferences optionalRoland Knall3-16/+32
If multiple proxy models are used, not all should change the preferences if types are being displayed or hidden. Only the main list should have that option. Change-Id: I8617e402b6608eda98d7ecc0167cd0ccc3c43eaa Reviewed-on: https://code.wireshark.org/review/18470 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-10-26InterfaceTreeList: Enable all editable columnsRoland Knall8-22/+430
In preparation for moving to the new interface list, adding all necessary editors and changes to allow all columns, which are being handled by CaptureInterfacesDialog or ManageInterfacesDialog to be edited correctly Change-Id: I8bfabff92a07950c74a4d7243dadd99ecd2024f4 Reviewed-on: https://code.wireshark.org/review/18446 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-10-25SCTP: find right assoc idruengeler2-6/+9
Change-Id: I107b7f4c585ef5e080d6473a37b3db9a97f12365 Reviewed-on: https://code.wireshark.org/review/18325 Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl> Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-10-25Qt: Enhancements to VoIP call dialog:erikdejong3-7/+61
1) Added checkbox to toggle format in start and stop time columns from relative time to time of day. 2) Added column to show duration of call in between the protocol and packets column. Change-Id: I56347fa36885e3a71646e2c9cdde2b8b5fb88846 Reviewed-on: https://code.wireshark.org/review/18383 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-24Qt: use ws_strtou function in sctp_chunk_statistics_dialog.Dario Lombardo1-1/+4
Change-Id: Iffa2d633ef7a0f636c595fb05ad1790d1ea61df0 Reviewed-on: https://code.wireshark.org/review/18402 Petri-Dish: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-10-24Move --fullscreen out of LONGOPT_CAPTURE_COMMON.Guy Harris1-0/+12
It's not a capture option, so it doesn't belong there. Change-Id: I8aa6719a5a8e90c734c7acfc01b1ba2818498de3 Reviewed-on: https://code.wireshark.org/review/18427 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-10-24Qt: Make horizontal spacer size to be fixedMichal Labedzki1-0/+3
The Search Frame can be used to find frames by a display filter expression that can be very long, so stretch a text field instead of free space. Example of a display filter expression that can be used in the "search bar": bthci_cmd.opcode == 0x200d || bthci_evt.le_meta_subevent == 0x0a Change-Id: I52b30386e96a726824c25a926742a24d653dfcfe Reviewed-on: https://code.wireshark.org/review/18234 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2016-10-24Qt: fix possible crash on sorting custom columnsPeter Wu1-2/+4
The sorting function must maintain a strict weak ordering, otherwise it may result in crashes. In the case of custom columns, this was violated when exactly one of the two rows had a non-numeric value. Bug: 13023 Change-Id: Ie338b1cce5156eeb313dd33491ee3d3f2eaddf1c Reviewed-on: https://code.wireshark.org/review/18406 Reviewed-by: Jim Young <jim.young.ws@gmail.com> Petri-Dish: Jim Young <jim.young.ws@gmail.com> Tested-by: Jim Young <jim.young.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-23Qt: add fullscreen feature.Dario Lombardo6-2/+51
The feature activates/deactivates fullscreen mode of Qt UI. A new menu item has been added as well as a shortcut (F11 or Ctrl+Cmd+F) according to browsers common shortcut. Change-Id: I01906b494d0a13ce70d27c00ebbe03e6ec87cbd7 Reviewed-on: https://code.wireshark.org/review/18332 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Dario Lombardo <lomato@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-10-23[Automatic update for 2016-10-23]Gerald Combs7-857/+1605
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I5127251ce46aa668cd12daacc7c6702564c04c8f Reviewed-on: https://code.wireshark.org/review/18412 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-10-23interface_sort_filter_model: don't dereference a NULL pointerMartin Kaiser1-0/+3
This fixes a crash in InterfaceSortFilterModel::mapToSource(). sourceModel was set to match the sourceModel of the underlying InterfaceFrame. When Wireshark is closed, InterfaceSortFilterModel::mapToSource() is called after InterfaceFrame was freed, the sourceModel is NULL in this case. #0 0x000000000079a81e in InterfaceSortFilterModel::mapToSource (this=0xe9fab0, proxyIndex=...) /home/martin/src/wireshark.git/ui/qt/interface_sort_filter_model.cpp:250 ... #7 0x0000000000797ed9 in InterfaceTreeModel::~InterfaceTreeModel (this=0xe9ff90, __in_chrg=<optimized out>) at /home/martin/src/wireshark.git/ui/qt/interface_tree_model.cpp:72 #8 0x00000000006c4e20 in InterfaceFrame::~InterfaceFrame (this=0xe643b0, __in_chrg=<optimized out>) at /home/martin/src/wireshark.git/ui/qt/interface_frame.cpp:109 #9 0x00000000006c4ec9 in InterfaceFrame::~InterfaceFrame (this=0xe643b0, __in_chrg=<optimized out>) at /home/martin/src/wireshark.git/ui/qt/interface_frame.cpp:112 Change-Id: Ibe7f75ccd7a0af5f04febf967c47ada1a05bc3d3 Reviewed-on: https://code.wireshark.org/review/18411 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx> Petri-Dish: Martin Kaiser <wireshark@kaiser.cx> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-10-22main_welcome: include QUrlMartin Kaiser1-0/+1
This fixes compilation with Qt4. .../main_welcome.cpp: In member function ‘void MainWelcome::on_helpLabel_clicked()’: .../main_welcome.cpp:509:69: error: invalid use of incomplete type ‘class QUrl’ Change-Id: Ib31a4e28f67a27d3f644e8a8cfd3e6d848e034c4 Reviewed-on: https://code.wireshark.org/review/18388 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2016-10-22Fix the #defines for the presence of structure names.Guy Harris1-5/+5
AC_CHECK_MEMBER() and AC_CHECK_MEMBERS() use a standard name for the {structurename} being the name of the structure type, complete with "struct" if a typedef wasn't used, and with all letters mapped to upper case, and with {membername} being the name of the structure member, with all letters mapped to upper case. check_struct_has_member() lets you choose the name; choose the same name that the autoconf macros use, and fix the code to check for them. Change-Id: Ifb3cf65e7e94907ad0a2f8aacca0c21a531f0c5b Reviewed-on: https://code.wireshark.org/review/18382 Petri-Dish: Guy Harris <guy@alum.mit.edu> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-10-22Qt/Bluetooth: Add Display Filter Edit field to HCI Summary dialogueMichal Labedzki3-1/+42
Display Filter can be useful for this summary dialogue, for example to reduce number of frame that were analyzed, like: "frame.number >= 100 && frame.number <= 4674" Change-Id: I19587b9d41f3b253d1ca2683d198f7d7af2ad50f Reviewed-on: https://code.wireshark.org/review/18265 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
2016-10-22Qt: Make "Learn" on the welcome screen clickable.Gerald Combs5-11/+28
Make the "Learn" header a ClickableLabel to match "Open" and "Capture". Link to the docs page for now. Adjust its stylesheet and properties to match ast well. Change-Id: Id9c7c05269de8134af28f0f9c1e2820a60442236 Reviewed-on: https://code.wireshark.org/review/18358 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.1 (git 2.18.0) at 2024-07-01 01:02:53 +0000