summaryrefslogtreecommitdiff
path: root/ui
AgeCommit message (Collapse)AuthorFilesLines
2015-12-14Make init_progfile_dir() take a function pointer [-Wpedantic]João Valverde1-1/+1
Change-Id: I45f8ea5ee6ccc5a484c60ad6e686aaf30f6b0c98 Reviewed-on: https://code.wireshark.org/review/12557 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-13recent.c: fix declaration of ‘value_string’ shadows a global declarationPascal Quantin1-2/+2
Change-Id: I7dff01e534094c27839476f322f88c2774bd9e62 Reviewed-on: https://code.wireshark.org/review/12605 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-12-13Use common code for Boolean and enumerated recent values.Guy Harris1-157/+109
Cleans up the code a bit, and means the comment written out for enumerated values will contain the write list of value strings. Change-Id: Iad484e5da9349ab48e3c55e69f671b0a68b5cc6d Reviewed-on: https://code.wireshark.org/review/12604 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-13ui: Read and write correct recent timestamp formatStig Bjørlykke1-34/+40
Rewrite to use value_string to ensure correct value strings used, to add backward compatibility and to avoid global-buffer-overflow in possible future inconsistencies. This bug was introduced in 2a088c1d when adding new timestamp formats. Change-Id: I1bf4ac8427db92bfb56b4e5b90809fe08eebed20 Reviewed-on: https://code.wireshark.org/review/12584 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-13Qt: Removed applyRecentColumnWidths from recentFilesReadStig Bjørlykke4-10/+13
Adjusting column widths from recent settings is only needed when columns has changed. Don't recreate the columns when changing timestamp options or name resolution, only reset columns. Change-Id: I4c9a9f63c34542935dd282188d98b2b5b013c5f3 Reviewed-on: https://code.wireshark.org/review/12579 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-12-13[Automatic update for 2015-12-13]Gerald Combs13-1395/+1418
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I690eec9b47df9bbc770773f8c7a8e1c4b4ef5415 Reviewed-on: https://code.wireshark.org/review/12588 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-12-13capture_dlg (gtk): The use of 'if (A) {...} else if (A) {...}' pattern was ↵Alexis La Goutte1-3/+1
detected found by PVS Studio (V517) MIN_PACKET_SIZE is define on caputils/capture-pcap-util.h to 1 Change-Id: Ib6486608cf3e0eac898ba859cf46e9d403d493d0 Reviewed-on: https://code.wireshark.org/review/12364 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-13text_import: Argument with 'nonnull' attribute passed null found by Clang ↵Alexis La Goutte1-0/+4
Analyzer Change-Id: Ie070aa0f58cca156661ddd5689596e29ad56b128 Reviewed-on: https://code.wireshark.org/review/12412 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-13The variable is assigned values twice successively found by PVS Studio (V519)Alexis La Goutte1-1/+1
Change-Id: I063b0ee2dd4ed948f889c33ab458df20079a64ff Reviewed-on: https://code.wireshark.org/review/12370 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-13Start deprecating the capture info API.Gerald Combs5-21/+5
The GTK+ UI has a capture info dialog which shows a summary of captured protocols, including IPX (!), NetBIOS (!!) and VINES (!!OMG!!). It's been disabled by default since 2006 (g59aa9e40). Remove the preference in the Qt UI capture pane. It's still available via the advanced prefs. Add comments in various parts of the code noting that the capture_info routines and structs are GTK+ only. Also note that if we *do* want to add a Qt capture info dialog we'll probably want to modernize the information we show. Change-Id: I3c63f6f01b60f0767fb33602a7f0c3b537dbde51 Reviewed-on: https://code.wireshark.org/review/10991 Petri-Dish: Anders Broman <a.broman58@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-12Qt: validate format string before calling strftime()Pascal Quantin3-26/+83
According to https://msdn.microsoft.com/en-us/library/fe06s4ak.aspx an invalid string will trigger invalid parameter handler Also check the validity of each field before activating import button Bug: 11873 Change-Id: I9fc1c6e061a02354690871410f0e2cf2e0dd86a7 Reviewed-on: https://code.wireshark.org/review/12537 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-12Qt: Apply recent column widths when columns changedStig Bjørlykke1-1/+1
When changing columns in the preferences or when removing a column from the packet list header menu we need to apply recent column widths to preserve the remaining columns widths. Change-Id: Ie5c074722424b5cee31af3b6953ab1b026ba7fa5 Reviewed-on: https://code.wireshark.org/review/12575 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-12-12Remove -Wwrite-strings compiler flagJoão Valverde5-13/+11
The "-Wwrite-strings" flag produces nuisance warnings. These warnings are not useful, they're impossible to fix in a sane way and therefore are being handled with casts of static strings to (char *). This just moves the warning to [-Wcast-qual] and a compiler pragma is in turn required (and used) to squelch that warning. Remove the Wwrite-strings warning. Let that responsibility fall on the programmer (as is done by casting). Change-Id: I5a44dfd9decd6d80797a521a3373593074962fb5 Reviewed-on: https://code.wireshark.org/review/12162 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-12Clamp zooming so that we don't get zero or negative font sizes.Guy Harris4-26/+17
Those are obviously wrong. Also, clean up some stuff left over from the GTK+ 1.x days; GTK+ 2.x doesn't expose raw XLFD font names, it lets you specify a font by name and size, and font_zoom() doesn't determine whether the font is resizeable - it just constructs a new font name/size pair and leaves it up to its callers to try to load the font, so "there's no such font as Wingdings Gothic" and "you can't blow up Fraktur to 10 million points" both show up as errors loading the font by name. Bug: 8854 Change-Id: I6af142c75c9ebabd1a95308c203f8cb1f36dd82f Reviewed-on: https://code.wireshark.org/review/12549 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-11Fix memory leaks in all_ifaces when interface list changesMikael Kanstrup6-9/+21
Valgrind report leaks of several allocations like these: 590 bytes in 50 blocks are possibly lost in loss record 29,818 of 31,670 at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0xCB9C8A7: __vasprintf_chk (vasprintf_chk.c:82) by 0xA3D8DCA: g_vasprintf (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3200.4) by 0xA3B846C: g_strdup_vprintf (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3200.4) by 0xA3B850B: g_strdup_printf (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3200.4) by 0x6F4B51: scan_local_interfaces (iface_lists.c:254) by 0x6EF3D8: iface_mon_handler2 (iface_monitor.c:113) by 0xBE56F1D: ??? (in /lib/libnl-3.so.200.3.0) by 0xBA16F19: ??? (in /usr/lib/libnl-route-3.so.200.3.0) by 0xBE54E5E: nl_cache_parse (in /lib/libnl-3.so.200.3.0) by 0xBE585CA: nl_msg_parse (in /lib/libnl-3.so.200.3.0) by 0x6EF372: iface_mon_handler (iface_monitor.c:123) When the list of network interfaces is updated allocations done for global_capture_opts.all_ifaces elements leak memory. Fixed by introducing a helper function to be used for removing an interface_t element from all_ifaces array. While at it also fixed misc leaks when updating individual allocated records of all_ifaces elements. Change-Id: I035e6936a44edeef2ebe4780931c14cde99e93a4 Reviewed-on: https://code.wireshark.org/review/12209 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2015-12-11Qt: restore conversation coloring rule shortcutsPeter Wu1-0/+27
GTK+ had this very useful Ctrl+1 .. Ctrl+9 shortcuts for conversation coloring rules. Add this functionality to Qt too. Ctrl+0 is not ported though, this now means "Restore zoom" which is quite logical. Also, Ctrl+= (shortcut in GTK+) somehow does not work in Qt 5.5.1 (it is detected as Ctrl++ instead). Change-Id: I5528c723ef6d4ea11298a135db8539a8d03d9aae Reviewed-on: https://code.wireshark.org/review/12506 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-10Qt: Reset preferences when reloading Lua pluginsStig Bjørlykke3-8/+10
Reading configuration files may duplicate some entries, so ensure we reset preferences before reloading. Change-Id: I746414cbc10c206ddf47669856f329b9e0202a0d Reviewed-on: https://code.wireshark.org/review/12496 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-12-09Qt: Disable Refresh Interfaces while refreshingStig Bjørlykke1-0/+2
Doing multiple Refresh Interfaces simultaneously will end up in duplicated interfaces. Change-Id: If9bb4252bbfabc557b78ad42efc0011050012417 Reviewed-on: https://code.wireshark.org/review/12414 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-09Qt: various fixes to VoIP calls / RTP player windowsPascal Quantin11-64/+107
- Flush any remaining tapped packets before emitting captureFileRetapFinished(). This ensures that all packets have been treated before returning from retapPackets(). - Remove VoIP tap listeners when captureFileRetapFinished() is emitted. This avoid summing stats each time the RTP player is opened, leading to wrong information in VoIP calls window - Change voip_calls_tapinfo_t redraw member from a boolean to bitmap so as to identify which tap should call the tapinfo->tap_draw() callback. This allows fixing a race condition where the RTP player can be empty in Qt UI - Reset some more statistics in voip_calls_reset_all_taps() Change-Id: Ie7681702c81d338185c1813f2d340a437edf3a04 Reviewed-on: https://code.wireshark.org/review/12474 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-09Qt: store the absolute path names of recent files.Jeff Morriss1-3/+3
That way you can still open a file you recently opened (which was in your pwd) even if you happen to change directories (as shell-prompt-dwellers such as myself are wont to do). (The Gtk GUI already stores absolute paths.) Change-Id: If29bcc25d680825c659f8eb4f13b108764029652 Reviewed-on: https://code.wireshark.org/review/12483 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-08Fix crash caused by nullptr in packet_listmichal.orynicz1-2/+2
Fix crash caused by nullptr returned from proto_registrar_get_byname in packet_list.cpp Change-Id: If8324bf7c926585e964a11b27817f73d444beec4 Reviewed-on: https://code.wireshark.org/review/11558 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2015-12-07Qt: Align extcap label and edit widgetsStig Bjørlykke1-2/+2
Change-Id: I5c1bff7bf3fadffb198ed2c5c96dac06d9e28c81 Reviewed-on: https://code.wireshark.org/review/12462 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-12-07Qt: Set the packet list width when we apply recent column widths.Gerald Combs1-17/+9
Instead of messing with stretchLastSection, simply widen the packet list to the sum of our column widths. Do this whenever recent column widths are applied instead of only when the packet list is shown. Bug: 11849 Ping-Bug: 11738 Change-Id: If8f8c9a89da08387bbce38c663bbbe1d8f7e649a Reviewed-on: https://code.wireshark.org/review/12455 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2015-12-07SCTP: Fix warning found by PVS Studioruengeler7-38/+19
Change-Id: I713eb6eff3681573baf77274847a32a4cc6b9ee0 Reviewed-on: https://code.wireshark.org/review/12408 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-07Spelling fixes for errors found by lintianBalint Reczey2-2/+2
Change-Id: I889283902875193f4d3f3fd59788f59f8d9bcc20 Reviewed-on: https://code.wireshark.org/review/11945 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-07Qt: It's no translation for "%1 %2"Stig Bjørlykke1-1/+1
Change-Id: If50a19b34b5f1c0076fcee76e59a45c307a9b2db Reviewed-on: https://code.wireshark.org/review/12456 Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2015-12-06[Automatic update for 2015-12-06]Gerald Combs13-1710/+2042
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I70fd3f5a9f8f53ea6a086b521c8f05d33815516f Reviewed-on: https://code.wireshark.org/review/12450 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-12-06Qt: No path for created and renamed profilesStig Bjørlykke3-16/+44
The path is not valid for created and renamed profiles because the directory is not created yet. Use this label as a info label to describe where the profile is created from or renamed from instead. Use correct path for the Default profile. Removed Bold from the current profile in status bar list. Added tooltip for system provided profiles. Change-Id: I61c8b1cc811dd9f9419ff9e373a8d00aa4e30446 Ping-Bug: 11704 Reviewed-on: https://code.wireshark.org/review/12447 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-12-05Use noyywrap rather than defining our own yywrap functions.Guy Harris1-6/+5
Tweak lemonflex-tail.inc to fix an issue this reveals. It appears that, at least on the buildbots, the Visual Studio compiler no longer issues warnings for the code generated with %option noyywrap. Change-Id: Id64d56f1ae8a79d0336488a4a50518da1f511497 Reviewed-on: https://code.wireshark.org/review/12433 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-04Qt: fix a potential memory leak in RTP audio stream playbackPascal Quantin1-1/+1
Change-Id: I6847f85d56841f99594063bfb7441d0c40e452a7 Reviewed-on: https://code.wireshark.org/review/12425 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-12-04More libcodecs -> libwscodecs.Guy Harris1-1/+1
Change-Id: Ieb0bb131b6d141bf85997c9a0127e0eb11ea3a3b Reviewed-on: https://code.wireshark.org/review/12420 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-03Change codecs from static to dynamic libraryPascal Quantin1-2/+3
This allows to properly register codecs plugins. See https://www.wireshark.org/lists/wireshark-dev/201511/msg00202.html for details. Change-Id: Ibc13a19936abb7a2e81b86582a75fa424351565b Reviewed-on: https://code.wireshark.org/review/12385 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-03qt: Refresh local interface list only when interfaces added/removedMikael Kanstrup1-9/+1
Whenever data is received on the iface monitor socket the list of local network interfaces is refreshed. No check whether an interface is really added/removed is done. Changes to network interface options like promiscous mode flag generate traffic on the iface monitor socket that not necessarily mean an interface was brought up or down resulting in an unwanted refresh of local interfaces. When local interfaces are refreshed selected capture interface(s) get deselected. This in turn makes "Restart current capture" fail with a no capture interface selected error. Fixed by moving the refresh action from socket monitor callback to iface monitor callback where interface up/down status is known. Bug: 11834 Change-Id: Iffd39c3240049880b5a8311bc6484f3d1433f387 Reviewed-on: https://code.wireshark.org/review/12317 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015-12-03Qt: Update menus with new recent settings when changing profileStig Bjørlykke4-23/+43
Update all View options to new recent settings to reflect the changes. Also show/hide toolbars and packet panes accordingly. Change-Id: Idb07bd5c51c01810b1f4467d2401936dc533731b Reviewed-on: https://code.wireshark.org/review/12405 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-12-03Qt: Set timestamp precision when changing profileStig Bjørlykke1-0/+1
Change-Id: I85622a8e2689283017ba038ce61d98e22f1c1af3 Reviewed-on: https://code.wireshark.org/review/12403 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-12-03Qt: Disable setStretchLastSection in the packet list.Gerald Combs1-0/+18
QTreeView sets the stretchLastSection property of its header by default. In our case this means that if the sum of our recent column widths exceeds the width of the packet list viewport QHeaderView will shrink the last column to fit. Disable setStretchLastSection. We want its behavior when our columns are too narrow so check for that in ::showEvent and temporarily enable it there. Bug: 11738 Change-Id: Ia4aad63e4f4bf899891bcebb7032dc5ebeb74cc7 Reviewed-on: https://code.wireshark.org/review/12392 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-03Qt: Set main window font when changing profileStig Bjørlykke1-2/+2
The font is part of the preferences. Change-Id: Ibcdf1c06e92fc43547825b5fea9560e904003081 Reviewed-on: https://code.wireshark.org/review/12386 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-03Qt: Check display filter when changing profileStig Bjørlykke5-5/+14
The Display Filter Macros may have changed and if a macro is currently used in the display filter then cf_redissect_packets() will bail out in an assert if trying to apply an invalid filter. Change-Id: I842016360672d76d190454ce80ccc7604f2075b3 Reviewed-on: https://code.wireshark.org/review/12388 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-03Qt: fix selection of folder in UAT dialogPascal Quantin1-3/+10
Using getOpenFileName() even with ShowDirsOnly option does not work. Let's use the dedicated getExistingDirectory() method instead. Bug: 11842 Change-Id: Ie22c4c479005467dbf64d9a90a8f3b82d355d495 Reviewed-on: https://code.wireshark.org/review/12384 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-03Fix address hashing broken in g4f39c60Evan Huus1-4/+4
We actually have to *use* the return value of the method, which the macro did for us. Change-Id: I240ca7e526a18054fe39c6c4ded902998dc2fef0 Reviewed-on: https://code.wireshark.org/review/12389 Petri-Dish: Evan Huus <eapache@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com> Reviewed-by: Jim Young <jim.young.ws@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Evan Huus <eapache@gmail.com>
2015-12-02sctp_chunk_stat_dlg: fix The 'u_data->assoc' variable is assigned values ↵ruengeler1-2/+0
twice successively. found by PVS Studio (V519) Change-Id: I01ac47693279b5681c40287f12a63ef767c9ad74 Reviewed-on: https://code.wireshark.org/review/12382 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-02ui: Guard update_local_interfaces with HAVE_LIBPCAPStig Bjørlykke2-0/+4
Change-Id: I276193047e37cf581fd42ccc74ff9131ee4fa055 Reviewed-on: https://code.wireshark.org/review/12377 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-12-02ui: Update interfaces when when changing profile.Stig Bjørlykke4-21/+62
The interfaces preferences are different for each profile so ensure we update the interface settings when changing profile. This bug was introduced in version 1.8.0. Change-Id: Icf22670875e01bab6204c300ddc7fb8aeb3dcecf Reviewed-on: https://code.wireshark.org/review/12363 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2015-12-02Qt: Use uniform interface display nameStig Bjørlykke4-44/+54
Use common function to generate the interface display name, both when scanning for interfaces (scan_local_interfaces()) and when changing Comment in the Manage Interfaces dialog. Change-Id: I3260208856563aaf387ce397d4ae61bddcc89b4f Reviewed-on: https://code.wireshark.org/review/12362 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-01Qt Frames: Use ButtonBox instead of buttonsRoland Knall12-82/+86
In these frames the Ok and Close buttons are implemented as standalone buttons. This leads to the scenario, that they break plattform-ui preferences on the one hand, as well as not being the same order throughout. This patch replaces all Ok/Close buttons with the Qt button box, which handles the plattform-ui internally, and additionally allways enforces the same order. Change-Id: If62b90016b222322f60c0962da04c8277589a57f Reviewed-on: https://code.wireshark.org/review/12335 Reviewed-by: Roland Knall <rknall@gmail.com> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2015-12-01Qt: write number of decoded bytes in the RTP player temporary bufferPascal Quantin1-1/+1
For codecs using compression (so not G.711) the number of decoded bytes is different from payload len * sample bytes. This result in a truncated audio buffer and inaudible audio. Change-Id: I755c19df37820c1c56acc7bd7b67fcc104516474 Reviewed-on: https://code.wireshark.org/review/12336 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2015-12-01Qt: fix generation of silence samplesPascal Quantin1-3/+1
The current code generates a shrill noise at least on Windows. Presumably memccpy does not behave as initially expected :) Change-Id: Id23a35d1d41ef4044b6a96c093a8fa927828f8b3 Reviewed-on: https://code.wireshark.org/review/12337 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-01sctp_byte_graph_dlg: fix The 'u_data' variable is assigned to itself found ↵Alexis La Goutte1-1/+0
by PVS Studio (V570) Change-Id: I6cde7c8357ad6295706c64ce6d280a867bdb9aad Reviewed-on: https://code.wireshark.org/review/12338 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-12-01Qt: Don't expose ColorUtils::graph_colors_.Gerald Combs6-13/+18
Make graph_colors_ private and accessible via getters. Blind attempt at fixing bug 11833. Bug: 11833 Change-Id: I03b7e90c686374d2d0f046f7e5fe87e43939dc82 Reviewed-on: https://code.wireshark.org/review/12318 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2015-11-30main_window: fix no previous prototype for function ↵Alexis La Goutte1-1/+1
'plugin_if_mainwindow_gotoframe' [-Wmissing-prototypes] Change-Id: I2ac9d2250e8553b4cbd4146f931b618424dffdf5 Reviewed-on: https://code.wireshark.org/review/12304 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
generated by cgit v1.2.1 (git 2.18.0) at 2024-06-29 05:31:23 +0000