summaryrefslogtreecommitdiff
path: root/ui
AgeCommit message (Collapse)AuthorFilesLines
2016-01-21profile_name_is_valid() returns a malloced string [-Wcast-qual]João Valverde3-3/+3
Change-Id: I584cdbf6a09e818e0d14c951defdde2fc96787f3 Reviewed-on: https://code.wireshark.org/review/13440 Reviewed-by: João Valverde <j@v6e.pt>
2016-01-21Avoid returning malloced memory as const [-Wcast-qual]João Valverde7-34/+34
Change-Id: I0b2c03cbde963d13d07ef13284d85b922eec3be9 Reviewed-on: https://code.wireshark.org/review/13439 Reviewed-by: João Valverde <j@v6e.pt>
2016-01-20Qt: fix a crash when trying to open TCP stream graph on a truncated TCP packetPascal Quantin3-2/+5
Do not try to show TCP stream graph window if it was rejected in constructor Change-Id: I4d1401e2c356391ceb8c8e3d37a668fc2a9fc92f Reviewed-on: https://code.wireshark.org/review/13454 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-20Qt: ensure to call destructor when closing a few QDialog windowsPascal Quantin3-0/+3
Change-Id: I10d2a610e852fdc2f38b84e561f04783af0d612e Reviewed-on: https://code.wireshark.org/review/13453 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-20Qt: Resize columns to contents in DecodeAsMichal Labedzki1-0/+6
If user first time run DecodeAs columns width are not enough, so content are trimmed. Do resizing whenever add new item. Change-Id: I378e2a5b2134479d961f3f00d398d8052f7e556d Reviewed-on: https://code.wireshark.org/review/13392 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2016-01-19Qt: Update window title when preferences changed.Stig Bjørlykke2-1/+2
When switching profile the prefs.gui_window_title may have changed so ensure we update the main window title. Change-Id: Ic1f9c7ac075d77c60cfbebb20624e597f7eb8449 Reviewed-on: https://code.wireshark.org/review/13418 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-01-18Add a copy button to the Filter Expression preferences.Gerald Combs3-10/+43
Add a "copy" button to match other parts of the UI. Change-Id: I4240aaaaf18a6bbf8e6737a12bcfead2248acca7 Reviewed-on: https://code.wireshark.org/review/13322 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-01-18Qt: Fixup the Display Filter Expression syntax logic.Gerald Combs4-16/+8
In the Display Filter Expression dialog, only disable the OK button when we have an invalid filter. Move the deprecated warning string from DisplayFilterEdit::checkFilter to SyntaxLineEdit::checkDisplayFilter so that we can use it in more places. Change-Id: I938f5f10258f4fd9dd3a33c174dd9958c9634766 Reviewed-on: https://code.wireshark.org/review/13317 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-01-18extcap: add masked to options.Dario Lombardo2-1/+9
This allows an option to be masked (like a password), by using the argument-type password. Change-Id: I2eae1be2e6672bff28ba5f749d7a3f687ebd4631 Reviewed-on: https://code.wireshark.org/review/13385 Reviewed-by: Dario Lombardo <lomato@gmail.com> Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-01-17Fix build [-Werror=maybe-uninitialized]João Valverde1-1/+1
Found building with GCC 5.3.0 and CFLAGS="-g -Og". Change-Id: I5bc29b6e91cc98332a513c9d03b02d2f6906608d Reviewed-on: https://code.wireshark.org/review/13362 Reviewed-by: João Valverde <j@v6e.pt> Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-01-17[Automatic update for 2016-01-17]Gerald Combs13-1949/+1836
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I4aacb3b957cbb04f1848504bfb6880fe010723a3 Reviewed-on: https://code.wireshark.org/review/13356 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-01-15Keep comments from stealing hierarchy statistics.Gerald Combs1-1/+14
If a packet has a comment, the Protocol Hierarchy Statistics dialog will add its stats to a top-level "Packet comments" node instead of the "Frame" node. Add a check for the pkt_comment protocol ID and skip over it if we find it. Affects Wireshark 2.0, 1.12, 1.10, and probably earlier versions. As an alternative we could always force "Frame" to be the first item in the tree. Change-Id: If7cd817071caf6219515f5d8121b3a1a2c0d79a6 Reviewed-on: https://code.wireshark.org/review/13297 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-01-15plugin_if: Add function to get capture file infoPaul Offord3-0/+115
This is an enhancement to allow a plugin to obtain capture file and other status information via a simple plugin_if call Added GTK port to this revision Bug: 11968 Change-Id: Ibcf4e8b43c6f3b48e971fa4020a07cc273234fb8 Reviewed-on: https://code.wireshark.org/review/13103 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-01-15extcap: Add list of extcaps to about dialogRoland Knall1-0/+26
Adds the list of available extcaps to the plugin list in the About dialog of Wireshark (Qt only). To do this, and additional sentence is provided in the extcap arguments list, which allows for additional information to be passed (as of right now, just version and display is used) Additionally, cleans up the code when using g_free. Bug: 11683 Change-Id: I04a958e2b73c9a707ab1cb4f2fc8345833a854a9 Reviewed-on: https://code.wireshark.org/review/13224 Petri-Dish: Roland Knall <rknall@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org> Reviewed-by: Roland Knall <rknall@gmail.com>
2016-01-14Qt: fix Z-order assignment: '' is not a valid widget warningPascal Quantin1-1/+0
Change-Id: Ic9f41f34b017d161f13604cf8813bc70aa7a68d4 Reviewed-on: https://code.wireshark.org/review/13284 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com> Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-14Qt: Separate window titles with Em dash on OS XStig Bjørlykke1-4/+8
The window titles on OS X are usually separated by Em dash, so use this when appending prefs.gui_window_title. Change-Id: Ice46179fc872eefc7662b42052b428eabf1b6d61 Reviewed-on: https://code.wireshark.org/review/13256 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-01-14Qt: Add back setWindowFilePathStig Bjørlykke1-7/+7
With support for prepend and append to the window title. Change-Id: I2215a080b85d36ceb47495bbb94617743fc3f83e Reviewed-on: https://code.wireshark.org/review/13031 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-01-14Fix capture output options.Gerald Combs2-107/+60
Remove the "permanent file" checkbox. We weren't properly checking its value and it was extraneous. Add placeholder text about temporary files. Move the filename above the other options. That's where it is in the GTK+ UI and it's arguably the most important. When capturing to multiple files the size and duration settings aren't mutually exclusive. Change-Id: I1da1d3524e3c2de2361050913281472a172faa3a Reviewed-on: https://code.wireshark.org/review/13269 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-14Qt: "Conversation" → "Coloring"Gerald Combs3-11/+9
Change actionViewColorizeNewConversationRule to actionViewColorizeNewColoringRule and change its text accordingly. We're building a rule based on a general filter, not a conversation. Change-Id: Ic408050eed6f24690e3e759e6963f9930fe4b5e9 Reviewed-on: https://code.wireshark.org/review/13266 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-13Qt: Show the horizontal scrollbar in the packet detail.Gerald Combs1-0/+8
Call resizeColumnToContents when we fill, clear, expand, or contract items. This make sure the horizontal scrollbar shows up instead of eliding items. A commonly suggested solution is to call header()->setSectionResizeMode(QHeaderView::ResizeToContents) followed by header()->setStretchLastSection(false). This makes the scroll bar show up when the tree is wider than the window, but when the column is narrower than the window we end up with unused white space on the right. Change-Id: I5896f6048385bed27858f0ac676b29a1bf1255cd Reviewed-on: https://code.wireshark.org/review/13265 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-01-13Do not apply color rule filter every dissectionPeter Wu2-2/+7
Introduce a frame_data flag "need_colorize" to indicate that coloring rules need to be evaluated and set it for the GUI (not tshark). This restores the original performance characteristics. It additionally fixes a regression where the color filter name and filter is not shown anymore in the tree (I guess it is related to the edt->tree being NULL when re-selected, resulting in empty color_filter). Remaining problems: - Display filter cannot contain frame.coloring_rule.* fields. Code is present to enable this, but then a method is needed to avoid an expensive second calculation (which is why it is disabled). - The columns are still not updated after coloring rule change. - The two frame.coloring_rule fields in the tree are not updated when the coloring rule is changed (e.g. Ctrl-1). The last two issues were supposed to be fixed by the previous patch, but there is probably some missing code... Tested with GTK and Qt. Bug: 11980 Change-Id: I3ef7713b28db242e178d20f6a5f333374718b52e Reviewed-on: https://code.wireshark.org/review/13170 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-13Qt: Update some keyboard shortcuts to match the GTK+ UI.Gerald Combs1-11/+11
As the QKeySequence documentation says, "On Mac OS X, references to "Ctrl", Qt::CTRL, Qt::Control and Qt::ControlModifier correspond to the Command keys on the Macintosh keyboard, and references to "Meta", Qt::META, Qt::Meta and Qt::MetaModifier correspond to the Control keys. Developers on Mac OS X can use the same shortcut descriptions across all platforms, and their applications will automatically work as expected on Mac OS X." This also applies to Qt Creator on OS X. If you assign a shortcut to an action that contains the Control key, it will draw the ^ symbol in the UI but will save "Meta" in the .ui file instead of "Ctrl", in the manner of a well-meaning-but-not-helpful comedy sidekick. This happened for the actions listed below. Replace "Meta" in their shortcuts with "Ctrl". - Unmark all (Ctrl+Alt+M) - Next marked packet (Ctrl+Shift+N) - Previous marked packet (Ctrl+Shift+B) - Show packet times... (Ctrl+Alt+1 - Ctrl+Alt+8) This matches the GTK+ UI on Windows and Linux, and uses the Command key on OS X. If we really want to use the Control key everywhere we can override the action sequences in main_window.cpp. We might want to do this for the "mark" actions since Command+M is the standard key for "Minimize this window". Change-Id: I1537cee5bc27a32b505bace01c1de3703a18dd6a Reviewed-on: https://code.wireshark.org/review/13238 Reviewed-by: Gerald Combs <gerald@wireshark.org> Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016-01-12Need to include <epan/prefs.h> to declare preference functions.Guy Harris1-0/+2
Change-Id: I5fbc9d25dde30ce8d14c80e765a3a8a630fec708 Reviewed-on: https://code.wireshark.org/review/13239 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-12Fix type: strlen returns a size_tEvan Huus1-1/+1
Change-Id: I5a3ea655c4a362bbacb72e8c7a19f3c96d22a0fc Reviewed-on: https://code.wireshark.org/review/13231 Reviewed-by: Evan Huus <eapache@gmail.com>
2016-01-12Refactor "Follow Stream" functionality on all GUI interfaces.Michael Mann25-2957/+721
Create a "registration" system for Follow functionality so most of the work can be abstracted into a dissector and GUI can just be responsible for "display". This also removes the global variables in follow.c to open up multithreading possibilities. TCP, UDP and HTTP all have the same "tap interface" for Follow functionality (passing a tvb with byte data to "follow"). SSL still has it's own behavior, so Follow structures have to take that into account. TShark through the Follow registration now has support for HTTP. The only thing possibly missing is dynamic menu generation to further reduce explicit knowledge of Follow "type" (and rely on registration) Bug: 11988 Change-Id: I559d9ee1312406ad0986d4dce9fa67ea2103b339 Reviewed-on: https://code.wireshark.org/review/13161 Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-12Qt: Refactor testCaptureFileCloseStig Bjørlykke3-28/+39
Cleanup arguments and simplify code for button texts. Change-Id: Ie505650889212082e088a525f4b82e62b9177b0d Reviewed-on: https://code.wireshark.org/review/13180 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-01-12Fix indentation.Guy Harris1-1/+1
Change-Id: Icefabed4c9069bb3fe015739c805cd8fb2426ea5 Reviewed-on: https://code.wireshark.org/review/13213 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-12Move some definitions and declarations around.Guy Harris2-80/+0
This removes duplicates (including one incorrect duplicate), and also means we have only one chunk_type_values[] value_string. Change-Id: I4c3035b1cfb5c86cc7a5bf79feb9a5b0204b6dcc Reviewed-on: https://code.wireshark.org/review/13212 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-12Add some missing curly braces.Guy Harris1-1/+2
Change-Id: Ifcacd1fedd8c71d47ab618d036765b8195d4ccbb Reviewed-on: https://code.wireshark.org/review/13209 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-12Fix indentation.Guy Harris1-3/+3
Change-Id: I5b01865b33b65ee55718be680b6d17cdeee1a809 Reviewed-on: https://code.wireshark.org/review/13208 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-11Lua: Added reload_lua_pluginsStig Bjørlykke9-29/+62
This makes it possible to trigger reloading Lua plugins from within a Lua plugin. This can be used when having a plugin to update local plugins from a external source. Renamed reload() to reload_packets() to clarify what's reloaded, and added a alias (marked as obsoleted) from reload(). Change-Id: I4e529992af5f651613950329e73718dbda317d2e Reviewed-on: https://code.wireshark.org/review/13024 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-01-10Qt: Restore the filename in the status bar.Gerald Combs1-4/+12
Change isNull checks to isEmpty. This keeps us from pushing an empty field status and clobbering the file name in the status bar. Make sure we do the same for other statuses. Change-Id: I68ea669bdafc6e1177c1b8aaa07781464371de96 Reviewed-on: https://code.wireshark.org/review/13175 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-01-10Qt: Fix testCaptureFileClose without packetsStig Bjørlykke2-35/+25
In MainWindow::testCaptureFileClose() we must always stop a running capture if closing, even if not having any packets, because cf_close() will fail (assert) if still in progress. This fixes an issue (crash) when closing the application with a running capture without packets. This also fixes restarting current capture without packets, both with and without "Confirm unsaved capture files". Bug: 11981 Change-Id: Id0655fcc799682a4f45c855bc2e76386dffc35a5 Reviewed-on: https://code.wireshark.org/review/13121 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-01-10Add a comment about improvements for the OverlayScrollBar.Gerald Combs1-0/+4
Change-Id: I2953deaa29691a2d12cb158456a650202dfeec77 Reviewed-on: https://code.wireshark.org/review/13171 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-01-10Update the packet list documentation.Gerald Combs1-0/+4
Update images and describe related packets and the intelligent scrollbar. Suggest a way to make it easier to get a screenshot of related packets. Change-Id: I5bf27b0c53fb62f3e567765400141a374a465e4e Reviewed-on: https://code.wireshark.org/review/13159 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-01-10[Automatic update for 2016-01-10]Gerald Combs13-1011/+996
Update manuf, services enterprise-numbers, translations, and other items. Change-Id: I2087677da0b09293ff156e39acbdbab8486262f4 Reviewed-on: https://code.wireshark.org/review/13167 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-01-10GTK: fix infinite loop at startupPeter Wu1-3/+3
Add the tap timer after validating all preferences, otherwise a zero timeout will result in an infinite loop, visible by a splash screen that never goes away. Change-Id: I180a123ac2cc7774356e17f1f1d4dcaf38f252b4 Reviewed-on: https://code.wireshark.org/review/13156 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-10Qt: fix infinite loop when gui_recent_files_count_max is negativePeter Wu1-1/+1
Change-Id: I7cfddd865ebe0cd01230e19bf20fee7964c40324 Reviewed-on: https://code.wireshark.org/review/13155 Reviewed-by: Peter Wu <peter@lekensteyn.nl> Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Anders Broman <a.broman58@gmail.com>
2016-01-09Qt: Save the default capture device name.Gerald Combs1-1/+10
Make sure we save the device name in capture.device. This should fix the default device selection in the welcome screen on Windows. Change-Id: I19337cf2813f3b5aba75228e855dad0a0f5e0f78 Reviewed-on: https://code.wireshark.org/review/13138 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-01-08Revert "Qt: Try to fix Main Welcome Interfaces List Scrollbar"Gerald Combs4-14/+11
Instead of calling InterfaceTree::reset (which clears our selection) when we resize, just pass our resize event to QTreeWidget. Additionally, select our default interface using setCurrentItem. This fixes behavior broken in gb152ca3. This reverts commit 7baac67149a68b66087c5d688dbeda2869485765. Bug: 11733 Change-Id: I58855de38561fcb6984273ae3910c0dfcda04e69 Reviewed-on: https://code.wireshark.org/review/13135 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-01-08Qt: Queue up redissection.Gerald Combs1-1/+1
Make the WiresharkApplication::packetDissectionChanged → MainWindow::redissectPackets connection queued rather than direct. redissectPackets eventually calls update_progress_dlg, which processes UI events. This should keep the profile dialog from destroying itself prematurely in a nested event loop when the user hits "OK". Bug: 11979 Change-Id: I7276e08c1911708c3aca5ff05ab6a40bfc336add Reviewed-on: https://code.wireshark.org/review/13134 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-01-08Fix a lot of typos and misspellingsmoshekaplan1-2/+2
Change-Id: I8512cfa1d424f82a873a0e0e1d22c7b075fdd7f3 Reviewed-on: https://code.wireshark.org/review/13069 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com> Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
2016-01-08Add a Busy status to SyntaxLineEdit.Gerald Combs8-50/+89
For CaptureFilterEdit it's possible to have an indeterminate state while we're waiting on name resolution. Add a Busy status to SyntaxLineEdit and set the text color to a mix of the normal foreground and background colors (gray on most platforms). Make the Busy state valid so that we don't have to wait on an annoyingly-long name resolution to start capturing. Update the global capture option filters using the main welcome capture filter when we start a capture instead of when we've finished checking the filter syntax. Connect the CaptureFilterEdit returnPressed signal no matter what so that we can start a capture by pressing return in the welcome screen CaptureFilterEdit. Add a fake resolution timeout to the CaptureFilterSyntaxWorker debug code to make testing the different states easier. Bug: 11950 Change-Id: I0cf01c0fbc0dd8065cdf5a91f1d6b224291b1ce6 Reviewed-on: https://code.wireshark.org/review/13110 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-01-08QT: add same warning as GTK when trying to save a decoded RTP stream that is ↵Pascal Quantin1-0/+10
not alaw/ulaw Change-Id: Ia11e58a20c879d1ca3ead8479f8082e204d92caf Reviewed-on: https://code.wireshark.org/review/13131 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2016-01-08Fix warnings for epan/prefs.c [-Wcast-qual]João Valverde1-2/+2
Change-Id: I86032d624ee37edc86a868eb2aaaffce81a8807b Reviewed-on: https://code.wireshark.org/review/12719 Petri-Dish: João Valverde <j@v6e.pt> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: João Valverde <j@v6e.pt>
2016-01-07Qt: Sort traffic table default protosStig Bjørlykke1-2/+2
When changing conversation types in Conversations and endpoint types in Endpoints the tabs will be arranged alphabetically, so ensure that the default protos also are alphabetically. Change-Id: Ib0e8ffb744f63867e93282b7a81b1c11b0ee3dc4 Reviewed-on: https://code.wireshark.org/review/13107 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2016-01-07Don't include much of anything if HAVE_LIBPCAP isn't defined.Guy Harris1-2/+4
We don't need it. Change-Id: Idca29cbd7208c388a1f5d4e2b0131f5cfddc7896 Reviewed-on: https://code.wireshark.org/review/13096 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-07"#ifdef" out a definition not used if HAVE_LIBPCAP isn't defined.Guy Harris1-0/+2
Change-Id: Ifc0f89706c0633925c57d1fed3a56c7e531a3b39 Reviewed-on: https://code.wireshark.org/review/13095 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2016-01-07Qt: Add recent capture filter entries.Gerald Combs1-1/+17
Copy over and adapt missing logic from the GTK+ UI which adds recent capture filter entries when we start a capture. Change-Id: Ifcf8b719e53727b7c269d9890731d542d1759efc Ping-Bug: 11950 Reviewed-on: https://code.wireshark.org/review/13086 Petri-Dish: Gerald Combs <gerald@wireshark.org> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Gerald Combs <gerald@wireshark.org>
2016-01-07Remove some unnecessary dependencies and cleanup some codeJoão Valverde7-75/+43
No need for the GTK dependency on dissectors/packet-ipv6.h. Add the stream_addr typedef in follow.h to make some code simpler. Change-Id: I1cf906f58734a90263141362f2da33a140f93533 Reviewed-on: https://code.wireshark.org/review/13063 Reviewed-by: João Valverde <j@v6e.pt> Petri-Dish: Michael Mann <mmann78@netscape.net> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Michael Mann <mmann78@netscape.net>
generated by cgit v1.2.1 (git 2.18.0) at 2024-07-02 19:42:29 +0000