From 7b69c8702b30e76189a652b7853643fdbc506a22 Mon Sep 17 00:00:00 2001 From: Guy Harris Date: Tue, 24 Jan 2017 01:15:24 -0800 Subject: Add a comment talking about the dictionary file format. Point to the FreeRADIUS man page for the dictionary file format, and mention features we don't support - including features *not* documented in the man page. Change-Id: I08085062a6abcafb9dd0abe5b1edee53187ea23f Reviewed-on: https://code.wireshark.org/review/19762 Reviewed-by: Guy Harris --- epan/radius_dict.l | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/epan/radius_dict.l b/epan/radius_dict.l index 2d446b1a8e..6ca0008dfb 100644 --- a/epan/radius_dict.l +++ b/epan/radius_dict.l @@ -92,6 +92,33 @@ #include #include +/* + * See + * + * http://freeradius.org/radiusd/man/dictionary.html + * + * for the format of RADIUS dictionary files. + * + * XXX - features not currently supported: + * + * dotted number values for the oid field; + * + * integer64, ipv4prefix, combo-prefix, bool, size, decimal, + * timeval, struct, extended, long-extended, vsa, evs, vendor, + * cidr, uint{8,16,32,64}, int{8,16,32,64} as attribute types + * (some of these aren't documented); + * + * octets[N], where N is an integer, as an attribute type + * (not documented in the man page); + * + * internal, array, concat, and virtual as attribute flags; + * + * format= for BEGIN-VENDOR. + * + * We should, perhaps, adopt FreeRADIUS's dictionary-parsing code in + * src/lib/dict.c and use that, rather than writing our own parser. + * See bug 13176. + */ #define YY_USER_INIT BEGIN WS_OUT; #ifdef _WIN32 -- cgit v1.2.1