From 9f600384e8c113c43a069d491a7482c402c1ea8d Mon Sep 17 00:00:00 2001 From: Peter Wu Date: Wed, 25 Jan 2017 15:35:09 +0100 Subject: sharkd: fix potential division-by-zero issue The interval parameter is user-supplied and is used as divisor. Change-Id: I9cbbecb71da3991c1712cb87e93de072cc950224 Reviewed-on: https://code.wireshark.org/review/19787 Petri-Dish: Peter Wu Tested-by: Petri Dish Buildbot Reviewed-by: Jakub Zawadzki --- sharkd_session.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/sharkd_session.c b/sharkd_session.c index e6d0c4b740..2903d83108 100644 --- a/sharkd_session.c +++ b/sharkd_session.c @@ -1338,8 +1338,12 @@ sharkd_session_process_intervals(char *buf, const jsmntok_t *tokens, int count) gint64 idx; gint64 max_idx = 0; - if (tok_interval) - (void) ws_strtou32(tok_interval, NULL, &interval_ms); + if (tok_interval) { + if (!ws_strtou32(tok_interval, NULL, &interval_ms) || interval_ms == 0) { + fprintf(stderr, "Invalid interval parameter: %s.\n", tok_interval); + return; + } + } if (tok_filter) { -- cgit v1.2.1