From e10bd6b22394a2a3cd65689a3f404df0f7661cbe Mon Sep 17 00:00:00 2001 From: Guy Harris Date: Tue, 24 Nov 2015 21:38:05 -0800 Subject: Check whether create_tempfile() fails. Thanks and a tip of the Hatlo hat to Coverity for finding this. Change-Id: Ie9d4089443e52ef427e0cc8ae6e90a9d9787134e Reviewed-on: https://code.wireshark.org/review/12123 Reviewed-by: Guy Harris (cherry picked from commit e9c26d015bde3ca5e5bf858ddb266a70d6751b7d) Reviewed-on: https://code.wireshark.org/review/12124 --- wiretap/file_access.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/wiretap/file_access.c b/wiretap/file_access.c index f502c18dec..71e25805fd 100644 --- a/wiretap/file_access.c +++ b/wiretap/file_access.c @@ -2280,6 +2280,11 @@ wtap_dump_open_tempfile_ng(char **filenamep, const char *pfx, /* Choose a random name for the file */ fd = create_tempfile(&tmpname, pfx); + if (fd == -1) { + *err = errno; + g_free(wdh); + return NULL; /* can't create file */ + } *filenamep = tmpname; /* In case "fopen()" fails but doesn't set "errno", set "errno" -- cgit v1.2.1