From cda450ed591d73aab366569eb748659f194e7168 Mon Sep 17 00:00:00 2001 From: Evan Huus Date: Wed, 2 Dec 2015 16:52:35 -0500 Subject: Fix address hashing broken in g4f39c60 We actually have to *use* the return value of the method, which the macro did for us. Change-Id: I240ca7e526a18054fe39c6c4ded902998dc2fef0 Reviewed-on: https://code.wireshark.org/review/12389 Petri-Dish: Evan Huus Reviewed-by: Anders Broman Reviewed-by: Jim Young Tested-by: Petri Dish Buildbot Reviewed-by: Evan Huus --- epan/conversation.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) (limited to 'epan/conversation.c') diff --git a/epan/conversation.c b/epan/conversation.c index 0f48edc9ec..b6912e7689 100644 --- a/epan/conversation.c +++ b/epan/conversation.c @@ -197,15 +197,15 @@ conversation_hash_exact(gconstpointer v) hash_val = 0; tmp_addr.len = 4; - add_address_to_hash(hash_val, &key->addr1); + hash_val = add_address_to_hash(hash_val, &key->addr1); tmp_addr.data = &key->port1; - add_address_to_hash(hash_val, &tmp_addr); + hash_val = add_address_to_hash(hash_val, &tmp_addr); - add_address_to_hash(hash_val, &key->addr2); + hash_val = add_address_to_hash(hash_val, &key->addr2); tmp_addr.data = &key->port2; - add_address_to_hash(hash_val, &tmp_addr); + hash_val = add_address_to_hash(hash_val, &tmp_addr); hash_val += ( hash_val << 3 ); hash_val ^= ( hash_val >> 11 ); @@ -280,13 +280,13 @@ conversation_hash_no_addr2(gconstpointer v) hash_val = 0; tmp_addr.len = 4; - add_address_to_hash(hash_val, &key->addr1); + hash_val = add_address_to_hash(hash_val, &key->addr1); tmp_addr.data = &key->port1; - add_address_to_hash(hash_val, &tmp_addr); + hash_val = add_address_to_hash(hash_val, &tmp_addr); tmp_addr.data = &key->port2; - add_address_to_hash(hash_val, &tmp_addr); + hash_val = add_address_to_hash(hash_val, &tmp_addr); hash_val += ( hash_val << 3 ); hash_val ^= ( hash_val >> 11 ); @@ -345,12 +345,12 @@ conversation_hash_no_port2(gconstpointer v) hash_val = 0; tmp_addr.len = 4; - add_address_to_hash(hash_val, &key->addr1); + hash_val = add_address_to_hash(hash_val, &key->addr1); tmp_addr.data = &key->port1; - add_address_to_hash(hash_val, &tmp_addr); + hash_val = add_address_to_hash(hash_val, &tmp_addr); - add_address_to_hash(hash_val, &key->addr2); + hash_val = add_address_to_hash(hash_val, &key->addr2); hash_val += ( hash_val << 3 ); hash_val ^= ( hash_val >> 11 ); @@ -409,10 +409,10 @@ conversation_hash_no_addr2_or_port2(gconstpointer v) hash_val = 0; tmp_addr.len = 4; - add_address_to_hash(hash_val, &key->addr1); + hash_val = add_address_to_hash(hash_val, &key->addr1); tmp_addr.data = &key->port1; - add_address_to_hash(hash_val, &tmp_addr); + hash_val = add_address_to_hash(hash_val, &tmp_addr); hash_val += ( hash_val << 3 ); hash_val ^= ( hash_val >> 11 ); -- cgit v1.2.1