From 56d8797c9eff6b710b29f5ffd0618bfb5e96ea86 Mon Sep 17 00:00:00 2001 From: Evan Huus Date: Tue, 8 Oct 2013 01:09:51 +0000 Subject: Don't try and fetch the repeat value of slot 0, since it makes us underflow the array we're accessing. Fixes the uninitialized value errors in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9243 svn path=/trunk/; revision=52445 --- epan/dissectors/packet-gsm_cbch.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'epan/dissectors/packet-gsm_cbch.c') diff --git a/epan/dissectors/packet-gsm_cbch.c b/epan/dissectors/packet-gsm_cbch.c index 8c253cd90c..0af0228d82 100644 --- a/epan/dissectors/packet-gsm_cbch.c +++ b/epan/dissectors/packet-gsm_cbch.c @@ -214,7 +214,13 @@ dissect_schedule_message(tvbuff_t *tvb, packet_info *pinfo, proto_tree *top_tree else if ((octet1 & 0xC0) == 0) { /* MDT 00 */ - if (octet1 < new_slots[i]) + if (octet1 == 0) + { + proto_tree_add_text(sched_subtree, tvb, offset++, 1, + "Slot: %d, Repeat of non-existant slot %d", + new_slots[i], octet1); + } + else if (octet1 < new_slots[i]) { proto_tree_add_text(sched_subtree, tvb, offset++, 1, "Slot: %d, Message ID: %d, Repeat of Slot %d", -- cgit v1.2.1