From b38ee917b1953104c615056481d6df008ae94b53 Mon Sep 17 00:00:00 2001 From: Michael Mann Date: Sun, 15 Sep 2013 01:48:30 +0000 Subject: Convert proto_tree_add_uint_format to proto_tree_add_uint_format_value if hf_ field name is the first part of the formatted string. This was done with a perl script on the dissectors directory (packet-*.c), followed by manual inspection of the output. The manual inspection yielded a few cases that really should have been proto_tree_add_uint or proto_tree_add_item, so I updated them accordingly. The script didn't catch as many as I would have liked, but it's a start. The most common (ab)use of proto_tree_add_uint_format was for appending strings to CRC/checksum values to note good or bad CRC/checksum. svn path=/trunk/; revision=52045 --- epan/dissectors/packet-igmp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'epan/dissectors/packet-igmp.c') diff --git a/epan/dissectors/packet-igmp.c b/epan/dissectors/packet-igmp.c index 59dc37b4e7..9506a6ca4b 100644 --- a/epan/dissectors/packet-igmp.c +++ b/epan/dissectors/packet-igmp.c @@ -782,8 +782,8 @@ dissect_igmp_mtrace(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, int typ if (blocks) col_append_str(pinfo->cinfo, COL_INFO, blocks); - proto_tree_add_uint_format(tree, hf_type, tvb, offset, 1, type, - "Type: %s (0x%02x)", typestr, type); + proto_tree_add_uint_format_value(tree, hf_type, tvb, offset, 1, type, + "%s (0x%02x)", typestr, type); offset += 1; /* maximum number of hops that the requester wants to trace */ -- cgit v1.2.1