From 0ad98563a24b8685545825aac889ef43bfc58809 Mon Sep 17 00:00:00 2001 From: Bill Meier Date: Tue, 29 Oct 2013 14:09:20 +0000 Subject: From didier gautheron: remove redundant or use faster col_xxx functions - when the text parameter is constant col_add_str() and col_set_str() are equivalent but col_set_str() is faster. - same for replace col_append_fstr and col_append_str - remove col_clear() when it's redundant: + before a col_set/col_add if the dissector can't throw an exception. - replace col_append() after a col_clear() with faster col_add... or col_set https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9344 svn path=/trunk/; revision=52948 --- epan/dissectors/packet-nsip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'epan/dissectors/packet-nsip.c') diff --git a/epan/dissectors/packet-nsip.c b/epan/dissectors/packet-nsip.c index 386fd2168d..22b475bb82 100644 --- a/epan/dissectors/packet-nsip.c +++ b/epan/dissectors/packet-nsip.c @@ -986,7 +986,7 @@ dissect_nsip(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree) { } if (!nsip_is_recursive) { - col_add_str(pinfo->cinfo, COL_INFO, + col_set_str(pinfo->cinfo, COL_INFO, val_to_str_const(pdu_type, tab_nsip_pdu_types, "Unknown PDU type")); } else { col_append_sep_fstr(pinfo->cinfo, COL_INFO, NSIP_SEP, "%s", -- cgit v1.2.1