From cd3cca7edca2c52fea2afce5f248370f5fdcbd4f Mon Sep 17 00:00:00 2001 From: Gerald Combs Date: Fri, 10 Aug 2012 20:33:01 +0000 Subject: Make the corresponding packet_info available to each tree item. This lets us pass a NULL pinfo to expert_add_info_format() and expert_add_undecoded_item(), which makes it possible to use those routines deep in the bowels of many dissectors. As a proof of concept remove the recent pinfo additions to packet-afp.c. This should also make it easier to fix bug 3884. svn path=/trunk/; revision=44435 --- epan/expert.h | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) (limited to 'epan/expert.h') diff --git a/epan/expert.h b/epan/expert.h index 4db64ad66f..86478bb66d 100644 --- a/epan/expert.h +++ b/epan/expert.h @@ -63,11 +63,12 @@ expert_get_highest_severity(void); /** Add an expert info. Add an expert info tree to a protocol item, with classification and message. - @param pinfo packet info of the currently processed packet - @param pi current protocol item (or NULL) - @param group the expert group (like PI_CHECKSUM - see: proto.h) - @param severity the expert severity (like PI_WARN - see: proto.h) - @param format printf like format string with further infos + @param pinfo Packet info of the currently processed packet. May be NULL if + pi is supplied + @param pi Current protocol item (or NULL) + @param group The expert group (like PI_CHECKSUM - see: proto.h) + @param severity The expert severity (like PI_WARN - see: proto.h) + @param format Printf-style format string for additional arguments */ extern void expert_add_info_format(packet_info *pinfo, proto_item *pi, int group, @@ -76,12 +77,12 @@ expert_add_info_format(packet_info *pinfo, proto_item *pi, int group, /** Add an expert info about not dissected "item" Add an expert info tree to a not dissected protocol item. - @patam tvb the tvb with the item. - @param pinfo packet info of the currently processed packet - @param tree tree to add the item to - @param offset in tvb - @param length the length of the item. - @param severity the expert severity (like PI_WARN - see: proto.h) + @patam tvb The tvb associated with the item. + @param pinfo Packet info of the currently processed packet. May be NULL. + @param tree Tree to add the item to + @param offset Offset in tvb + @param length The length of the item. + @param severity The expert severity (like PI_WARN - see: proto.h) */ extern void -- cgit v1.2.1