From 859511db14feae071cc1e6e1889ae39bfd276faa Mon Sep 17 00:00:00 2001 From: Guy Harris Date: Tue, 17 Feb 2015 16:40:28 -0800 Subject: Make UAT record update callbacks return a success/failure indication. Have them return TRUE on success and FALSE on failure. Check the return value rather than whether the error string pointer is null or not. Change-Id: I800a03bcd70a6bbb7b217cf7c4800e9cdcf2189c Reviewed-on: https://code.wireshark.org/review/7222 Reviewed-by: Guy Harris --- epan/uat_load.l | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) (limited to 'epan/uat_load.l') diff --git a/epan/uat_load.l b/epan/uat_load.l index b9e8ee9a23..43452fc701 100644 --- a/epan/uat_load.l +++ b/epan/uat_load.l @@ -249,12 +249,11 @@ comment #[^\n]*\n rec = uat_add_record(uat, record, valid_record); - if ((uat->update_cb) && (rec != NULL)) - uat->update_cb(rec,&err); - - if (err) { - error = err; - yyterminate(); + if ((uat->update_cb) && (rec != NULL)) { + if (!uat->update_cb(rec,&err)) { + error = err; + yyterminate(); + } } valid_record = TRUE; -- cgit v1.2.1