From 9128e43745bbb1ba48b031a862a952b093aa9e76 Mon Sep 17 00:00:00 2001 From: Evan Huus Date: Sun, 5 Oct 2014 21:25:19 -0400 Subject: tcp: default no-subdissector-on-error to TRUE Dissectors that need this set break badly when it isn't. Dissectors which don't need this set will still generally be understandable without it, since e.g. retransmissions will link to the original packet at the TCP layer, and presumably the subdissector payload is exactly the same in that case. Change-Id: I2871c2a90c601637bdfb8cffaa34a7407995c603 Ping-Bug: 10525 Ping-Bug: 10289 Reviewed-on: https://code.wireshark.org/review/4487 Reviewed-by: Evan Huus --- epan/dissectors/packet-tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'epan') diff --git a/epan/dissectors/packet-tcp.c b/epan/dissectors/packet-tcp.c index a6bf163d2f..39f4d38d51 100644 --- a/epan/dissectors/packet-tcp.c +++ b/epan/dissectors/packet-tcp.c @@ -333,7 +333,7 @@ static expert_field ei_tcp_urgent_pointer_non_zero = EI_INIT; * This preference can be set for such protocols to make sure that we don't * invoke the subdissectors for retransmitted or out-of-order segments. */ -static gboolean tcp_no_subdissector_on_error = FALSE; +static gboolean tcp_no_subdissector_on_error = TRUE; /* * FF: (draft-ietf-tcpm-experimental-options-03) -- cgit v1.2.1