From 2009dcc98dc46712c8b64ae30408c4d53c64980b Mon Sep 17 00:00:00 2001 From: Peter Wu Date: Sat, 7 Jan 2017 00:14:23 +0100 Subject: extcap: fix memleak via data_file_url Commit v2.1.0rc0-2181-ga4e2263ac4 introduced a helppage parameter, but all callers were NULL. In a later change, callers would use the data_file_url() function, but this needs to be freed, so do that. Fixes: v2.3.0rc0-1825-ge5596b74bd ("extcap: set help page for all extcaps.") Change-Id: I967c0f8c6b50d9e78ac227575de24a81f97d376a Reviewed-on: https://code.wireshark.org/review/19570 Petri-Dish: Dario Lombardo Tested-by: Petri Dish Buildbot Reviewed-by: Dario Lombardo --- extcap/udpdump.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'extcap/udpdump.c') diff --git a/extcap/udpdump.c b/extcap/udpdump.c index adfa514c69..415fc3d986 100644 --- a/extcap/udpdump.c +++ b/extcap/udpdump.c @@ -351,6 +351,7 @@ int main(int argc, char *argv[]) guint16 port = 0; int ret = EXIT_FAILURE; extcap_parameters* extcap_conf = g_new0(extcap_parameters, 1); + char* help_url; char* help_header = NULL; char* payload = NULL; char* port_msg = NULL; @@ -359,8 +360,10 @@ int main(int argc, char *argv[]) attach_parent_console(); #endif /* _WIN32 */ + help_url = data_file_url("udpdump.html"); extcap_base_set_util_info(extcap_conf, argv[0], UDPDUMP_VERSION_MAJOR, UDPDUMP_VERSION_MINOR,UDPDUMP_VERSION_RELEASE, - data_file_url("udpdump.html")); + help_url); + g_free(help_url); extcap_base_register_interface(extcap_conf, UDPDUMP_EXTCAP_INTERFACE, "UDP Listener remote capture", 252, "Exported PDUs"); help_header = g_strdup_printf( -- cgit v1.2.1