From 6a480953a956a2486e0b618bb02bed56faeac7bf Mon Sep 17 00:00:00 2001
From: Laurent Deniel <laurent.deniel@free.fr>
Date: Fri, 11 Aug 2000 13:37:21 +0000
Subject: Miscellaneous code cleaning

- add <stdarg.h> or <varargs.h> in snprintf.h
  and remove those inclusions in the other #ifdef NEED_SNPRINTF_H codes

- remove the check of multiple inclusions in source (.c)  code
  (there is a bit loss of _cpp_ performance, but I prefer the gain of
   code reading and maintenance; and nowadays, disk caches and VM are
   correctly optimized ;-).

- protect all (well almost) header files against multiple inclusions

- add header (i.e. GPL license) in some include files

- reorganize a bit the way header files are included:

  First:
  #include <system_include_files>
  #include <external_package_include_files (e.g. gtk, glib etc.)>
  Then
  #include "ethereal_include_files"

  with the correct HAVE_XXX or NEED_XXX protections.

- add some HAVE_XXX checks before including some system header files

- add the same HAVE_XXX in wiretap as in ethereal

Please forgive me, if I break something (I've only compiled and regression
tested on Linux).

svn path=/trunk/; revision=2254
---
 globals.h | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

(limited to 'globals.h')

diff --git a/globals.h b/globals.h
index 265f8af0f8..ce1847a8d0 100644
--- a/globals.h
+++ b/globals.h
@@ -1,7 +1,7 @@
 /* globals.h
  * Global defines, etc.
  *
- * $Id: globals.h,v 1.19 2000/08/03 12:44:21 gram Exp $
+ * $Id: globals.h,v 1.20 2000/08/11 13:34:29 deniel Exp $
  *
  * Ethereal - Network traffic analyzer
  * By Gerald Combs <gerald@zing.org>
@@ -26,21 +26,10 @@
 #ifndef __GLOBALS_H__
 #define __GLOBALS_H__
 
-#ifndef _STDIO_H_
 #include <stdio.h>
-#endif
-
-#ifndef __PACKET_H__
 #include "packet.h"
-#endif
-
-#ifndef __FILE_H__
 #include "file.h"
-#endif
-
-#ifndef __TIMESTAMP_H__
 #include "timestamp.h"
-#endif
 
 #define MIN_PACKET_SIZE 68	/* minimum amount of packet data we can read */
 
-- 
cgit v1.2.1