From 7be155ee1ec61166bdf1a525902c05b378c75b66 Mon Sep 17 00:00:00 2001 From: Gerald Combs Date: Fri, 24 Jul 2015 10:24:15 -0700 Subject: Try deleting WiresharkDialog when we close it. QDialog::accept and ::reject hide the dialog but don't delete it. In the case of WiresharkDialog and its subclasses we might leak memory or leave files open. Call deleteLater when we close the dialog. Change-Id: Ie0b848a7deeeee4667925b0d886e498f13a86bfc Reviewed-on: https://code.wireshark.org/review/9781 Petri-Dish: Gerald Combs Tested-by: Petri Dish Buildbot Reviewed-by: Gerald Combs --- ui/qt/rtp_analysis_dialog.cpp | 8 -------- 1 file changed, 8 deletions(-) (limited to 'ui/qt/rtp_analysis_dialog.cpp') diff --git a/ui/qt/rtp_analysis_dialog.cpp b/ui/qt/rtp_analysis_dialog.cpp index ab94ba3b15..f7d4b79c18 100644 --- a/ui/qt/rtp_analysis_dialog.cpp +++ b/ui/qt/rtp_analysis_dialog.cpp @@ -465,14 +465,6 @@ RtpAnalysisDialog::~RtpAnalysisDialog() delete rev_tempfile_; } -// XXX Should we do this in WiresharkDialog? -void RtpAnalysisDialog::reject() -{ - // We need to make sure our temporary files are closed. - deleteLater(); - WiresharkDialog::reject(); -} - void RtpAnalysisDialog::updateWidgets() { bool enable_tab = false; -- cgit v1.2.1