From 583c2504671e1671afd03e7638cf6c2957d2b020 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stig=20Bj=C3=B8rlykke?= Date: Mon, 19 Jun 2017 10:30:35 -0400 Subject: Qt: Flush signals when disable protocols MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When opening the enabled protocols dialog from a protocol preferences menu we must flush app signals to ensure a redissect is done. Change-Id: I512b8f6959aabcc15ccffc67615583ee9c60ceec Reviewed-on: https://code.wireshark.org/review/22224 Petri-Dish: Stig Bjørlykke Tested-by: Petri Dish Buildbot Reviewed-by: Stig Bjørlykke --- ui/qt/protocol_preferences_menu.cpp | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'ui') diff --git a/ui/qt/protocol_preferences_menu.cpp b/ui/qt/protocol_preferences_menu.cpp index 96543c586d..cd708bbcf9 100644 --- a/ui/qt/protocol_preferences_menu.cpp +++ b/ui/qt/protocol_preferences_menu.cpp @@ -260,6 +260,10 @@ void ProtocolPreferencesMenu::disableProtocolTriggered() enable_proto_dialog.selectProtocol(protocol_); hide(); enable_proto_dialog.exec(); + + // Emitting PacketDissectionChanged directly from a QDialog can cause + // problems on macOS. + wsApp->flushAppSignals(); } void ProtocolPreferencesMenu::modulePreferencesTriggered() -- cgit v1.2.1