From f87d596b69e9889cb1ca7a4f0294fe2f91d2fca0 Mon Sep 17 00:00:00 2001 From: Peter Wu Date: Wed, 8 Apr 2015 11:31:24 +0200 Subject: Fix clickable box + ellipsis overflow --- js/curriculum.js | 12 ++++++++++-- style/curriculum.less | 5 ----- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/js/curriculum.js b/js/curriculum.js index a93b2e4..664df46 100644 --- a/js/curriculum.js +++ b/js/curriculum.js @@ -41,15 +41,23 @@ define(['courses'], function(courses) { course_item.dataset.type = course.type || 'major'; course_item.title = course.name; + var label = document.createElement('span'); + label.textContent = course.name; + // display link for courses which have a description block if (course.id) { var link = document.createElement('a'); link.href = '#/curriculum/' + course.id; - link.textContent = course.name; + link.appendChild(label); course_item.appendChild(link); } else { - course_item.textContent = course.name; + course_item.appendChild(label); } + + // HACK: this need to be fixed in CSS! + course_item.addEventListener('click', function() { + location.href = '#/curriculum/' + course.id; + }); })); var citems = document.getElementById('curriculum-items'); diff --git a/style/curriculum.less b/style/curriculum.less index c909db1..7ad46b0 100644 --- a/style/curriculum.less +++ b/style/curriculum.less @@ -46,11 +46,6 @@ body[data-page="curriculum"] #curriculum-menu { &[data-type="bep"] { background-color: @color-bep-background; } - - a { - width: 100%; - display: inline-block; - } } } } -- cgit v1.2.1