diff options
author | Peter Wu <peter@lekensteyn.nl> | 2014-11-06 18:29:07 +0100 |
---|---|---|
committer | Richard Hughes <richard@hughsie.com> | 2014-11-26 11:56:05 +0000 |
commit | 71cbf8dfb943a674cb5a746e0e4cbd4b226e8f04 (patch) | |
tree | 7156d11fcb3b42cc65a217538ab9eb3b4f764f6d | |
parent | b3e5143f5a56beee63529fd25b44522ae282e226 (diff) | |
download | upower-71cbf8dfb943a674cb5a746e0e4cbd4b226e8f04.tar.gz |
linux: fix memleak when reading critical action
g_variant_get for string types must be freed as documented at
https://developer.gnome.org/glib/stable/gvariant-format-strings.html#gvariant-format-strings-strings
Since we just want to compare it, use a pointer as documented at
https://developer.gnome.org/glib/stable/gvariant-format-strings.html#gvariant-format-strings-pointers
https://bugs.freedesktop.org/show_bug.cgi?id=82659
-rw-r--r-- | src/linux/up-backend.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/linux/up-backend.c b/src/linux/up-backend.c index f588e74..f45ce29 100644 --- a/src/linux/up-backend.c +++ b/src/linux/up-backend.c @@ -346,7 +346,7 @@ check_action_result (GVariant *result) if (result) { const char *s; - g_variant_get (result, "(s)", &s); + g_variant_get (result, "(&s)", &s); if (g_strcmp0 (s, "yes") == 0) return TRUE; } |