From 7f3c4f01909687c7fdd6ab2e7b5b855bb7b4772f Mon Sep 17 00:00:00 2001 From: Peter Wu Date: Mon, 17 Nov 2014 21:44:27 +0100 Subject: daemon: plug huge memleak in GetStatistics Reproducible by executing `upower -d` or by calling the DBus method org.freedesktop.UPower.Device.GetStatistics(charging). up_device_get_statistics -> up_history_get_profile_data -> up_stats_item_new. https://bugs.freedesktop.org/show_bug.cgi?id=82659 --- src/up-history.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/up-history.c b/src/up-history.c index 4ed55fc..1d41c2c 100644 --- a/src/up-history.c +++ b/src/up-history.c @@ -299,7 +299,7 @@ up_history_get_profile_data (UpHistory *history, gboolean charging) g_return_val_if_fail (UP_IS_HISTORY (history), NULL); /* create 100 item list and set to zero */ - data = g_ptr_array_new (); + data = g_ptr_array_new_full (101, g_object_unref); for (i=0; i<101; i++) { stats = up_stats_item_new (); g_ptr_array_add (data, stats); -- cgit v1.2.1