From f8cf52971b2dfab8b9c113706d7257e3c03c13f8 Mon Sep 17 00:00:00 2001 From: Peter Wu Date: Thu, 6 Nov 2014 18:29:07 +0100 Subject: linux: fix memleak when reading critical action g_variant_get for string types must be freed as documented at https://developer.gnome.org/glib/stable/gvariant-format-strings.html#gvariant-format-strings-strings Since we just want to compare it, use a pointer as documented at https://developer.gnome.org/glib/stable/gvariant-format-strings.html#gvariant-format-strings-pointers https://bugs.freedesktop.org/show_bug.cgi?id=82659 --- src/linux/up-backend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/linux/up-backend.c b/src/linux/up-backend.c index f588e74..f45ce29 100644 --- a/src/linux/up-backend.c +++ b/src/linux/up-backend.c @@ -346,7 +346,7 @@ check_action_result (GVariant *result) if (result) { const char *s; - g_variant_get (result, "(s)", &s); + g_variant_get (result, "(&s)", &s); if (g_strcmp0 (s, "yes") == 0) return TRUE; } -- cgit v1.2.1