From 4d0af3b31bda9270037dc18a503305fea1c5710e Mon Sep 17 00:00:00 2001 From: Bastien Nocera Date: Wed, 23 Oct 2013 18:00:37 +0200 Subject: linux: Add NoPollBatteries configuration option For system integrators. If your firmware is helpful to user space and automatically sends out uevent when the battery level changes (rather than just the battery state) as on most machines, you can enable "NoPollBatteries" in the configuration option, and reduce power consumption from UPower and its listeners. --- src/linux/up-device-supply.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/linux/up-device-supply.c b/src/linux/up-device-supply.c index 5fb7cb0..3a3ceea 100644 --- a/src/linux/up-device-supply.c +++ b/src/linux/up-device-supply.c @@ -34,6 +34,7 @@ #include #include "sysfs-utils.h" +#include "up-config.h" #include "up-types.h" #include "up-device-supply.h" @@ -58,7 +59,8 @@ struct UpDeviceSupplyPrivate guint energy_old_first; gdouble rate_old; guint unknown_retries; - gboolean enable_poll; + gboolean enable_poll; /* calculated */ + gboolean disable_battery_poll; /* from configuration */ gboolean is_power_supply; gboolean shown_invalid_voltage_warning; }; @@ -1110,8 +1112,10 @@ up_device_supply_refresh (UpDevice *device) up_device_supply_disable_poll (device); ret = up_device_supply_refresh_battery (supply, &state); /* Seems that we don't get change uevents from the - * kernel on some BIOS types */ - up_device_supply_setup_poll (device, state); + * kernel on some BIOS types, but if polling + * is disabled in the configuration, do nothing */ + if (!supply->priv->disable_battery_poll) + up_device_supply_setup_poll (device, state); break; default: up_device_supply_disable_poll (device); @@ -1135,6 +1139,8 @@ up_device_supply_refresh (UpDevice *device) static void up_device_supply_init (UpDeviceSupply *supply) { + UpConfig *config; + supply->priv = UP_DEVICE_SUPPLY_GET_PRIVATE (supply); supply->priv->enable_poll = TRUE; @@ -1143,6 +1149,10 @@ up_device_supply_init (UpDeviceSupply *supply) supply->priv->energy_old_timespec = g_new (GTimeVal, UP_DEVICE_SUPPLY_ENERGY_OLD_LENGTH); supply->priv->shown_invalid_voltage_warning = FALSE; + + config = up_config_new (); + supply->priv->disable_battery_poll = up_config_get_boolean (config, "NoPollBatteries"); + g_object_unref (config); } /** -- cgit v1.2.1