summaryrefslogtreecommitdiff
path: root/test-features.c
diff options
context:
space:
mode:
authorBen Hutchings <bhutchings@solarflare.com>2011-05-13 23:25:26 +0100
committerBen Hutchings <bhutchings@solarflare.com>2012-06-02 01:31:09 +0100
commite5c984ac501788d668e8aed1f7b1fd79ce1d93c5 (patch)
treeca1a9c90ca55cb4b0c3df0490d170ef5921d484b /test-features.c
parentf2686c1e2b988af68e0bf14cacde254b487fd4f2 (diff)
downloadethtool-e5c984ac501788d668e8aed1f7b1fd79ce1d93c5.tar.gz
Regularise offload feature settings
This is partly preparation for use of the new net device features API, but is useful in its own right. Replace repetitive code for getting/setting offload flags with data- driven loops. This changes error messages to use the same long names for offload flags as in dump_offload(), and changes various exit codes to 1. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Diffstat (limited to 'test-features.c')
-rw-r--r--test-features.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/test-features.c b/test-features.c
index 4d8680a..349bc23 100644
--- a/test-features.c
+++ b/test-features.c
@@ -62,8 +62,8 @@ static const struct cmd_expect cmd_expect_get_features_off[] = {
{ &cmd_gtso_off, 4, 0, &cmd_gtso_off, sizeof(cmd_gtso_off) },
{ &cmd_gufo_off, 4, 0, &cmd_gufo_off, sizeof(cmd_gufo_off) },
{ &cmd_ggso_off, 4, 0, &cmd_ggso_off, sizeof(cmd_ggso_off) },
- { &cmd_gflags_off, 4, 0, &cmd_gflags_off, sizeof(cmd_gflags_off) },
{ &cmd_ggro_off, 4,0, &cmd_ggro_off, sizeof(cmd_ggro_off) },
+ { &cmd_gflags_off, 4, 0, &cmd_gflags_off, sizeof(cmd_gflags_off) },
{ 0, 0, 0, 0, 0 }
};
@@ -74,9 +74,9 @@ static const struct cmd_expect cmd_expect_set_features_off[] = {
{ &cmd_stso_off, sizeof(cmd_stso_off), 0, 0, 0 },
{ &cmd_sufo_off, sizeof(cmd_sufo_off), 0, 0, 0 },
{ &cmd_sgso_off, sizeof(cmd_sgso_off), 0, 0, 0 },
+ { &cmd_sgro_off, sizeof(cmd_sgro_off), 0, 0, 0 },
{ &cmd_gflags_on, 4, 0, &cmd_gflags_on, sizeof(cmd_sflags_on) },
{ &cmd_sflags_off, sizeof(cmd_sflags_off), 0, 0, 0 },
- { &cmd_sgro_off, sizeof(cmd_sgro_off), 0, 0, 0 },
{ 0, 0, 0, 0, 0 }
};
@@ -87,9 +87,9 @@ static const struct cmd_expect cmd_expect_set_features_on[] = {
{ &cmd_stso_on, sizeof(cmd_stso_on), 0, 0, 0 },
{ &cmd_sufo_on, sizeof(cmd_sufo_on), 0, 0, 0 },
{ &cmd_sgso_on, sizeof(cmd_sgso_on), 0, 0, 0 },
+ { &cmd_sgro_on, sizeof(cmd_sgro_on), 0, 0, 0 },
{ &cmd_gflags_off, 4, 0, &cmd_gflags_on, sizeof(cmd_sflags_off) },
{ &cmd_sflags_on, sizeof(cmd_sflags_on), 0, 0, 0 },
- { &cmd_sgro_on, sizeof(cmd_sgro_on), 0, 0, 0 },
{ 0, 0, 0, 0, 0 }
};