ecc: Make "noparam" the default and replace by "param".

* src/cipher.h (PUBKEY_FLAG_NOCOMP): New.
(PUBKEY_FLAG_NOPARAM): Remove.
(PUBKEY_FLAG_PARAM): New.
* cipher/pubkey-util.c (_gcry_pk_util_parse_flaglist): Support the new
flags and ignore the obsolete "noparam" flag.
* cipher/ecc-curves.c (_gcry_ecc_fill_in_curve): Return the curve name
also for curves selected by NBITS.
(_gcry_mpi_ec_new): Support the "param" flag.
* cipher/ecc.c (ecc_generate, ecc_sign, ecc_verify): Ditto.
* tests/keygen.c (check_ecc_keys): Remove the "noparam" flag.
--

This is an API change but there are not many ECC users yet and adding
the "param" flag for those who really need the parameters (e.g. if
private keys have been stored without the curve name, it can easily be
added.

Note that no version of Libgcrypt with support for "noparam" has been
released but for the sake of projects already working with the master
version we don't bail out on "noparam".

Signed-off-by: Werner Koch <wk@gnupg.org>

1 files changed, 8 insertions, 12 deletions

diff --git a/doc/gcrypt.texi b/doc/gcrypt.texi
index 03ace833..dd65f9a3 100644
--- a/doc/gcrypt.texi
+++ b/doc/gcrypt.texi
@@ -2267,15 +2267,11 @@ order to prevent leaking of secret information.  Blinding is only
 implemented by RSA, but it might be implemented by other algorithms in
 the future as well, when necessary.
 
-@item noparam
-@cindex noparam
-For ECC key generation do not return the domain parameters but only
-the name of the curve.  For ECC signing and verification ignore any
-provided domain parameters of the public or private key and use only
-the curve name.  It is more secure to rely on the curve name and thus
-use the curve parameters as known by Libgcrypt.  This option should
-have been the default but for backward compatibility reasons this is
-not possible.  It is best to always use this flag with ECC keys.
+@item param
+@cindex param
+For ECC key generation also return the domain parameters.  For ECC
+signing and verification override default parameters by provided
+domain parameters of the public or private key.
 
 @item transient-key
 @cindex transient-key
@@ -2849,7 +2845,7 @@ is in general not recommended.
 @example
 (genkey
   (ecc
-    (flags noparam transient-key)))
+    (flags transient-key)))
 @end example
 
 @item transient-key
@@ -2894,12 +2890,12 @@ elliptic curve key generation:
   (public-key
     (ecc
       (curve Ed25519)
-      (flags noparam eddsa)
+      (flags eddsa)
       (q @var{q-value})))
   (private-key
     (ecc
       (curve Ed25519)
-      (flags noparam eddsa)
+      (flags eddsa)
       (q @var{q-value})
       (d @var{d-value}))))
 @end example