diff options
| author | Paolo Bonzini <pbonzini@redhat.com> | 2016-07-15 18:27:40 +0200 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2016-07-17 09:59:21 +0200 |
| commit | 8bff06a0bbf257a2083223534c1607bf87d913e6 (patch) | |
| tree | 2f8fc614770ff1eba201119213be7f4dd34209c8 | |
| parent | 3cbeb52467a8b8f3a836c7783a7ebc6450c5ef30 (diff) | |
| download | qemu-8bff06a0bbf257a2083223534c1607bf87d913e6.tar.gz | |
compiler: never omit assertions if using a static analysis tool
Assertions help both Coverity and the clang static analyzer avoid
false positives, but on the other hand both are confused when
the condition is compiled as (void)(x != FOO). Always expand
assertion macros when using Coverity or clang, through a new
QEMU_STATIC_ANALYSIS preprocessor symbol.
This fixes a couple false positives in TCG.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| -rw-r--r-- | include/qemu/compiler.h | 3 | ||||
| -rw-r--r-- | tcg/tcg.h | 2 |
2 files changed, 4 insertions, 1 deletions
diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h index b64f899870..338d3a65b3 100644 --- a/include/qemu/compiler.h +++ b/include/qemu/compiler.h @@ -3,6 +3,9 @@ #ifndef COMPILER_H #define COMPILER_H +#if defined __clang_analyzer__ || defined __COVERITY__ +#define QEMU_STATIC_ANALYSIS 1 +#endif /*---------------------------------------------------------------------------- | The macro QEMU_GNUC_PREREQ tests for minimum version of the GNU C compiler. @@ -191,7 +191,7 @@ typedef uint64_t tcg_insn_unit; #endif -#ifdef CONFIG_DEBUG_TCG +#if defined CONFIG_DEBUG_TCG || defined QEMU_STATIC_ANALYSIS # define tcg_debug_assert(X) do { assert(X); } while (0) #elif QEMU_GNUC_PREREQ(4, 5) # define tcg_debug_assert(X) \ |