summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarc-André Lureau <marcandre.lureau@redhat.com>2018-01-31 11:37:24 +0100
committerMarc-André Lureau <marcandre.lureau@redhat.com>2018-02-01 12:13:52 +0100
commitce6b9e421a9ab45d7e6c97af092a07c049954444 (patch)
treed8bb892712ee1ec524e6505c1b90e64ec7973fca
parentb05631954d6dfe93340d516660397e2c1a2a5dd6 (diff)
downloadqemu-ce6b9e421a9ab45d7e6c97af092a07c049954444.tar.gz
dump-guest-memory.py: skip vmcoreinfo section if not available
On some architectures, qemu doesn't support vmcoreinfo device, and dump-guest-memory fails: (gdb) dump-guest-memory /tmp/vmcore ppc64-le guest RAM blocks: target_start target_end host_addr message count ---------------- ---------------- ---------------- ------- ----- 0000000000000000 0000000200000000 00003ffd86980000 added 1 0000200080000000 0000200080800000 00003ffd86170000 added 2 Python Exception <class 'gdb.error'> No symbol "vmcoreinfo_realize" in current context.: Error occurred in Python command: No symbol "vmcoreinfo_realize" in current context. Check that vmcoreinfo_realize symbol exists before evaluating an expression with it. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
-rw-r--r--scripts/dump-guest-memory.py2
1 files changed, 2 insertions, 0 deletions
diff --git a/scripts/dump-guest-memory.py b/scripts/dump-guest-memory.py
index 03fbf69f8a..51acfcd0c0 100644
--- a/scripts/dump-guest-memory.py
+++ b/scripts/dump-guest-memory.py
@@ -546,6 +546,8 @@ shape and this command should mostly work."""
return None
def add_vmcoreinfo(self):
+ if gdb.lookup_symbol("vmcoreinfo_realize")[0] is None:
+ return
vmci = 'vmcoreinfo_realize::vmcoreinfo_state'
if not gdb.parse_and_eval("%s" % vmci) \
or not gdb.parse_and_eval("(%s)->has_vmcoreinfo" % vmci):