diff options
| author | Paolo Bonzini <pbonzini@redhat.com> | 2016-09-02 21:02:10 +0200 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2016-09-27 11:57:30 +0200 |
| commit | cf07da65f335b9a74e62f5413078f67280572f36 (patch) | |
| tree | 7768c32680b0d7b04bec4cced6e0fd22ff1dbe01 | |
| parent | c978b3168727d3a76ffcb18462ea972f50b53634 (diff) | |
| download | qemu-cf07da65f335b9a74e62f5413078f67280572f36.tar.gz | |
cpus-common: remove redundant call to exclusive_idle()
No need to call exclusive_idle() from cpu_exec_end since it is done
immediately afterwards in cpu_exec_start. Any exclusive section could
run as soon as cpu_exec_end leaves, because cpu->running is false and the
mutex is not taken, so the call does not add any protection either.
Reviewed-by: Richard Henderson <rth@twiddle.net>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| -rw-r--r-- | cpus-common.c | 1 | ||||
| -rw-r--r-- | docs/tcg-exclusive.promela | 1 |
2 files changed, 0 insertions, 2 deletions
diff --git a/cpus-common.c b/cpus-common.c index 115f3d45df..80aaf9b42d 100644 --- a/cpus-common.c +++ b/cpus-common.c @@ -221,7 +221,6 @@ void cpu_exec_end(CPUState *cpu) qemu_cond_signal(&exclusive_cond); } } - exclusive_idle(); qemu_mutex_unlock(&qemu_cpu_list_lock); } diff --git a/docs/tcg-exclusive.promela b/docs/tcg-exclusive.promela index 5889b40638..8bb0967df6 100644 --- a/docs/tcg-exclusive.promela +++ b/docs/tcg-exclusive.promela @@ -124,7 +124,6 @@ byte has_waiter[N_CPUS]; } \ :: else -> skip; \ fi; \ - exclusive_idle(); \ MUTEX_UNLOCK(mutex); // Promela processes |