diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2016-06-20 21:31:46 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2016-07-05 16:46:27 +0200 |
| commit | a03ef88f77af045a2eb9629b5ce774a3fb973c5e (patch) | |
| tree | eb38df63cf3b067a09f27681fa9ef55a1988776d /block/bochs.c | |
| parent | e293b7a3dff232ddf71e92ea88961b597586911e (diff) | |
| download | qemu-a03ef88f77af045a2eb9629b5ce774a3fb973c5e.tar.gz | |
block: Convert bdrv_co_preadv/pwritev to BdrvChild
This is the final patch for converting the common I/O path to take
a BdrvChild parameter instead of BlockDriverState.
The completion of this conversion means that all users that perform I/O
on an image need to actually hold a reference (in the form of BdrvChild,
possible as part of a BlockBackend) to that image. This also protects
against inconsistent use of BlockBackend vs. BlockDriverState functions
because direct use of a BlockDriverState isn't possible any more and
blk->root is private for block-backends.c.
In addition, we can now distinguish different users in the I/O path,
and the future op blockers work is going to add assertions based on
permissions stored in BdrvChild.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'block/bochs.c')
| -rw-r--r-- | block/bochs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/block/bochs.c b/block/bochs.c index 46f635f2e7..8c9652ebeb 100644 --- a/block/bochs.c +++ b/block/bochs.c @@ -255,7 +255,7 @@ bochs_co_preadv(BlockDriverState *bs, uint64_t offset, uint64_t bytes, qemu_iovec_concat(&local_qiov, qiov, bytes_done, 512); if (block_offset > 0) { - ret = bdrv_co_preadv(bs->file->bs, block_offset, 512, + ret = bdrv_co_preadv(bs->file, block_offset, 512, &local_qiov, 0); if (ret < 0) { goto fail; |