diff options
| author | Stefan Hajnoczi <stefanha@redhat.com> | 2017-05-22 14:57:02 +0100 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2017-06-26 14:51:13 +0200 |
| commit | ea17c9d20d7396351be5e14317354519ff53721d (patch) | |
| tree | 5d0b21d9906d6b2144ff19c45bf24787cc11a0ee /block/io.c | |
| parent | dc88a467ec7214c3086094033daf2aba554337b1 (diff) | |
| download | qemu-ea17c9d20d7396351be5e14317354519ff53721d.tar.gz | |
block: use BDRV_POLL_WHILE() in bdrv_rw_vmstate()
Calling aio_poll() directly may have been fine previously, but this is
the future, man! The difference between an aio_poll() loop and
BDRV_POLL_WHILE() is that BDRV_POLL_WHILE() releases the AioContext
around aio_poll().
This allows the IOThread to run fd handlers or BHs to complete the
request. Failure to release the AioContext causes deadlocks.
Using BDRV_POLL_WHILE() partially fixes a 'savevm' hang with -object
iothread.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block/io.c')
| -rw-r--r-- | block/io.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/block/io.c b/block/io.c index 684ea465c7..e158ae0174 100644 --- a/block/io.c +++ b/block/io.c @@ -2023,9 +2023,7 @@ bdrv_rw_vmstate(BlockDriverState *bs, QEMUIOVector *qiov, int64_t pos, Coroutine *co = qemu_coroutine_create(bdrv_co_rw_vmstate_entry, &data); bdrv_coroutine_enter(bs, co); - while (data.ret == -EINPROGRESS) { - aio_poll(bdrv_get_aio_context(bs), true); - } + BDRV_POLL_WHILE(bs, data.ret == -EINPROGRESS); return data.ret; } } |