summaryrefslogtreecommitdiff
path: root/block/linux-aio.c
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@redhat.com>2014-05-08 16:34:48 +0200
committerStefan Hajnoczi <stefanha@redhat.com>2014-06-04 09:56:11 +0200
commitabd269b7cf1f084a067731acb8f3272c193cb5f0 (patch)
tree62f15b0771a9e495eb90be2621e0c3df23060c6a /block/linux-aio.c
parentc2f3426c9bba0195b15a919587f794b110a2dcfc (diff)
downloadqemu-abd269b7cf1f084a067731acb8f3272c193cb5f0.tar.gz
block/linux-aio: fix memory and fd leak
Hot unplugging -drive aio=native,file=test.img,format=raw images leaves the Linux AIO event notifier and struct qemu_laio_state allocated. Luckily nothing will use the event notifier after the BlockDriverState has been closed so the handler function is never called. It's still worth fixing this resource leak. Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'block/linux-aio.c')
-rw-r--r--block/linux-aio.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/block/linux-aio.c b/block/linux-aio.c
index 7ff3897fec..f0a2c087b2 100644
--- a/block/linux-aio.c
+++ b/block/linux-aio.c
@@ -212,3 +212,11 @@ out_free_state:
g_free(s);
return NULL;
}
+
+void laio_cleanup(void *s_)
+{
+ struct qemu_laio_state *s = s_;
+
+ event_notifier_cleanup(&s->e);
+ g_free(s);
+}