diff options
| author | Peter Lieven <pl@kamp.de> | 2017-11-27 17:00:07 +0100 |
|---|---|---|
| committer | Max Reitz <mreitz@redhat.com> | 2017-11-29 15:28:15 +0100 |
| commit | f1a7ff770f7d71ee7833ff019aac9d6cc3d13f71 (patch) | |
| tree | d49e6cb415f2823f007d774e95531de2a765b86e /block/nfs.c | |
| parent | fc24908e7d232b79c2a6f0363f52bda18dedb57b (diff) | |
| download | qemu-f1a7ff770f7d71ee7833ff019aac9d6cc3d13f71.tar.gz | |
block/nfs: fix nfs_client_open for filesize greater than 1TB
DIV_ROUND_UP(st.st_size, BDRV_SECTOR_SIZE) was overflowing ret (int) if
st.st_size is greater than 1TB.
Cc: qemu-stable@nongnu.org
Signed-off-by: Peter Lieven <pl@kamp.de>
Message-id: 1511798407-31129-1-git-send-email-pl@kamp.de
Signed-off-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'block/nfs.c')
| -rw-r--r-- | block/nfs.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/block/nfs.c b/block/nfs.c index 337fcd9c84..effc8719b5 100644 --- a/block/nfs.c +++ b/block/nfs.c @@ -1,7 +1,7 @@ /* * QEMU Block driver for native access to files on NFS shares * - * Copyright (c) 2014-2016 Peter Lieven <pl@kamp.de> + * Copyright (c) 2014-2017 Peter Lieven <pl@kamp.de> * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to deal @@ -496,7 +496,7 @@ out: static int64_t nfs_client_open(NFSClient *client, QDict *options, int flags, int open_flags, Error **errp) { - int ret = -EINVAL; + int64_t ret = -EINVAL; QemuOpts *opts = NULL; Error *local_err = NULL; struct stat st; @@ -686,8 +686,7 @@ static QemuOptsList nfs_create_opts = { static int nfs_file_create(const char *url, QemuOpts *opts, Error **errp) { - int ret = 0; - int64_t total_size = 0; + int64_t ret, total_size; NFSClient *client = g_new0(NFSClient, 1); QDict *options = NULL; |