summaryrefslogtreecommitdiff
path: root/bsd-user/mmap.c
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2017-07-20 17:31:30 +0100
committerPeter Maydell <peter.maydell@linaro.org>2017-07-21 10:32:41 +0100
commit95a5befc2f8b359e72926f89cd661d063c2cf06c (patch)
tree6589dd6adba5d123145be8e25e29e1bd0a8e69aa /bsd-user/mmap.c
parent02ffa034fb747f09a4f5658ed64871dcee4aaca2 (diff)
downloadqemu-95a5befc2f8b359e72926f89cd661d063c2cf06c.tar.gz
Use qemu_tolower() and qemu_toupper(), not tolower() and toupper()
On NetBSD, where tolower() and toupper() are implemented using an array lookup, the compiler warns if you pass a plain 'char' to these functions: gdbstub.c:914:13: warning: array subscript has type 'char' This reflects the fact that toupper() and tolower() give undefined behaviour if they are passed a value that isn't a valid 'unsigned char' or EOF. We have qemu_tolower() and qemu_toupper() to avoid this problem; use them. (The use in scsi-generic.c does not trigger the warning because it passes a uint8_t; we switch it anyway, for consistency.) Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Eric Blake <eblake@redhat.com> Reviewed-by: Richard Henderson <rth@twiddle.net> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com> for the s390 part. Acked-by: David Gibson <david@gibson.dropbear.id.au> Message-id: 1500568290-7966-1-git-send-email-peter.maydell@linaro.org
Diffstat (limited to 'bsd-user/mmap.c')
0 files changed, 0 insertions, 0 deletions