summaryrefslogtreecommitdiff
path: root/chardev
diff options
context:
space:
mode:
authorEric Blake <eblake@redhat.com>2017-09-25 09:55:17 -0500
committerKevin Wolf <kwolf@redhat.com>2017-10-06 16:28:58 +0200
commitf798184cfdcb7f92a38c5f717d675bd75e1fd3ac (patch)
tree74d7d2a3b8849972800879eaaa512335633f1a0b /chardev
parent715a74d819926af38bfeddb3ae29c9fe6b7736bb (diff)
downloadqemu-f798184cfdcb7f92a38c5f717d675bd75e1fd3ac.tar.gz
dirty-bitmap: Change bdrv_dirty_iter_next() to report byte offset
Thanks to recent cleanups, most callers were scaling a return value of sectors into bytes (the exception, in qcow2-bitmap, will be converted to byte-based iteration later). Update the interface to do the scaling internally instead. In qcow2-bitmap, the code was specifically checking for an error return of -1. To avoid a regression, we either have to make sure we continue to return -1 (rather than a scaled -512) on error, or we have to fix the caller to treat all negative values as error rather than just one magic value. It's easy enough to make both changes at the same time, even though either one in isolation would work. Signed-off-by: Eric Blake <eblake@redhat.com> Reviewed-by: John Snow <jsnow@redhat.com> Reviewed-by: Kevin Wolf <kwolf@redhat.com> Reviewed-by: Fam Zheng <famz@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'chardev')
0 files changed, 0 insertions, 0 deletions